From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: michael.hennerich@analog.com
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] input:touchscreen:ad7879-spi.c: Fix regmap flag_masks
Date: Thu, 23 Feb 2017 00:43:48 -0800 [thread overview]
Message-ID: <20170223084348.GK18639@dtor-ws> (raw)
In-Reply-To: <1487780078-18510-2-git-send-email-michael.hennerich@analog.com>
On Wed, Feb 22, 2017 at 05:14:35PM +0100, michael.hennerich@analog.com wrote:
> From: Michael Hennerich <michael.hennerich@analog.com>
>
> Mask only applied to the top byte of the register
>
> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Thank you Michael, I folded it with the patch introducing regmaps.
> ---
> drivers/input/touchscreen/ad7879-spi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/touchscreen/ad7879-spi.c b/drivers/input/touchscreen/ad7879-spi.c
> index f2c06b5..b995891 100644
> --- a/drivers/input/touchscreen/ad7879-spi.c
> +++ b/drivers/input/touchscreen/ad7879-spi.c
> @@ -19,8 +19,8 @@
>
> #define MAX_SPI_FREQ_HZ 5000000
>
> -#define AD7879_CMD_MAGIC 0xE000
> -#define AD7879_CMD_READ BIT(10)
> +#define AD7879_CMD_MAGIC 0xE0
> +#define AD7879_CMD_READ BIT(2)
>
> static const struct regmap_config ad7879_spi_regmap_config = {
> .reg_bits = 16,
> --
> 2.7.4
>
--
Dmitry
next prev parent reply other threads:[~2017-02-23 8:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-22 16:14 [PATCH 0/4] Input: ad7879 RFC/RFT follow-up michael.hennerich
2017-02-22 16:14 ` michael.hennerich
2017-02-22 16:14 ` [PATCH 1/4] input:touchscreen:ad7879-spi.c: Fix regmap flag_masks michael.hennerich
2017-02-22 16:14 ` michael.hennerich
2017-02-23 8:43 ` Dmitry Torokhov [this message]
2017-02-22 16:14 ` [PATCH 2/4] input:touchscreen:ad7879-spi.c: Remove bits_per_word = 16 enforcement michael.hennerich
2017-02-22 16:14 ` michael.hennerich
2017-02-23 8:41 ` Dmitry Torokhov
2017-02-22 16:14 ` [PATCH 3/4] Documentation: Add SPI example michael.hennerich
2017-02-22 16:14 ` michael.hennerich
2017-02-23 8:42 ` Dmitry Torokhov
2017-02-22 16:14 ` [PATCH 4/4] input:touchscreen:ad7879: Update MODULE_AUTHOR email address michael.hennerich
2017-02-22 16:14 ` michael.hennerich
2017-02-23 8:42 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170223084348.GK18639@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.