From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Perform link quality check unconditionally during long pulse Date: Thu, 23 Feb 2017 11:22:57 +0200 Message-ID: <20170223092257.GN31595@intel.com> References: <20170216152659.GD31595@intel.com> <20170216153007.14868-1-ville.syrjala@linux.intel.com> <20170216170753.GA27437@intel.com> <20170216171857.GI31595@intel.com> <20170216172409.GB27437@intel.com> <20170216174626.GJ31595@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id A02286E9A9 for ; Thu, 23 Feb 2017 09:23:05 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Palmer Dabbelt Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBGZWIgMjIsIDIwMTcgYXQgMDg6MDA6MzhQTSAtMDgwMCwgUGFsbWVyIERhYmJlbHQg d3JvdGU6Cj4gT24gVGh1LCBGZWIgMTYsIDIwMTcgYXQgOTo0NiBBTSwgVmlsbGUgU3lyasOkbMOk Cj4gPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPiB3cm90ZToKPiA+IE9uIFRodSwgRmVi IDE2LCAyMDE3IGF0IDA5OjI0OjA5QU0gLTA4MDAsIE1hbmFzaSBOYXZhcmUgd3JvdGU6Cj4gPj4g T24gVGh1LCBGZWIgMTYsIDIwMTcgYXQgMDc6MTg6NTdQTSArMDIwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+ID4+ID4gT24gVGh1LCBGZWIgMTYsIDIwMTcgYXQgMDk6MDc6NTNBTSAtMDgwMCwg TWFuYXNpIE5hdmFyZSB3cm90ZToKPiA+PiA+ID4gT24gVGh1LCBGZWIgMTYsIDIwMTcgYXQgMDU6 MzA6MDdQTSArMDIwMCwgdmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20gd3JvdGU6Cj4gPj4g PiA+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNv bT4KPiA+PiA+ID4gPgo+ID4+ID4gPiA+IEFwcGFyZW50bHkgc29tZSBEUCBzaW5rcyBhcmUgYSBs aXR0bGUgbnV0cyBhbmQgY2F1c2UgSFBEIHRvIGRyb3AKPiA+PiA+ID4gPiBpbnRlcm1pdHRlbnRs eSBkdXJpbmcgbW9kZXNldHMuIFRoaXMgaGFwcGVucyBlZy4gb24gYW4gQVNVUyBQQjI4N1EuCj4g Pj4gPiA+ID4gSW4gb2RlciB0byByZWNvdmVyIGZyb20gdGhpcyB3ZSBjYW4ndCByZWFsbHkgdXNl IHRoZSBwcmV2aW91cwo+ID4+ID4gPiA+IGNvbm5lY3RvciBzdGF0dXMgdG8gZGV0ZXJtaW5lIGlm IHRoZSBsaW5rIG5lZWRzIHJldHJhaW5pbmcsIHNvIGxldCdzCj4gPj4gPiA+ID4ganVzdCBpZ25v cmUgdGhhdCBwaWVjZSBvZiBpbmZvcm1hdGlvbiBhbmQgZG8gdGhlIHJldHJhaW4KPiA+PiA+ID4g PiB1bmNvbmRpdGlvbmFsbHkuIFdlIGRvIG9mIGNvdXJzZSBzdGlsbCBjaGVjayB3aGV0aGVyIHRo ZSBsaW5rIGlzCj4gPj4gPiA+ID4gc3VwcG9zZWQgdG8gYmUgcnVubmluZyBvciBub3QuCj4gPj4g PiA+ID4KPiA+PiA+ID4gPiBDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZwo+ID4+ID4gPiA+IENj OiBQYWxtZXIgRGFiYmVsdCA8cGFsbWVyQGRhYmJlbHQuY29tPgo+ID4+ID4gPiA+IFJlcG9ydGVk LWJ5OiBQYWxtZXIgRGFiYmVsdCA8cGFsbWVyQGRhYmJlbHQuY29tPgo+ID4+ID4gPiA+IFJlZmVy ZW5jZXM6IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL2FyY2hpdmVzL2ludGVsLWdmeC8y MDE3LUZlYnJ1YXJ5LzExOTc3OS5odG1sCj4gPj4gPiA+ID4gU2lnbmVkLW9mZi1ieTogVmlsbGUg U3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+PiA+ID4gPiAtLS0K PiA+PiA+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyB8IDE1ICsrKysrKysr KysrLS0tLQo+ID4+ID4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgMTEgaW5zZXJ0aW9ucygrKSwgNCBk ZWxldGlvbnMoLSkKPiA+PiA+ID4gPgo+ID4+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kcC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ ID4+ID4gPiA+IGluZGV4IDAyNDc5OGE5YzAxNi4uMzdhNzQ2ZjdmYmMzIDEwMDY0NAo+ID4+ID4g PiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiA+PiA+ID4gPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gPj4gPiA+ID4gQEAgLTQ2NDgsMTEg KzQ2NDgsMTggQEAgaW50ZWxfZHBfbG9uZ19wdWxzZShzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpp bnRlbF9jb25uZWN0b3IpCj4gPj4gPiA+ID4gICAgICAgICAgICAgICAgICAqLwo+ID4+ID4gPiA+ ICAgICAgICAgICAgICAgICBzdGF0dXMgPSBjb25uZWN0b3Jfc3RhdHVzX2Rpc2Nvbm5lY3RlZDsK PiA+PiA+ID4gPiAgICAgICAgICAgICAgICAgZ290byBvdXQ7Cj4gPj4gPiA+ID4gLSAgICAgICB9 IGVsc2UgaWYgKGNvbm5lY3Rvci0+c3RhdHVzID09IGNvbm5lY3Rvcl9zdGF0dXNfY29ubmVjdGVk KSB7Cj4gPj4gPiA+ID4gKyAgICAgICB9IGVsc2Ugewo+ID4+ID4gPiA+ICAgICAgICAgICAgICAg ICAvKgo+ID4+ID4gPiA+IC0gICAgICAgICAgICAgICAgKiBJZiBkaXNwbGF5IHdhcyBjb25uZWN0 ZWQgYWxyZWFkeSBhbmQgaXMgc3RpbGwgY29ubmVjdGVkCj4gPj4gPiA+ID4gLSAgICAgICAgICAg ICAgICAqIGNoZWNrIGxpbmtzIHN0YXR1cywgdGhlcmUgaGFzIGJlZW4ga25vd24gaXNzdWVzIG9m Cj4gPj4gPiA+ID4gLSAgICAgICAgICAgICAgICAqIGxpbmsgbG9zcyB0cmlnZ2VycmluZyBsb25n IHB1bHNlISEhIQo+ID4+ID4gPiA+ICsgICAgICAgICAgICAgICAgKiBJZiBkaXNwbGF5IGlzIG5v dyBjb25uZWN0ZWQgY2hlY2sgbGlua3Mgc3RhdHVzLAo+ID4+ID4gPiA+ICsgICAgICAgICAgICAg ICAgKiB0aGVyZSBoYXMgYmVlbiBrbm93biBpc3N1ZXMgb2YgbGluayBsb3NzIHRyaWdnZXJyaW5n Cj4gPj4gPiA+ID4gKyAgICAgICAgICAgICAgICAqIGxvbmcgcHVsc2UuCj4gPj4gPiA+ID4gKyAg ICAgICAgICAgICAgICAqCj4gPj4gPiA+ID4gKyAgICAgICAgICAgICAgICAqIFNvbWUgc2lua3Mg KGVnLiBBU1VTIFBCMjg3USkgc2VlbSB0byBwZXJmb3JtIHNvbWUKPiA+PiA+ID4gPiArICAgICAg ICAgICAgICAgICogd2VpcmQgSFBEIHBpbmcgcG9uZyBkdXJpbmcgbW9kZXNldHMuIFNvIHdlIGNh biBhcHBhcmVseQo+ID4+ID4gPiA+ICsgICAgICAgICAgICAgICAgKiBlbmQgdXAgd2l0aCBIUEQg Z29pbmcgbG93IGR1cmluZyBhIG1vZGVzZXQsIGFuZCB0aGVuCj4gPj4gPiA+ID4gKyAgICAgICAg ICAgICAgICAqIGdvaW5nIGJhY2sgdXAgc29vbiBhZnRlci4gQW5kIG9uY2UgdGhhdCBoYXBwZW5z IHdlIG11c3QKPiA+PiA+ID4gPiArICAgICAgICAgICAgICAgICogcmV0cmFpbiB0aGUgbGluayB0 byBnZXQgYSBwaWN0dXJlLiBUaGF0J3MgaW4gY2FzZSBubwo+ID4+ID4gPiA+ICsgICAgICAgICAg ICAgICAgKiB1c2Vyc3BhY2UgY29tcG9uZW50IHJlYWN0ZWQgdG8gaW50ZXJtaXR0ZW50IEhQRCBk aXAuCj4gPj4gPiA+ID4gICAgICAgICAgICAgICAgICAqLwo+ID4+ID4gPiA+ICAgICAgICAgICAg ICAgICBkcm1fbW9kZXNldF9sb2NrKCZkZXYtPm1vZGVfY29uZmlnLmNvbm5lY3Rpb25fbXV0ZXgs IE5VTEwpOwo+ID4+ID4gPiA+ICAgICAgICAgICAgICAgICBpbnRlbF9kcF9jaGVja19saW5rX3N0 YXR1cyhpbnRlbF9kcCk7Cj4gPj4gPiA+ID4gLS0KPiA+PiA+ID4KPiA+PiA+ID4gU28gaGVyZSB3 ZSBiYXNpY2FsbHkganVzdCBpZ25vcmUgdGhlIGNvbm5lY3RvciBzdGF0dXMgYW5kIHJldHJhaW4g aXJyZXNwZWN0aXZlbHkuCj4gPj4gPgo+ID4+ID4gV2UgaWdub3JlIHRoZSBfcHJldmlvdXNfIGNv bm5lY3RvciBzdGF0dXMuCj4gPj4gPgo+ID4+ID4gPiBCdXQgdGhhdCBtZWFucyBldmVuIGlmIHdl IGhhdmUgbmV3ZXIgdmFsdWVzIG5vdyBmb3IgbWF4IGxpbmsgcmF0ZS9sYW5lIGNvdW50IGZyb20K PiA+PiA+ID4gRFBDRCwgZHVyaW5nIHRoaXMgcmV0cmFpbiB3ZSBhcmUganVzdCB1c2luZyB0aGUg c3RhbGUgdmFsdWUgb2YgaW50ZWxfZHAtPmxpbmtfcmF0ZQo+ID4+ID4gPiBhbmQgaW50ZWxfZHAt PmxhbmVfY291bnQuIEkgdGhpbmsgaW50ZWxfZHAtPmxpbmtfcmF0ZSBhbmQgbGFuZSBjb3VudCB2 YWx1ZXMKPiA+PiA+ID4gc2hvdWxkIGJlIHNldCB0byAwIG9uIEhQRCBwdWxzZSwgdGhleSB3b3Vs ZCBiZSBzZXQgb25seSBkdXJpbmcgYSBtb2Rlc2V0Lgo+ID4+ID4KPiA+PiA+IFRoZSBEUENEIGhh cyBhbHJlYWR5IGJlZW4gcGFyc2VkIGJ5IHRoaXMgdGltZS4KPiA+PiA+Cj4gPj4gPiAtLQo+ID4+ ID4gVmlsbGUgU3lyasOkbMOkCj4gPj4gPiBJbnRlbCBPVEMKPiA+Pgo+ID4+IFllcywgd2UgaGF2 ZSBwYXJzZWQgdGhlIERQQ0QgYnV0IHdlIGRvbnQgd3JpdGUgdG8gaW50ZWxfZHAtPmxpbmstcmF0 ZSBhbmQgaW50ZWxfZHAtPmxhbmVfY291bnQKPiA+PiB1bnRpbCB3ZSBkbyBhIG1vZGVzZXQgKHRo ZXNlIGdldCB3cml0dGVuIGR1cmluZyBwcmVfZW5hYmxlKSBhbmQgdGhlc2UgdmFsdWVzIGdldCB1 c2VkCj4gPj4gZHVyaW5nIHRoZSByZXRyYWluaW5nIG9mIHRoZSBsaW5rLiBTbyBhdCB0aGlzIHBv aW50IHdlIHdpbGwgc3RpbGwgdXNlIHN0YWxlIHZhbHVlcy4KPiA+Cj4gPiBUaGV5J3JlIG5vdCBz dGFsZS4gVGhleSdyZSBleGFjdGx5IHdoYXQgd2UgdXNlZCB3aGVuIHdlIHNldCB1cCB0aGUKPiA+ IG1vZGUgdGhhdCdzIHN0aWxsIGJlaW5nIGRyaXZlIG91dC4gVGhpcyBpcyBqdXN0IHJldHJhaW5p bmcgdGhlIGxpbmsKPiA+IGF0IHRoZSBzYW1lIHBhcmFtZXRlcnMuCj4gPgo+ID4+IFNob3VsZG50 IHdlIHNldCB0aGUgbGluayBzdGF0dXMgdG8gQkFEIGFuZCBzZW5kIGEgaG90cGx1ZyBldmVudCwg bGlrZSB0aGUgc29sdXRpb24gd2UgaW1wbGVtbmV0ZWQKPiA+PiBmb3IgcmV0cmFpbmluZz8KPiA+ Pgo+ID4+IFJlZ2FyZHMKPiA+PiBNYW5hc2kKPiA+Pgo+ID4+IFJlZ2FyZHMKPiA+PiBNYW5hc2kK PiA+Cj4gPiAtLQo+ID4gVmlsbGUgU3lyasOkbMOkCj4gPiBJbnRlbCBPVEMKPiAKPiBTb3JyeSwg SSBmb3Jnb3QgYWJvdXQgdGhpcy4gIEEgbG9nIGlzIGF0dGFjaGVkIG9mIG15IG1hY2hpbmUgYm9v dGluZwo+IHdpdGggdGhlIG1vbml0b3IgYXR0YWNoZWQsIG1lIGRldGFjaGluZyB0aGUgbW9uaXRv ciwgYW5kIHRoZW4gcGx1Z2dpbmcKPiBpdCBiYWNrIGluLgoKSSB3YXMgYWN0dWFsbHkgYWJsZSB0 byByZXByb2R1Y2UgdGhpcyB5ZXN0ZXJkYXkgd2l0aCBvbmUgcGFydGljdWxhcgprZXJuZWwuIEl0 IGxvb2tlZCBsaWtlIGl0IHdhc24ndCBldmVuIHRyeWluZyB0byBkbyB0aGUgRURJRCByZWFkLiBO b3QKc3VyZSB3aHkuIEFuZCBJIHdhc24ndCBhYmxlIHJlcHJvZHVjZSBpdCBhbnltb3JlIHdpdGgg dGhlIGxhdGVzdApkcm0tdGlwLiBJIHNob3VsZCBwcm9iYWJseSB0cnkgdG8gZmlndXJlIG91dCB3 aGF0IGNoYW5nZWQuLi4KCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxp c3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com ([192.55.52.88]:2299 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751131AbdBWJXf (ORCPT ); Thu, 23 Feb 2017 04:23:35 -0500 Date: Thu, 23 Feb 2017 11:22:57 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Palmer Dabbelt Cc: Manasi Navare , intel-gfx@lists.freedesktop.org, stable@vger.kernel.org Subject: Re: [Intel-gfx] [PATCH] drm/i915: Perform link quality check unconditionally during long pulse Message-ID: <20170223092257.GN31595@intel.com> References: <20170216152659.GD31595@intel.com> <20170216153007.14868-1-ville.syrjala@linux.intel.com> <20170216170753.GA27437@intel.com> <20170216171857.GI31595@intel.com> <20170216172409.GB27437@intel.com> <20170216174626.GJ31595@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: stable-owner@vger.kernel.org List-ID: On Wed, Feb 22, 2017 at 08:00:38PM -0800, Palmer Dabbelt wrote: > On Thu, Feb 16, 2017 at 9:46 AM, Ville Syrj�l� > wrote: > > On Thu, Feb 16, 2017 at 09:24:09AM -0800, Manasi Navare wrote: > >> On Thu, Feb 16, 2017 at 07:18:57PM +0200, Ville Syrj�l� wrote: > >> > On Thu, Feb 16, 2017 at 09:07:53AM -0800, Manasi Navare wrote: > >> > > On Thu, Feb 16, 2017 at 05:30:07PM +0200, ville.syrjala@linux.intel.com wrote: > >> > > > From: Ville Syrj�l� > >> > > > > >> > > > Apparently some DP sinks are a little nuts and cause HPD to drop > >> > > > intermittently during modesets. This happens eg. on an ASUS PB287Q. > >> > > > In oder to recover from this we can't really use the previous > >> > > > connector status to determine if the link needs retraining, so let's > >> > > > just ignore that piece of information and do the retrain > >> > > > unconditionally. We do of course still check whether the link is > >> > > > supposed to be running or not. > >> > > > > >> > > > Cc: stable@vger.kernel.org > >> > > > Cc: Palmer Dabbelt > >> > > > Reported-by: Palmer Dabbelt > >> > > > References: https://lists.freedesktop.org/archives/intel-gfx/2017-February/119779.html > >> > > > Signed-off-by: Ville Syrj�l� > >> > > > --- > >> > > > drivers/gpu/drm/i915/intel_dp.c | 15 +++++++++++---- > >> > > > 1 file changed, 11 insertions(+), 4 deletions(-) > >> > > > > >> > > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > >> > > > index 024798a9c016..37a746f7fbc3 100644 > >> > > > --- a/drivers/gpu/drm/i915/intel_dp.c > >> > > > +++ b/drivers/gpu/drm/i915/intel_dp.c > >> > > > @@ -4648,11 +4648,18 @@ intel_dp_long_pulse(struct intel_connector *intel_connector) > >> > > > */ > >> > > > status = connector_status_disconnected; > >> > > > goto out; > >> > > > - } else if (connector->status == connector_status_connected) { > >> > > > + } else { > >> > > > /* > >> > > > - * If display was connected already and is still connected > >> > > > - * check links status, there has been known issues of > >> > > > - * link loss triggerring long pulse!!!! > >> > > > + * If display is now connected check links status, > >> > > > + * there has been known issues of link loss triggerring > >> > > > + * long pulse. > >> > > > + * > >> > > > + * Some sinks (eg. ASUS PB287Q) seem to perform some > >> > > > + * weird HPD ping pong during modesets. So we can apparely > >> > > > + * end up with HPD going low during a modeset, and then > >> > > > + * going back up soon after. And once that happens we must > >> > > > + * retrain the link to get a picture. That's in case no > >> > > > + * userspace component reacted to intermittent HPD dip. > >> > > > */ > >> > > > drm_modeset_lock(&dev->mode_config.connection_mutex, NULL); > >> > > > intel_dp_check_link_status(intel_dp); > >> > > > -- > >> > > > >> > > So here we basically just ignore the connector status and retrain irrespectively. > >> > > >> > We ignore the _previous_ connector status. > >> > > >> > > But that means even if we have newer values now for max link rate/lane count from > >> > > DPCD, during this retrain we are just using the stale value of intel_dp->link_rate > >> > > and intel_dp->lane_count. I think intel_dp->link_rate and lane count values > >> > > should be set to 0 on HPD pulse, they would be set only during a modeset. > >> > > >> > The DPCD has already been parsed by this time. > >> > > >> > -- > >> > Ville Syrj�l� > >> > Intel OTC > >> > >> Yes, we have parsed the DPCD but we dont write to intel_dp->link-rate and intel_dp->lane_count > >> until we do a modeset (these get written during pre_enable) and these values get used > >> during the retraining of the link. So at this point we will still use stale values. > > > > They're not stale. They're exactly what we used when we set up the > > mode that's still being drive out. This is just retraining the link > > at the same parameters. > > > >> Shouldnt we set the link status to BAD and send a hotplug event, like the solution we implemneted > >> for retraining? > >> > >> Regards > >> Manasi > >> > >> Regards > >> Manasi > > > > -- > > Ville Syrj�l� > > Intel OTC > > Sorry, I forgot about this. A log is attached of my machine booting > with the monitor attached, me detaching the monitor, and then plugging > it back in. I was actually able to reproduce this yesterday with one particular kernel. It looked like it wasn't even trying to do the EDID read. Not sure why. And I wasn't able reproduce it anymore with the latest drm-tip. I should probably try to figure out what changed... -- Ville Syrj�l� Intel OTC