From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Thu, 23 Feb 2017 11:20:19 +0000 Subject: Re: [Intel-gfx] [patch] drm/i915: return false on failure in intel_dp_compute_config() Message-Id: <20170223112019.GC4196@mwanda> List-Id: References: <20170223103956.GA27484@mwanda> <1487848154.3052.40.camel@linux.intel.com> In-Reply-To: <1487848154.3052.40.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Joonas Lahtinen Cc: David Airlie , intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter On Thu, Feb 23, 2017 at 01:09:14PM +0200, Joonas Lahtinen wrote: > On to, 2017-02-23 at 13:39 +0300, Dan Carpenter wrote: > > This function is a bool type where we are supposed to return false on > > failure and true on success.=A0=A0Negative error codes are currently tr= eated > > as true. > >=20 > > Fixes: a1b2278e4dfc ("drm/i915: skylake panel fitting using shared scal= ers") > > Signed-off-by: Dan Carpenter >=20 > >=20 > >=20 > > @@ -1637,10 +1637,8 @@ intel_dp_compute_config(struct intel_encoder *en= coder, > > =A0 =A0=A0=A0=A0=A0=A0=A0adjusted_mode); > > =A0 > > =A0 if (INTEL_GEN(dev_priv) >=3D 9) { > > - int ret; > > - ret =3D skl_update_scaler_crtc(pipe_config); > > - if (ret) > > - return ret; > > + if (skl_update_scaler_crtc(pipe_config)) > > + return false; > > =A0 } >=20 > You can drop the braces, too. >=20 Multi-line indents get braces for readability. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [patch] drm/i915: return false on failure in intel_dp_compute_config() Date: Thu, 23 Feb 2017 14:20:19 +0300 Message-ID: <20170223112019.GC4196@mwanda> References: <20170223103956.GA27484@mwanda> <1487848154.3052.40.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1487848154.3052.40.camel@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Joonas Lahtinen Cc: David Airlie , intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBGZWIgMjMsIDIwMTcgYXQgMDE6MDk6MTRQTSArMDIwMCwgSm9vbmFzIExhaHRpbmVu IHdyb3RlOgo+IE9uIHRvLCAyMDE3LTAyLTIzIGF0IDEzOjM5ICswMzAwLCBEYW4gQ2FycGVudGVy IHdyb3RlOgo+ID4gVGhpcyBmdW5jdGlvbiBpcyBhIGJvb2wgdHlwZSB3aGVyZSB3ZSBhcmUgc3Vw cG9zZWQgdG8gcmV0dXJuIGZhbHNlIG9uCj4gPiBmYWlsdXJlIGFuZCB0cnVlIG9uIHN1Y2Nlc3Mu wqDCoE5lZ2F0aXZlIGVycm9yIGNvZGVzIGFyZSBjdXJyZW50bHkgdHJlYXRlZAo+ID4gYXMgdHJ1 ZS4KPiA+IAo+ID4gRml4ZXM6IGExYjIyNzhlNGRmYyAoImRybS9pOTE1OiBza3lsYWtlIHBhbmVs IGZpdHRpbmcgdXNpbmcgc2hhcmVkIHNjYWxlcnMiKQo+ID4gU2lnbmVkLW9mZi1ieTogRGFuIENh cnBlbnRlciA8ZGFuLmNhcnBlbnRlckBvcmFjbGUuY29tPgo+IAo+IDxTTklQPgo+IAo+ID4gCj4g PiBAQCAtMTYzNywxMCArMTYzNyw4IEBAIGludGVsX2RwX2NvbXB1dGVfY29uZmlnKHN0cnVjdCBp bnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ID4gwqAJCQkJwqDCoMKgwqDCoMKgwqBhZGp1c3RlZF9t b2RlKTsKPiA+IMKgCj4gPiDCoAkJaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gOSkgewo+ID4g LQkJCWludCByZXQ7Cj4gPiAtCQkJcmV0ID0gc2tsX3VwZGF0ZV9zY2FsZXJfY3J0YyhwaXBlX2Nv bmZpZyk7Cj4gPiAtCQkJaWYgKHJldCkKPiA+IC0JCQkJcmV0dXJuIHJldDsKPiA+ICsJCQlpZiAo c2tsX3VwZGF0ZV9zY2FsZXJfY3J0YyhwaXBlX2NvbmZpZykpCj4gPiArCQkJCXJldHVybiBmYWxz ZTsKPiA+IMKgCQl9Cj4gCj4gWW91IGNhbiBkcm9wIHRoZSBicmFjZXMsIHRvby4KPiAKCk11bHRp LWxpbmUgaW5kZW50cyBnZXQgYnJhY2VzIGZvciByZWFkYWJpbGl0eS4KCnJlZ2FyZHMsCmRhbiBj YXJwZW50ZXIKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=