From: Florian Westphal <fw@strlen.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Florian Westphal <fw@strlen.de>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
"David S. Miller" <davem@davemloft.net>,
netfilter-devel@vger.kernel.org,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: netfilter: nft_ct: add zone id set support
Date: Thu, 23 Feb 2017 12:34:35 +0100 [thread overview]
Message-ID: <20170223113435.GF11144@breakpoint.cc> (raw)
In-Reply-To: <CAMuHMdUJ=2+9ko0KEU7rX3rb7vghNj3Xc-HSLSK=-kqQ+CZM6w@mail.gmail.com>
Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Wed, Feb 22, 2017 at 8:02 PM, Linux Kernel Mailing List
> <linux-kernel@vger.kernel.org> wrote:
> > Web: https://git.kernel.org/torvalds/c/edee4f1e92458299505ff007733f676b00c516a1
> > Commit: edee4f1e92458299505ff007733f676b00c516a1
> > Parent: 5c178d81b69f08ca3195427a6ea9a46d9af23127
> > Refname: refs/heads/master
> > Author: Florian Westphal <fw@strlen.de>
> > AuthorDate: Fri Feb 3 13:35:50 2017 +0100
> > Committer: Pablo Neira Ayuso <pablo@netfilter.org>
> > CommitDate: Wed Feb 8 14:16:23 2017 +0100
> >
> Unlike for the other cases of the switch statement, "len" is not initialized
> here...
>
> > + break;
> > priv->sreg = nft_parse_register(tb[NFTA_CT_SREG]);
> > err = nft_validate_register_load(priv->sreg, len);
>
> ... and used here, which may lead to spurious failures of
> nft_validate_register_load().
Yes, Dan reported this and a patch is queued at
http://patchwork.ozlabs.org/patch/727573/
Pablo, any reason why this is still waiting?
Do you want me to run more tests?
next prev parent reply other threads:[~2017-02-23 11:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170222190219.EC87B661B65@gitolite.kernel.org>
2017-02-23 9:54 ` netfilter: nft_ct: add zone id set support Geert Uytterhoeven
2017-02-23 11:34 ` Florian Westphal [this message]
2017-02-23 11:42 ` Pablo Neira Ayuso
2017-02-23 11:49 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170223113435.GF11144@breakpoint.cc \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.