From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH 3/3] drm/atomic: Try to preserve the crtc enabled state in drm_atomic_remove_fb. Date: Thu, 23 Feb 2017 10:24:30 -0500 Message-ID: <20170223152430.GC17822@art_vandelay> References: <1487685102-31991-1-git-send-email-maarten.lankhorst@linux.intel.com> <1487685102-31991-4-git-send-email-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qt0-x230.google.com (mail-qt0-x230.google.com [IPv6:2607:f8b0:400d:c0d::230]) by gabe.freedesktop.org (Postfix) with ESMTPS id DF9A16EA3A for ; Thu, 23 Feb 2017 15:24:33 +0000 (UTC) Received: by mail-qt0-x230.google.com with SMTP id n21so31059181qta.1 for ; Thu, 23 Feb 2017 07:24:33 -0800 (PST) Content-Disposition: inline In-Reply-To: <1487685102-31991-4-git-send-email-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBGZWIgMjEsIDIwMTcgYXQgMDI6NTE6NDJQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gVGhpcyBpbnRyb2R1Y2VzIGEgc2xpZ2h0IGJlaGF2aW9yYWwgY2hhbmdlIHRv IHJtZmIuIEluc3RlYWQgb2YKPiBkaXNhYmxpbmcgYSBjcnRjIHdoZW4gdGhlIHByaW1hcnkgcGxh bmUgaXMgZGlzYWJsZWQsIHdlIHRyeSB0bwo+IHByZXNlcnZlIGl0Lgo+IAo+IEFwYXJ0IGZyb20g b2xkIHZlcnNpb25zIG9mIHRoZSB2bXdnZnggeG9yZyBkcml2ZXIsIHRoZXJlIGlzCj4gbm90aGlu ZyBkZXBlbmRpbmcgb24gcm1mYiBkaXNhYmxpbmcgYSBjcnRjLiBTaW5jZSB2bXdnZnggaXMKPiBh IGxlZ2FjeSBkcml2ZXIgd2UgY2FuIHNhZmVseSBvbmx5IGRpc2FibGUgdGhlIHBsYW5lIHdpdGgg YXRvbWljLgo+IEluIHRoZSBjb252ZXJzaW9uIHRvIGF0b21pYyB0aGUgZHJpdmVyIHdpbGwgcmVq ZWN0IHRoZSBjb25maWcKPiB3aXRob3V0IHByaW1hcnkgcGxhbmUuCj4gCj4gSWYgdGhpcyBjb21t aXQgaXMgcmVqZWN0ZWQgYnkgdGhlIGRyaXZlciB0aGVuIHdlIHdpbGwgc3RpbGwgZmFsbAo+IGJh Y2sgdG8gdGhlIG9sZCBiZWhhdmlvciBhbmQgdHVybiBvZmYgdGhlIGNydGMuCj4gCj4gU2lnbmVk LW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVs LmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYyB8IDIyICsrKysrKysr KysrKysrKysrKysrLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDIwIGluc2VydGlvbnMoKyksIDIgZGVs ZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMg Yi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jCj4gaW5kZXggMjg1ZTFjMjNlOGM5Li4wZDVi MDA2NTIwOGUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYwo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMKPiBAQCAtMjA3MCw3ICsyMDcwLDcgQEAg aW50IGRybV9hdG9taWNfcmVtb3ZlX2ZiKHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiKQo+ICAJ c3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm47Cj4gIAlzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0 ZSAqY29ubl9zdGF0ZTsKPiAgCWludCBpLCByZXQgPSAwOwo+IC0JdW5zaWduZWQgcGxhbmVfbWFz azsKPiArCXVuc2lnbmVkIHBsYW5lX21hc2ssIGRpc2FibGVfY3J0Y3MgPSBmYWxzZTsKPiAgCj4g IAlzdGF0ZSA9IGRybV9hdG9taWNfc3RhdGVfYWxsb2MoZGV2KTsKPiAgCWlmICghc3RhdGUpCj4g QEAgLTIwOTcsNyArMjA5NywxMyBAQCBpbnQgZHJtX2F0b21pY19yZW1vdmVfZmIoc3RydWN0IGRy bV9mcmFtZWJ1ZmZlciAqZmIpCj4gIAkJCWdvdG8gdW5sb2NrOwo+ICAJCX0KPiAgCj4gLQkJaWYg KHBsYW5lX3N0YXRlLT5jcnRjLT5wcmltYXJ5ID09IHBsYW5lKSB7Cj4gKwkJLyoKPiArCQkgKiBT b21lIGRyaXZlcnMgZG8gbm90IHN1cHBvcnQga2VlcGluZyBjcnRjIGFjdGl2ZSB3aXRoIHRoZQo+ ICsJCSAqIHByaW1hcnkgcGxhbmUgZGlzYWJsZWQuIElmIHdlIGZhaWwgdG8gY29tbWl0IHdpdGgg LUVJTlZBTAo+ICsJCSAqIHRoZW4gd2Ugd2lsbCB0cnkgdG8gcGVyZm9ybSB0aGUgc2FtZSBjb21t aXQgYnV0IHdpdGggYWxsCj4gKwkJICogY3J0YydzIGRpc2FibGVkIGZvciBwcmltYXJ5IHBsYW5l cyBhcyB3ZWxsLgo+ICsJCSAqLwo+ICsJCWlmIChkaXNhYmxlX2NydGNzICYmIHBsYW5lX3N0YXRl LT5jcnRjLT5wcmltYXJ5ID09IHBsYW5lKSB7Cj4gIAkJCXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAq Y3J0Y19zdGF0ZTsKPiAgCj4gIAkJCWNydGNfc3RhdGUgPSBkcm1fYXRvbWljX2dldF9leGlzdGlu Z19jcnRjX3N0YXRlKHN0YXRlLCBwbGFuZV9zdGF0ZS0+Y3J0Yyk7Cj4gQEAgLTIxMjIsNiArMjEy OCw3IEBAIGludCBkcm1fYXRvbWljX3JlbW92ZV9mYihzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpm YikKPiAgCQlwbGFuZS0+b2xkX2ZiID0gcGxhbmUtPmZiOwo+ICAJfQo+ICAKPiArCS8qIFRoaXMg bGlzdCBpcyBvbmx5IG5vdCBlbXB0eSB3aGVuIGRpc2FibGVfY3J0Y3MgaXMgc2V0LiAqLwo+ICAJ Zm9yX2VhY2hfY29ubmVjdG9yX2luX3N0YXRlKHN0YXRlLCBjb25uLCBjb25uX3N0YXRlLCBpKSB7 Cj4gIAkJcmV0ID0gZHJtX2F0b21pY19zZXRfY3J0Y19mb3JfY29ubmVjdG9yKGNvbm5fc3RhdGUs IE5VTEwpOwo+ICAKPiBAQCAtMjE0Myw2ICsyMTUwLDE3IEBAIGludCBkcm1fYXRvbWljX3JlbW92 ZV9mYihzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYikKPiAgCj4gIAlkcm1fYXRvbWljX3N0YXRl X3B1dChzdGF0ZSk7Cj4gIAo+ICsJaWYgKHJldCA9PSAtRUlOVkFMICYmICFkaXNhYmxlX2NydGNz KSB7Cj4gKwkJZGlzYWJsZV9jcnRjcyA9IHRydWU7Cj4gKwo+ICsJCXN0YXRlID0gZHJtX2F0b21p Y19zdGF0ZV9hbGxvYyhkZXYpOwo+ICsJCWlmIChzdGF0ZSkgewo+ICsJCQlzdGF0ZS0+YWNxdWly ZV9jdHggPSAmY3R4Owo+ICsJCQlnb3RvIHJldHJ5OwoKUmUtdXNpbmcgdGhlIHJldHJ5IGxhYmVs IGlzIGEgbGl0dGxlIGZpc2h5IGhlcmUuIFlvdSBuZWVkIHRvIHJlLWFsbG9jYXRlIHN0YXRlLApi dXQgd2UgZG9uJ3QgZHJvcCB0aGUgbG9ja3MsIHdoaWNoIG1ha2VzIHRoaW5ncyBhIGxpdHRsZSB1 bmJhbGFuY2VkIChJIHJlYWxpemUKbW9kZXNldF9sb2NrIHdpbGwgcy9FQUxSRUFEWS8wLykuCgpQ ZXJoYXBzIHNvbWV0aGluZyBsaWtlIHRoaXMgYWJvdmUgd291bGQgYmUgbW9yZSBjbGVhcjoKCisg ICAgICAgZHJtX21vZGVzZXRfYWNxdWlyZV9pbml0KCZjdHgsIDApOworcmV0cnk6CisgICAgICAg cGxhbmVfbWFzayA9IDA7CisgICAgICAgcmV0ID0gZHJtX21vZGVzZXRfbG9ja19hbGxfY3R4KGRl diwgJmN0eCk7CisgICAgICAgaWYgKHJldCkKKyAgICAgICAgICAgICAgIGdvdG8gdW5sb2NrOwor CityZXRyeV9kaXNhYmxlOgorICAgICAgIHN0YXRlID0gZHJtX2F0b21pY19zdGF0ZV9hbGxvYyhk ZXYpOworICAgICAgIGlmICghc3RhdGUpCisgICAgICAgICAgICAgICByZXR1cm4gLUVOT01FTTsK KyAgICAgICBzdGF0ZS0+YWNxdWlyZV9jdHggPSAmY3R4OworCgpUaGVuIHlvdSBjYW4gZG86CgoK KwlpZiAocmV0ID09IC1FSU5WQUwgJiYgIWRpc2FibGVfY3J0Y3MpIHsKKwkJZGlzYWJsZV9jcnRj cyA9IHRydWU7CisJCWdvdG8gcmV0cnlfZGlzYWJsZTsKKyAgICAgICB9CgooeW91IHdvdWxkIGFs c28gbmVlZCB0byBlbnN1cmUgeW91IG1vdmVkIHRoZSBzdGF0ZV9wdXQgYWJvdmUgdGhlIEVERUFE TEsKaGFuZGxpbmcpLgoKVGhvdWdodHM/CgpTZWFuCgo+ICsJCX0KPiArCQlyZXQgPSAtRU5PTUVN Owo+ICsJfQo+ICsKPiAgCWRybV9tb2Rlc2V0X2Ryb3BfbG9ja3MoJmN0eCk7Cj4gIAlkcm1fbW9k ZXNldF9hY3F1aXJlX2ZpbmkoJmN0eCk7Cj4gIAo+IC0tIAo+IDIuNy40Cj4gCj4gX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGlu ZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCgotLSAKU2VhbiBQYXVs LCBTb2Z0d2FyZSBFbmdpbmVlciwgR29vZ2xlIC8gQ2hyb21pdW0gT1MKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApk cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==