From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH] drm/rockchip: add extcon dependency for DP Date: Thu, 23 Feb 2017 11:48:42 -0500 Message-ID: <20170223164841.GC24066@art_vandelay> References: <20170214213215.2888509-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170214213215.2888509-1-arnd@arndb.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Arnd Bergmann Cc: linux-rockchip@lists.infradead.org, Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Tobias Jakobi , Yakir Yang , Chris Zhong , Guenter Roeck , linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org T24gVHVlLCBGZWIgMTQsIDIwMTcgYXQgMTA6MzE6NTFQTSArMDEwMCwgQXJuZCBCZXJnbWFubiB3 cm90ZToKPiBUaGUgbmV3bHkgYWRkZWQgRFAgZHJpdmVyIGxpbmtzIGFnYWluc3QgdGhlIGV4dGNv biBjb3JlLCB3aGljaCBmYWlscyB3aGVuCj4gZXh0Y29uIGlzIGEgbW9kdWxlIGFuZCB0aGlzIGRy aXZlciBpcyBub3Q6Cj4gCj4gZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL2Nkbi1kcC1jb3JlLm86 IEluIGZ1bmN0aW9uIGBjZG5fZHBfZ2V0X3BvcnRfbGFuZXMnOgo+IGNkbi1kcC1jb3JlLmM6KC50 ZXh0LmNkbl9kcF9nZXRfcG9ydF9sYW5lcysweDI0KTogdW5kZWZpbmVkIHJlZmVyZW5jZSB0byBg ZXh0Y29uX2dldF9zdGF0ZScKPiBjZG4tZHAtY29yZS5jOigudGV4dC5jZG5fZHBfZ2V0X3BvcnRf bGFuZXMrMHg0NCk6IHVuZGVmaW5lZCByZWZlcmVuY2UgdG8gYGV4dGNvbl9nZXRfcHJvcGVydHkn Cj4gCj4gTGV0J3MgbWFrZSBLY29uZmlnIGVuZm9yY2UgY29ycmVjdCBiZWhhdmlvciB3aXRoIGEg ZGVwZW5kZW5jeS4KPiAKPiBGaXhlczogMWEwZjdlZDNhYmUyICgiZHJtL3JvY2tjaGlwOiBjZG4t ZHA6IGFkZCBjZG4gRFAgc3VwcG9ydCBmb3IgcmszMzk5IikKPiBTaWduZWQtb2ZmLWJ5OiBBcm5k IEJlcmdtYW5uIDxhcm5kQGFybmRiLmRlPgoKQXBwbGllZCB0byBkcm0tbWlzYy1uZXh0LWZpeGVz CgpUaGFua3MsCgpTZWFuCgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvS2NvbmZp ZyB8IDEgKwo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKykKPiAKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL0tjb25maWcgYi9kcml2ZXJzL2dwdS9kcm0vcm9j a2NoaXAvS2NvbmZpZwo+IGluZGV4IGFkMzFiM2ViNDA4Zi4uMGU0ZWI4NDVjYmIwIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9LY29uZmlnCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL3JvY2tjaGlwL0tjb25maWcKPiBAQCAtMjQsNiArMjQsNyBAQCBjb25maWcgUk9DS0NI SVBfQU5BTE9HSVhfRFAKPiAgY29uZmlnIFJPQ0tDSElQX0NETl9EUAo+ICAgICAgICAgIHRyaXN0 YXRlICJSb2NrY2hpcCBjZG4gRFAiCj4gICAgICAgICAgZGVwZW5kcyBvbiBEUk1fUk9DS0NISVAK PiArCWRlcGVuZHMgb24gRVhUQ09OCj4gIAlzZWxlY3QgU05EX1NPQ19IRE1JX0NPREVDIGlmIFNO RF9TT0MKPiAgICAgICAgICBoZWxwCj4gIAkgIFRoaXMgc2VsZWN0cyBzdXBwb3J0IGZvciBSb2Nr Y2hpcCBTb0Mgc3BlY2lmaWMgZXh0ZW5zaW9ucwo+IC0tIAo+IDIuOS4wCj4gCj4gX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGlu ZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCgotLSAKU2VhbiBQYXVs LCBTb2Z0d2FyZSBFbmdpbmVlciwgR29vZ2xlIC8gQ2hyb21pdW0gT1MKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApk cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: seanpaul@chromium.org (Sean Paul) Date: Thu, 23 Feb 2017 11:48:42 -0500 Subject: [PATCH] drm/rockchip: add extcon dependency for DP In-Reply-To: <20170214213215.2888509-1-arnd@arndb.de> References: <20170214213215.2888509-1-arnd@arndb.de> Message-ID: <20170223164841.GC24066@art_vandelay> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Feb 14, 2017 at 10:31:51PM +0100, Arnd Bergmann wrote: > The newly added DP driver links against the extcon core, which fails when > extcon is a module and this driver is not: > > drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_get_port_lanes': > cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x24): undefined reference to `extcon_get_state' > cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x44): undefined reference to `extcon_get_property' > > Let's make Kconfig enforce correct behavior with a dependency. > > Fixes: 1a0f7ed3abe2 ("drm/rockchip: cdn-dp: add cdn DP support for rk3399") > Signed-off-by: Arnd Bergmann Applied to drm-misc-next-fixes Thanks, Sean > --- > drivers/gpu/drm/rockchip/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig > index ad31b3eb408f..0e4eb845cbb0 100644 > --- a/drivers/gpu/drm/rockchip/Kconfig > +++ b/drivers/gpu/drm/rockchip/Kconfig > @@ -24,6 +24,7 @@ config ROCKCHIP_ANALOGIX_DP > config ROCKCHIP_CDN_DP > tristate "Rockchip cdn DP" > depends on DRM_ROCKCHIP > + depends on EXTCON > select SND_SOC_HDMI_CODEC if SND_SOC > help > This selects support for Rockchip SoC specific extensions > -- > 2.9.0 > > _______________________________________________ > dri-devel mailing list > dri-devel at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Sean Paul, Software Engineer, Google / Chromium OS From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751486AbdBWQ6P (ORCPT ); Thu, 23 Feb 2017 11:58:15 -0500 Received: from mail-qt0-f179.google.com ([209.85.216.179]:34571 "EHLO mail-qt0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751334AbdBWQ6L (ORCPT ); Thu, 23 Feb 2017 11:58:11 -0500 Date: Thu, 23 Feb 2017 11:48:42 -0500 From: Sean Paul To: Arnd Bergmann Cc: Mark Yao , David Airlie , Tobias Jakobi , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Chris Zhong , Yakir Yang , Guenter Roeck , linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] drm/rockchip: add extcon dependency for DP Message-ID: <20170223164841.GC24066@art_vandelay> References: <20170214213215.2888509-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170214213215.2888509-1-arnd@arndb.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 14, 2017 at 10:31:51PM +0100, Arnd Bergmann wrote: > The newly added DP driver links against the extcon core, which fails when > extcon is a module and this driver is not: > > drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_get_port_lanes': > cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x24): undefined reference to `extcon_get_state' > cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x44): undefined reference to `extcon_get_property' > > Let's make Kconfig enforce correct behavior with a dependency. > > Fixes: 1a0f7ed3abe2 ("drm/rockchip: cdn-dp: add cdn DP support for rk3399") > Signed-off-by: Arnd Bergmann Applied to drm-misc-next-fixes Thanks, Sean > --- > drivers/gpu/drm/rockchip/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig > index ad31b3eb408f..0e4eb845cbb0 100644 > --- a/drivers/gpu/drm/rockchip/Kconfig > +++ b/drivers/gpu/drm/rockchip/Kconfig > @@ -24,6 +24,7 @@ config ROCKCHIP_ANALOGIX_DP > config ROCKCHIP_CDN_DP > tristate "Rockchip cdn DP" > depends on DRM_ROCKCHIP > + depends on EXTCON > select SND_SOC_HDMI_CODEC if SND_SOC > help > This selects support for Rockchip SoC specific extensions > -- > 2.9.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Sean Paul, Software Engineer, Google / Chromium OS