From: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 03/25] luarocks-package: use $(HOST_PKG_VERSION) instead of $(PKG_VERSION)
Date: Thu, 23 Feb 2017 18:00:25 +0100 [thread overview]
Message-ID: <20170223170047.24417-4-arnout@mind.be> (raw)
In-Reply-To: <20170223170047.24417-1-arnout@mind.be>
The inner-luarocks-package macro was using $(3)_VERSION as the package
version, i.e. the version of the target package, even when it's the
host package. We should instead use $(2)_VERSION, i.e. the host package
version, like is done in inner-generic-package.
Since luarocks-package doesn't even support a host version, it doens't
make a whole lot of difference, but let's keep things consistent.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/pkg-luarocks.mk | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/pkg-luarocks.mk b/package/pkg-luarocks.mk
index da5c912c81..aa83e74a0e 100644
--- a/package/pkg-luarocks.mk
+++ b/package/pkg-luarocks.mk
@@ -34,9 +34,9 @@
define inner-luarocks-package
$(2)_BUILD_OPTS ?=
-$(2)_SUBDIR ?= $(1)-$$(shell echo "$$($(3)_VERSION)" | sed -e "s/-[0-9]$$$$//")
-$(2)_ROCKSPEC ?= $(1)-$$($(3)_VERSION).rockspec
-$(2)_SOURCE ?= $(1)-$$($(3)_VERSION).src.rock
+$(2)_SUBDIR ?= $(1)-$$(shell echo "$$($(2)_VERSION)" | sed -e "s/-[0-9]$$$$//")
+$(2)_ROCKSPEC ?= $(1)-$$($(2)_VERSION).rockspec
+$(2)_SOURCE ?= $(1)-$$($(2)_VERSION).src.rock
$(2)_SITE ?= $$(call qstrip,$$(BR2_LUAROCKS_MIRROR))
# Since we do not support host-luarocks-package, we know this is
--
2.11.0
next prev parent reply other threads:[~2017-02-23 17:00 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-23 17:00 [Buildroot] [PATCH for-next 0/25] Lua(Rocks) improvements Arnout Vandecappelle
2017-02-23 17:00 ` [Buildroot] [PATCH 01/25] lutok: move to Lua libraries menu Arnout Vandecappelle
2017-03-02 21:29 ` Thomas Petazzoni
2017-02-23 17:00 ` [Buildroot] [PATCH 02/25] cosmo: remove broken package Arnout Vandecappelle
2017-03-02 21:31 ` Thomas Petazzoni
2017-02-23 17:00 ` Arnout Vandecappelle [this message]
2017-03-02 21:43 ` [Buildroot] [PATCH 03/25] luarocks-package: use $(HOST_PKG_VERSION) instead of $(PKG_VERSION) Thomas Petazzoni
2017-02-23 17:00 ` [Buildroot] [PATCH 04/25] manual: luarocks: improve tutorial example Arnout Vandecappelle
2017-03-02 21:43 ` Thomas Petazzoni
2017-02-23 17:00 ` [Buildroot] [PATCH 05/25] lpty: remove LPTY_VERSION_UPSTREAM Arnout Vandecappelle
2017-03-02 21:45 ` Thomas Petazzoni
2017-02-23 17:00 ` [Buildroot] [PATCH 06/25] lua-periphery: remove LUA_PERIPHERY_VERSION_UPSTREAM Arnout Vandecappelle
2017-03-02 21:45 ` Thomas Petazzoni
2017-02-23 17:00 ` [Buildroot] [PATCH 07/25] luasec: remove LUASEC_VERSION_UPSTREAM Arnout Vandecappelle
2017-03-02 21:45 ` Thomas Petazzoni
2017-02-23 17:00 ` [Buildroot] [PATCH 08/25] ljlinenoise: remove default definition of PKG_SUBDIR Arnout Vandecappelle
2017-03-02 21:48 ` Thomas Petazzoni
2017-02-23 17:00 ` [Buildroot] [PATCH 09/25] lua-csnappy: " Arnout Vandecappelle
2017-02-23 17:00 ` [Buildroot] [PATCH 10/25] lua-iconv: " Arnout Vandecappelle
2017-02-23 17:00 ` [Buildroot] [PATCH 11/25] luacrypto: " Arnout Vandecappelle
2017-02-23 17:00 ` [Buildroot] [PATCH 12/25] lunit: " Arnout Vandecappelle
2017-02-23 17:00 ` [Buildroot] [PATCH 13/25] package/Config.in: explain that lua package names should start with lua Arnout Vandecappelle
2017-03-02 21:50 ` Thomas Petazzoni
2017-03-02 22:19 ` Arnout Vandecappelle
2017-03-02 22:22 ` Thomas Petazzoni
2017-03-02 22:26 ` Arnout Vandecappelle
2017-03-02 22:38 ` Thomas Petazzoni
2017-02-23 17:00 ` [Buildroot] [PATCH 14/25] lua-bit32: new package Arnout Vandecappelle
2017-03-02 21:54 ` Thomas Petazzoni
2017-03-02 22:24 ` Arnout Vandecappelle
2017-03-17 16:14 ` Thomas Petazzoni
2017-03-17 22:17 ` Arnout Vandecappelle
2017-03-18 10:42 ` Thomas Petazzoni
2017-03-18 13:17 ` Arnout Vandecappelle
2017-03-18 13:49 ` [Buildroot] Orphan package notification Thomas Petazzoni
2017-03-18 14:03 ` Arnout Vandecappelle
2017-02-23 17:00 ` [Buildroot] [PATCH 15/25] luaposix: fix runtime by selecting "bit32" instead of "bitop" Arnout Vandecappelle
2017-03-02 21:58 ` Thomas Petazzoni
2017-03-02 22:25 ` Arnout Vandecappelle
2017-03-02 22:28 ` Thomas Petazzoni
2017-03-02 23:02 ` Arnout Vandecappelle
2017-02-23 17:00 ` [Buildroot] [PATCH 16/25] luarocks-package: rework extraction Arnout Vandecappelle
2017-03-02 22:24 ` Thomas Petazzoni
2017-02-23 17:00 ` [Buildroot] [PATCH 17/25] lua-bit32: remove custom extract commands Arnout Vandecappelle
2017-03-02 22:24 ` Thomas Petazzoni
2017-02-23 17:00 ` [Buildroot] [PATCH 18/25] luarocks-package: introduce PKG_NAME_UPSTREAM Arnout Vandecappelle
2017-03-02 22:26 ` Thomas Petazzoni
2017-02-23 17:00 ` [Buildroot] [PATCH 19/25] lua-bit32: use PKG_NAME_UPSTREAM Arnout Vandecappelle
2017-03-02 22:26 ` Thomas Petazzoni
2017-02-23 17:00 ` [Buildroot] [PATCH 20/25] luarocks-package: lowercase the upstream name for LuaRocks Arnout Vandecappelle
2017-02-23 17:00 ` [Buildroot] [PATCH 21/25] lua-coat: use PKG_NAME_UPSTREAM Arnout Vandecappelle
2017-02-23 17:00 ` [Buildroot] [PATCH 22/25] lua-cjson: use LUA_CJSON_SUBDIR Arnout Vandecappelle
2017-02-23 17:00 ` [Buildroot] [PATCH 23/25] lua-testmore: use PKG_NAME_UPSTREAM Arnout Vandecappelle
2017-02-23 17:00 ` [Buildroot] [PATCH 24/25] luabitop: " Arnout Vandecappelle
2017-02-23 17:00 ` [Buildroot] [PATCH 25/25] lua: remove documentation from target Arnout Vandecappelle
2017-02-24 6:59 ` [Buildroot] [PATCH for-next 0/25] Lua(Rocks) improvements François Perrad
2017-02-24 9:09 ` Arnout Vandecappelle
2017-02-24 10:57 ` François Perrad
2017-03-05 21:05 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170223170047.24417-4-arnout@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.