From: Stephen Hemminger <stephen@networkplumber.org>
To: Wenzhuo Lu <wenzhuo.lu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH 0/8] QoS features on i40e
Date: Thu, 23 Feb 2017 22:55:07 -0800 [thread overview]
Message-ID: <20170223225507.69ee0e47@xeon-e3> (raw)
In-Reply-To: <1487906675-54260-1-git-send-email-wenzhuo.lu@intel.com>
On Fri, 24 Feb 2017 11:24:27 +0800
Wenzhuo Lu <wenzhuo.lu@intel.com> wrote:
> This patch set enables several QoS features on i40e.
> 1, VF max bandwidth setting.
> 2, TC min bandwidth setting on a VF.
> 3, TC max bandwidth setting on a VF.
> 4, TC TX scheduling mode setting.
> As there're no new interface between PF and VF defined, all the settings
> for VF are done on PF. PF acts as a controller for the VFs.
>
> Wenzhuo Lu (8):
> net/i40e: set VF max bandwidth from PF
> net/i40e: allocate VF TC bandwidth from PF
> net/i40e: set VF TC max bandwidth from PF
> net/i40e: set TC strict priority mode
> app/testpmd: set VF TX max bandwidth
> app/testpmd: set VF TC TX min bandwidth
> app/testpmd: set VF TC TX max bandwidth
> app/testpmd: set TC strict link priority mode
>
> app/test-pmd/cmdline.c | 343 +++++++++++++++++++++
> doc/guides/nics/i40e.rst | 21 ++
> doc/guides/rel_notes/release_17_05.rst | 20 ++
> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 28 ++
> drivers/net/i40e/i40e_ethdev.c | 449 ++++++++++++++++++++++++++++
> drivers/net/i40e/i40e_ethdev.h | 1 +
> drivers/net/i40e/rte_pmd_i40e.h | 86 ++++++
> drivers/net/i40e/rte_pmd_i40e_version.map | 10 +
> 8 files changed, 958 insertions(+)
>
It is good to allow setting QoS on device, but it looks like this is
a device specific API, not a generic PMD function. I don't think any
feature in DPDK should be hardcoded to one device type.
next prev parent reply other threads:[~2017-02-24 6:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 3:24 [PATCH 0/8] QoS features on i40e Wenzhuo Lu
2017-02-24 3:24 ` [PATCH 1/8] net/i40e: set VF max bandwidth from PF Wenzhuo Lu
2017-03-24 5:01 ` Wu, Jingjing
2017-02-24 3:24 ` [PATCH 2/8] net/i40e: allocate VF TC " Wenzhuo Lu
2017-03-24 5:10 ` Wu, Jingjing
2017-02-24 3:24 ` [PATCH 3/8] net/i40e: set VF TC max " Wenzhuo Lu
2017-03-24 5:15 ` Wu, Jingjing
2017-02-24 3:24 ` [PATCH 4/8] net/i40e: set TC strict priority mode Wenzhuo Lu
2017-03-24 5:19 ` Wu, Jingjing
2017-03-24 7:07 ` Lu, Wenzhuo
2017-03-24 9:34 ` Wu, Jingjing
2017-02-24 3:24 ` [PATCH 5/8] app/testpmd: set VF TX max bandwidth Wenzhuo Lu
2017-03-24 5:21 ` Wu, Jingjing
2017-02-24 3:24 ` [PATCH 6/8] app/testpmd: set VF TC TX min bandwidth Wenzhuo Lu
2017-03-24 5:22 ` Wu, Jingjing
2017-02-24 3:24 ` [PATCH 7/8] app/testpmd: set VF TC TX max bandwidth Wenzhuo Lu
2017-03-24 5:22 ` Wu, Jingjing
2017-02-24 3:24 ` [PATCH 8/8] app/testpmd: set TC strict link priority mode Wenzhuo Lu
2017-03-24 5:23 ` Wu, Jingjing
2017-02-24 6:55 ` Stephen Hemminger [this message]
2017-02-24 7:23 ` [PATCH 0/8] QoS features on i40e Lu, Wenzhuo
2017-02-24 9:14 ` [PATCH 0/8] QoS features on i40e - Linux kernel divergence Vincent JARDIN
2017-02-28 5:04 ` Lu, Wenzhuo
2017-03-27 15:13 ` [PATCH 0/8] QoS features on i40e Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170223225507.69ee0e47@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.