From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Michael Hennerich <michael.hennerich@analog.com>
Subject: Re: [PATCH -next] input/touchscreen: add header file to fix ad7879.c build errors
Date: Sat, 25 Feb 2017 10:51:11 -0800 [thread overview]
Message-ID: <20170225185111.GA31929@dtor-ws> (raw)
In-Reply-To: <25206b81-0f8c-8d40-32ad-e6ad5c03098d@infradead.org>
On Fri, Feb 24, 2017 at 10:30:22AM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Add header file to fix these build errors:
>
> ../drivers/input/touchscreen/ad7879.c: In function 'ad7879_parse_dt':
> ../drivers/input/touchscreen/ad7879.c:505:2: error: implicit declaration of function 'device_property_read_u32' [-Werror=implicit-function-declaration]
> err = device_property_read_u32(dev, "adi,resistance-plate-x", &tmp);
> ^
> ../drivers/input/touchscreen/ad7879.c:512:2: error: implicit declaration of function 'device_property_read_u8' [-Werror=implicit-function-declaration]
> device_property_read_u8(dev, "adi,first-conversion-delay",
> ^
> ../drivers/input/touchscreen/ad7879.c:521:2: error: implicit declaration of function 'device_property_read_bool' [-Werror=implicit-function-declaration]
> ts->swap_xy = device_property_read_bool(dev, "touchscreen-swapped-x-y");
> ^
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Applied, thank you.
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: linux-input@vger.kernel.org
> Cc: Michael Hennerich <michael.hennerich@analog.com>
> ---
> drivers/input/touchscreen/ad7879.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20170224.orig/drivers/input/touchscreen/ad7879.c
> +++ linux-next-20170224/drivers/input/touchscreen/ad7879.c
> @@ -26,6 +26,7 @@
> #include <linux/input.h>
> #include <linux/interrupt.h>
> #include <linux/irq.h>
> +#include <linux/property.h>
> #include <linux/regmap.h>
> #include <linux/slab.h>
> #include <linux/gpio.h>
--
Dmitry
prev parent reply other threads:[~2017-02-25 18:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 18:30 [PATCH -next] input/touchscreen: add header file to fix ad7879.c build errors Randy Dunlap
2017-02-25 18:51 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170225185111.GA31929@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.