From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, Darren Hart <dvhart@infradead.org>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/4] gpio: make gpiod_count() API consistent
Date: Mon, 27 Feb 2017 09:27:35 +0100 [thread overview]
Message-ID: <20170227082735.GA2373@mail.corp.redhat.com> (raw)
In-Reply-To: <20170220161549.39490-1-andriy.shevchenko@linux.intel.com>
On Feb 20 2017 or thereabouts, Andy Shevchenko wrote:
> There are three possibilities in gpiod_count(): ACPI, OF, and
> platform data.
>
> Some of them return 0, which requires to be handled separately, though
> developers rather lazy and just shadow an actual error code.
>
> Let's make this API consistent by not allowing 0 in returned value.
>
> There are luckily only 3 users right now, one of them handles this
> properly, the rest is converted in this series.
>
> Series is supposed to go through GPIO tree.
>
> Andy Shevchenko (4):
> gpio: acpi: Don't return 0 on acpi_gpio_count()
> gpio: of: Don't return 0 on dt_gpio_count()
> platform/x86: surface3_button: Propagate error from gpiod_count()
> Input: soc_button_array - Propagate error from gpiod_count()
Not sure if this still matters, but still:
Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cheers,
Benjamin
>
> drivers/gpio/gpiolib-acpi.c | 4 ++--
> drivers/gpio/gpiolib.c | 4 ++--
> drivers/input/misc/soc_button_array.c | 5 +++--
> drivers/platform/x86/surface3_button.c | 5 +++--
> 4 files changed, 10 insertions(+), 8 deletions(-)
>
> --
> 2.11.0
>
next prev parent reply other threads:[~2017-02-27 8:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 16:15 [PATCH v1 0/4] gpio: make gpiod_count() API consistent Andy Shevchenko
2017-02-20 16:15 ` [PATCH v1 1/4] gpio: acpi: Don't return 0 on acpi_gpio_count() Andy Shevchenko
2017-03-14 9:43 ` Linus Walleij
2017-03-14 11:51 ` Mika Westerberg
2017-03-16 14:42 ` Linus Walleij
2017-02-20 16:15 ` [PATCH v1 2/4] gpio: of: Don't return 0 on dt_gpio_count() Andy Shevchenko
2017-03-16 14:43 ` Linus Walleij
2017-02-20 16:15 ` [PATCH v1 3/4] platform/x86: surface3_button: Propagate error from gpiod_count() Andy Shevchenko
2017-03-14 9:46 ` Linus Walleij
2017-03-14 12:28 ` Andy Shevchenko
2017-03-16 14:45 ` Linus Walleij
2017-02-20 16:15 ` [PATCH v1 4/4] Input: soc_button_array - " Andy Shevchenko
2017-02-23 8:40 ` Dmitry Torokhov
2017-03-16 14:46 ` Linus Walleij
2017-02-27 8:27 ` Benjamin Tissoires [this message]
2017-02-28 9:48 ` [PATCH v1 0/4] gpio: make gpiod_count() API consistent Andy Shevchenko
2017-03-14 9:49 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170227082735.GA2373@mail.corp.redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dvhart@infradead.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.