From: "Daniel P. Berrange" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Li Qiang <liqiang6-s@360.cn>,
"Daniel P . Berrange" <berrange@redhat.com>
Subject: [Qemu-devel] [PULL v1 1/2] crypto: fix leak in ivgen essiv init
Date: Mon, 27 Feb 2017 13:39:26 +0000 [thread overview]
Message-ID: <20170227133927.759-2-berrange@redhat.com> (raw)
In-Reply-To: <20170227133927.759-1-berrange@redhat.com>
From: Li Qiang <liqiang6-s@360.cn>
On error path, the 'salt' doesn't been freed thus leading
a memory leak. This patch avoid this.
Signed-off-by: Li Qiang <liqiang6-s@360.cn>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
crypto/ivgen-essiv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/crypto/ivgen-essiv.c b/crypto/ivgen-essiv.c
index 634de63..cba20bd 100644
--- a/crypto/ivgen-essiv.c
+++ b/crypto/ivgen-essiv.c
@@ -48,6 +48,7 @@ static int qcrypto_ivgen_essiv_init(QCryptoIVGen *ivgen,
&salt, &nhash,
errp) < 0) {
g_free(essiv);
+ g_free(salt);
return -1;
}
--
2.9.3
next prev parent reply other threads:[~2017-02-27 13:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-27 13:39 [Qemu-devel] [PULL v1 0/2] Merge qcrypto 2017/02/27 Daniel P. Berrange
2017-02-27 13:39 ` Daniel P. Berrange [this message]
2017-02-27 13:39 ` [Qemu-devel] [PULL v1 2/2] crypto: assert cipher algorithm is always valid Daniel P. Berrange
2017-02-27 16:30 ` [Qemu-devel] [PULL v1 0/2] Merge qcrypto 2017/02/27 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170227133927.759-2-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=liqiang6-s@360.cn \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.