From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] splash: Prevent splash_load_fs from writing to 0x0
Date: Mon, 27 Feb 2017 16:14:05 +0100 [thread overview]
Message-ID: <20170227161405.0b6063bb@crub> (raw)
In-Reply-To: <1487954770-7746-1-git-send-email-jonathan.golder@kurz-elektronik.de>
On Fri, 24 Feb 2017 17:46:10 +0100
Jonathan Golder jonathan.golder at kurz-elektronik.de wrote:
> Passing NULL to fs_read() for actread value results in hanging U-Boot
> at least on our ARM plattform (TI AM335x). Since fs_read() and
> following functions do not catch nullpointers, writing to 0x0 occurs.
>
> Passing a local dummy var instead of NULL solves this issue.
>
> Signed-off-by: Jonathan Golder <jonathan.golder@kurz-elektronik.de>
> Cc: Anatolij Gustschin <agust@denx.de>
> ---
> common/splash_source.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
applied to u-boot-video/master, thanks!
--
Anatolij
prev parent reply other threads:[~2017-02-27 15:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 16:46 [U-Boot] [PATCH] splash: Prevent splash_load_fs from writing to 0x0 Jonathan Golder
2017-02-26 7:05 ` Igor Grinberg
[not found] ` <48FA4BE8-665C-4076-AB5E-683CF747839D@kurz-elektronik.de>
2017-02-27 11:13 ` Igor Grinberg
2017-02-27 15:14 ` Anatolij Gustschin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170227161405.0b6063bb@crub \
--to=agust@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.