Re: [Outreachy kernel] [PATCH v2] staging: lustre: Replace typedef with struct

[Greg KH <gregkh@linuxfoundation.org>]

On Tue, Feb 28, 2017 at 01:20:59PM +0530, Gargi Sharma wrote:
> On Tue, Feb 28, 2017 at 12:36 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> >
> >
> >
> > On Tue, 28 Feb 2017, Gargi Sharma wrote:
> >
> > > As per the Linux kernel coding style guidelines, using typedef for a
> > > structure type is not recommended. Hence, occurences of typedefs have
> > > been removed. To find the occurences of the structures grep was used
> > > and no uses were found.
> >
> > Actually, I'm not sure to understand.� No uses of the structures were
> > found at all?� If so, they should just be dropped.� Or are there uses, but
> > they already have the word "struct" in front of them?
> 
> The first structure "ext_acl_xattr_entry" is used as one of the fields in the�
> other structure "ext_acl_xattr_header". I could not find any uses of the
> structure
> "ext_acl_xattr_header" inside the staging directory. Should I drop these two
> structures then?

I think so, we shouldn't keep around structures that are not actually
used.

Unless the Lustre maintainers are hiding something somewhere else that
uses these?

thanks,

greg k-h