From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Daniel J Blueman <daniel@quora.org>
Cc: Florian Westphal <fw@strlen.de>, Netdev <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Eric W. Biederman" <ebiederm@xmission.com>,
David Ahern <dsa@cumulusnetworks.com>,
Jan Beulich <JBeulich@suse.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
netfilter-devel@vger.kernel.org
Subject: Re: [4.9.10] ip_route_me_harder() reading off-slab
Date: Tue, 28 Feb 2017 12:50:02 +0100 [thread overview]
Message-ID: <20170228115002.GA20068@salvia> (raw)
In-Reply-To: <CAMVG2ssH8F-BgUzCxZdcAYgYo_2HMK_0=drg-JS596TT7A=5wA@mail.gmail.com>
On Mon, Feb 27, 2017 at 10:41:48PM +0800, Daniel J Blueman wrote:
> On 17 February 2017 at 15:39, Florian Westphal <fw@strlen.de> wrote:
> > Daniel J Blueman <daniel@quora.org> wrote:
> >
> > [ CC nf-devel, pablo ]
> >
> >> When booting a VM in libvirt/KVM attached to a local bridge and KASAN
> >> enabled on 4.9.10, we see a stream of KASAN warnings about off-slab
> >> access [1].
> >>
> >> Let me know if you'd like more debug.
> >
> > Does this patch help?
> >
> > Subject: [PATCH nf] netfilter: use skb_to_full_sk in ip_route_me_harder
> >
> > inet_sk(skb->sk) is illegal in case skb is attached to request socket.
> >
> > Fixes: ca6fb0651883 ("tcp: attach SYNACK messages to request sockets instead of listener")
> > Reported by: Daniel J Blueman <daniel@quora.org>
> > Signed-off-by: Florian Westphal <fw@strlen.de>
[...]
> Apologies for the delays; this also addresses the issue just fine.
>
> Tested-by: Daniel J Blueman <daniel@quora.org>
Applied, thanks for testing.
next prev parent reply other threads:[~2017-02-28 12:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 5:34 [4.9.10] ip_route_me_harder() reading off-slab Daniel J Blueman
2017-02-17 6:23 ` Willy Tarreau
2017-02-17 7:39 ` Florian Westphal
2017-02-27 14:41 ` Daniel J Blueman
2017-02-28 11:50 ` Pablo Neira Ayuso [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-02-17 4:36 Daniel J Blueman
2017-02-17 5:36 ` Eric Dumazet
2017-02-18 6:56 ` Daniel J Blueman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170228115002.GA20068@salvia \
--to=pablo@netfilter.org \
--cc=JBeulich@suse.com \
--cc=daniel@quora.org \
--cc=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.