From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.rutland@arm.com (Mark Rutland) Date: Tue, 28 Feb 2017 12:32:45 +0000 Subject: [PATCH v3 11/25] ARM: dts: Add Actions Semi S500 and LeMaker Guitar In-Reply-To: <20170228063535.32069-12-afaerber@suse.de> References: <20170228063535.32069-1-afaerber@suse.de> <20170228063535.32069-12-afaerber@suse.de> Message-ID: <20170228123245.GF3691@leverpostej> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Tue, Feb 28, 2017 at 07:35:21AM +0100, Andreas F?rber wrote: > +/dts-v1/; > + > +#include "s500-guitar.dtsi" > + > +/ { > + compatible = "lemaker,guitar-bb-rev-b", "lemaker,guitar", "actions,s500"; > + model = "LeMaker Guitar Base Board rev. B"; > + > + aliases { > + serial3 = &uart3; > + }; > + > + chosen { > + stdout-path = "serial3:115200n8"; > + }; > +}; > + > +&uart3 { > + status = "okay"; > +}; > +#include "s500.dtsi" > + > +/ { > + compatible = "lemaker,guitar", "actions,s500"; > + > + /delete-node/ memory; Eww. Is this just bodging around skeleton.dtsi? > + > + memory at 0 { > + device_type = "memory"; > + reg = <0x0 0x40000000>; > + }; > +}; > +#include "skeleton.dtsi" Please don't include skeleton.dtsi. Please add the relevant nodes and properties explciitly to your dts{i,} files. > + > +#include > + > +/ { Please define your #address-cells and #size-cells here. If you want, add an empty /chosen node (not strictly necessary since your dts file has a non-empty one anyhow). Thanks, Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCH v3 11/25] ARM: dts: Add Actions Semi S500 and LeMaker Guitar Date: Tue, 28 Feb 2017 12:32:45 +0000 Message-ID: <20170228123245.GF3691@leverpostej> References: <20170228063535.32069-1-afaerber@suse.de> <20170228063535.32069-12-afaerber@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170228063535.32069-12-afaerber@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Andreas =?utf-8?Q?F=C3=A4rber?= Cc: support@lemaker.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Russell King , arm@kernel.org, mp-cs@actions-semi.com, 96boards@ucrobotics.com, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org SGksCgpPbiBUdWUsIEZlYiAyOCwgMjAxNyBhdCAwNzozNToyMUFNICswMTAwLCBBbmRyZWFzIEbD pHJiZXIgd3JvdGU6Cj4gKy9kdHMtdjEvOwo+ICsKPiArI2luY2x1ZGUgInM1MDAtZ3VpdGFyLmR0 c2kiCj4gKwo+ICsvIHsKPiArCWNvbXBhdGlibGUgPSAibGVtYWtlcixndWl0YXItYmItcmV2LWIi LCAibGVtYWtlcixndWl0YXIiLCAiYWN0aW9ucyxzNTAwIjsKPiArCW1vZGVsID0gIkxlTWFrZXIg R3VpdGFyIEJhc2UgQm9hcmQgcmV2LiBCIjsKPiArCj4gKwlhbGlhc2VzIHsKPiArCQlzZXJpYWwz ID0gJnVhcnQzOwo+ICsJfTsKPiArCj4gKwljaG9zZW4gewo+ICsJCXN0ZG91dC1wYXRoID0gInNl cmlhbDM6MTE1MjAwbjgiOwo+ICsJfTsKPiArfTsKPiArCj4gKyZ1YXJ0MyB7Cj4gKwlzdGF0dXMg PSAib2theSI7Cj4gK307Cgo+ICsjaW5jbHVkZSAiczUwMC5kdHNpIgo+ICsKPiArLyB7Cj4gKwlj b21wYXRpYmxlID0gImxlbWFrZXIsZ3VpdGFyIiwgImFjdGlvbnMsczUwMCI7Cj4gKwo+ICsJL2Rl bGV0ZS1ub2RlLyBtZW1vcnk7CgpFd3cuIElzIHRoaXMganVzdCBib2RnaW5nIGFyb3VuZCBza2Vs ZXRvbi5kdHNpPwoKPiArCj4gKwltZW1vcnlAMCB7Cj4gKwkJZGV2aWNlX3R5cGUgPSAibWVtb3J5 IjsKPiArCQlyZWcgPSA8MHgwIDB4NDAwMDAwMDA+Owo+ICsJfTsKPiArfTsKCj4gKyNpbmNsdWRl ICJza2VsZXRvbi5kdHNpIgoKUGxlYXNlIGRvbid0IGluY2x1ZGUgc2tlbGV0b24uZHRzaS4gUGxl YXNlIGFkZCB0aGUgcmVsZXZhbnQgbm9kZXMgYW5kCnByb3BlcnRpZXMgZXhwbGNpaXRseSB0byB5 b3VyIGR0c3tpLH0gZmlsZXMuCgo+ICsKPiArI2luY2x1ZGUgPGR0LWJpbmRpbmdzL2ludGVycnVw dC1jb250cm9sbGVyL2FybS1naWMuaD4KPiArCj4gKy8gewoKUGxlYXNlIGRlZmluZSB5b3VyICNh ZGRyZXNzLWNlbGxzIGFuZCAjc2l6ZS1jZWxscyBoZXJlLgoKSWYgeW91IHdhbnQsIGFkZCBhbiBl bXB0eSAvY2hvc2VuIG5vZGUgKG5vdCBzdHJpY3RseSBuZWNlc3Nhcnkgc2luY2UKeW91ciBkdHMg ZmlsZSBoYXMgYSBub24tZW1wdHkgb25lIGFueWhvdykuCgpUaGFua3MsCk1hcmsuCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVs IG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752507AbdB1MvG (ORCPT ); Tue, 28 Feb 2017 07:51:06 -0500 Received: from foss.arm.com ([217.140.101.70]:36872 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752303AbdB1MvD (ORCPT ); Tue, 28 Feb 2017 07:51:03 -0500 Date: Tue, 28 Feb 2017 12:32:45 +0000 From: Mark Rutland To: Andreas =?utf-8?Q?F=C3=A4rber?= Cc: arm@kernel.org, linux-arm-kernel@lists.infradead.org, mp-cs@actions-semi.com, 96boards@ucrobotics.com, support@lemaker.org, linux-kernel@vger.kernel.org, Rob Herring , Russell King , devicetree@vger.kernel.org Subject: Re: [PATCH v3 11/25] ARM: dts: Add Actions Semi S500 and LeMaker Guitar Message-ID: <20170228123245.GF3691@leverpostej> References: <20170228063535.32069-1-afaerber@suse.de> <20170228063535.32069-12-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170228063535.32069-12-afaerber@suse.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, Feb 28, 2017 at 07:35:21AM +0100, Andreas Färber wrote: > +/dts-v1/; > + > +#include "s500-guitar.dtsi" > + > +/ { > + compatible = "lemaker,guitar-bb-rev-b", "lemaker,guitar", "actions,s500"; > + model = "LeMaker Guitar Base Board rev. B"; > + > + aliases { > + serial3 = &uart3; > + }; > + > + chosen { > + stdout-path = "serial3:115200n8"; > + }; > +}; > + > +&uart3 { > + status = "okay"; > +}; > +#include "s500.dtsi" > + > +/ { > + compatible = "lemaker,guitar", "actions,s500"; > + > + /delete-node/ memory; Eww. Is this just bodging around skeleton.dtsi? > + > + memory@0 { > + device_type = "memory"; > + reg = <0x0 0x40000000>; > + }; > +}; > +#include "skeleton.dtsi" Please don't include skeleton.dtsi. Please add the relevant nodes and properties explciitly to your dts{i,} files. > + > +#include > + > +/ { Please define your #address-cells and #size-cells here. If you want, add an empty /chosen node (not strictly necessary since your dts file has a non-empty one anyhow). Thanks, Mark.