From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.rutland@arm.com (Mark Rutland) Date: Tue, 28 Feb 2017 12:39:08 +0000 Subject: [PATCH v3 03/25] dt-bindings: timer: Document Owl timer In-Reply-To: <20170228063535.32069-4-afaerber@suse.de> References: <20170228063535.32069-1-afaerber@suse.de> <20170228063535.32069-4-afaerber@suse.de> Message-ID: <20170228123908.GG3691@leverpostej> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Feb 28, 2017 at 07:35:13AM +0100, Andreas F?rber wrote: > The Actions Semi S500 SoC contains a timer block with two 2 Hz and two > 32-bit timers. The S900 SoC timer block has four 32-bit timers. > > Signed-off-by: Andreas F?rber > --- > v2 -> v3: > * Adopted interrupt-names > * Changed compatible for S500 > * Added S900 compatible and interrupt names > > v2: new > > .../devicetree/bindings/timer/actions,owl-timer.txt | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > create mode 100644 Documentation/devicetree/bindings/timer/actions,owl-timer.txt > > diff --git a/Documentation/devicetree/bindings/timer/actions,owl-timer.txt b/Documentation/devicetree/bindings/timer/actions,owl-timer.txt > new file mode 100644 > index 0000000..5b4834d > --- /dev/null > +++ b/Documentation/devicetree/bindings/timer/actions,owl-timer.txt > @@ -0,0 +1,20 @@ > +Actions Semi Owl Timer > + > +Required properties: > +- compatible : "actions,s500-timer" for S500 > + "actions,s900-timer" for S900 > +- reg : Offset and length of the register set for the device. > +- interrupts : Should contain the interrupts. > +- interrupt-names : Valid names are: "2Hz0", "2Hz1", > + "Timer0", "Timer1", "Timer2", "Timer3" Sticking to lower case for the names would be preferable. Otherwise, this looks fine. Mark,. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCH v3 03/25] dt-bindings: timer: Document Owl timer Date: Tue, 28 Feb 2017 12:39:08 +0000 Message-ID: <20170228123908.GG3691@leverpostej> References: <20170228063535.32069-1-afaerber@suse.de> <20170228063535.32069-4-afaerber@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170228063535.32069-4-afaerber@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Andreas =?utf-8?Q?F=C3=A4rber?= Cc: support@lemaker.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , arm@kernel.org, mp-cs@actions-semi.com, 96boards@ucrobotics.com, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org T24gVHVlLCBGZWIgMjgsIDIwMTcgYXQgMDc6MzU6MTNBTSArMDEwMCwgQW5kcmVhcyBGw6RyYmVy IHdyb3RlOgo+IFRoZSBBY3Rpb25zIFNlbWkgUzUwMCBTb0MgY29udGFpbnMgYSB0aW1lciBibG9j ayB3aXRoIHR3byAyIEh6IGFuZCB0d28KPiAzMi1iaXQgdGltZXJzLiBUaGUgUzkwMCBTb0MgdGlt ZXIgYmxvY2sgaGFzIGZvdXIgMzItYml0IHRpbWVycy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBBbmRy ZWFzIEbDpHJiZXIgPGFmYWVyYmVyQHN1c2UuZGU+Cj4gLS0tCj4gIHYyIC0+IHYzOgo+ICAqIEFk b3B0ZWQgaW50ZXJydXB0LW5hbWVzCj4gICogQ2hhbmdlZCBjb21wYXRpYmxlIGZvciBTNTAwCj4g ICogQWRkZWQgUzkwMCBjb21wYXRpYmxlIGFuZCBpbnRlcnJ1cHQgbmFtZXMKPiAgCj4gIHYyOiBu ZXcKPiAgCj4gIC4uLi9kZXZpY2V0cmVlL2JpbmRpbmdzL3RpbWVyL2FjdGlvbnMsb3dsLXRpbWVy LnR4dCAgfCAyMCArKysrKysrKysrKysrKysrKysrKwo+ICAxIGZpbGUgY2hhbmdlZCwgMjAgaW5z ZXJ0aW9ucygrKQo+ICBjcmVhdGUgbW9kZSAxMDA2NDQgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVl L2JpbmRpbmdzL3RpbWVyL2FjdGlvbnMsb3dsLXRpbWVyLnR4dAo+IAo+IGRpZmYgLS1naXQgYS9E b2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdGltZXIvYWN0aW9ucyxvd2wtdGltZXIu dHh0IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3RpbWVyL2FjdGlvbnMsb3ds LXRpbWVyLnR4dAo+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4gaW5kZXggMDAwMDAwMC4uNWI0ODM0 ZAo+IC0tLSAvZGV2L251bGwKPiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGlu Z3MvdGltZXIvYWN0aW9ucyxvd2wtdGltZXIudHh0Cj4gQEAgLTAsMCArMSwyMCBAQAo+ICtBY3Rp b25zIFNlbWkgT3dsIFRpbWVyCj4gKwo+ICtSZXF1aXJlZCBwcm9wZXJ0aWVzOgo+ICstIGNvbXBh dGlibGUgICAgICA6ICAiYWN0aW9ucyxzNTAwLXRpbWVyIiBmb3IgUzUwMAo+ICsgICAgICAgICAg ICAgICAgICAgICAiYWN0aW9ucyxzOTAwLXRpbWVyIiBmb3IgUzkwMAo+ICstIHJlZyAgICAgICAg ICAgICA6ICBPZmZzZXQgYW5kIGxlbmd0aCBvZiB0aGUgcmVnaXN0ZXIgc2V0IGZvciB0aGUgZGV2 aWNlLgo+ICstIGludGVycnVwdHMgICAgICA6ICBTaG91bGQgY29udGFpbiB0aGUgaW50ZXJydXB0 cy4KPiArLSBpbnRlcnJ1cHQtbmFtZXMgOiAgVmFsaWQgbmFtZXMgYXJlOiAiMkh6MCIsICIySHox IiwKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiVGltZXIwIiwgIlRp bWVyMSIsICJUaW1lcjIiLCAiVGltZXIzIgoKU3RpY2tpbmcgdG8gbG93ZXIgY2FzZSBmb3IgdGhl IG5hbWVzIHdvdWxkIGJlIHByZWZlcmFibGUuCgpPdGhlcndpc2UsIHRoaXMgbG9va3MgZmluZS4K Ck1hcmssLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K bGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752525AbdB1MvH (ORCPT ); Tue, 28 Feb 2017 07:51:07 -0500 Received: from foss.arm.com ([217.140.101.70]:36870 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752309AbdB1MvD (ORCPT ); Tue, 28 Feb 2017 07:51:03 -0500 Date: Tue, 28 Feb 2017 12:39:08 +0000 From: Mark Rutland To: Andreas =?utf-8?Q?F=C3=A4rber?= Cc: arm@kernel.org, linux-arm-kernel@lists.infradead.org, mp-cs@actions-semi.com, 96boards@ucrobotics.com, support@lemaker.org, linux-kernel@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org Subject: Re: [PATCH v3 03/25] dt-bindings: timer: Document Owl timer Message-ID: <20170228123908.GG3691@leverpostej> References: <20170228063535.32069-1-afaerber@suse.de> <20170228063535.32069-4-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170228063535.32069-4-afaerber@suse.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 28, 2017 at 07:35:13AM +0100, Andreas Färber wrote: > The Actions Semi S500 SoC contains a timer block with two 2 Hz and two > 32-bit timers. The S900 SoC timer block has four 32-bit timers. > > Signed-off-by: Andreas Färber > --- > v2 -> v3: > * Adopted interrupt-names > * Changed compatible for S500 > * Added S900 compatible and interrupt names > > v2: new > > .../devicetree/bindings/timer/actions,owl-timer.txt | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > create mode 100644 Documentation/devicetree/bindings/timer/actions,owl-timer.txt > > diff --git a/Documentation/devicetree/bindings/timer/actions,owl-timer.txt b/Documentation/devicetree/bindings/timer/actions,owl-timer.txt > new file mode 100644 > index 0000000..5b4834d > --- /dev/null > +++ b/Documentation/devicetree/bindings/timer/actions,owl-timer.txt > @@ -0,0 +1,20 @@ > +Actions Semi Owl Timer > + > +Required properties: > +- compatible : "actions,s500-timer" for S500 > + "actions,s900-timer" for S900 > +- reg : Offset and length of the register set for the device. > +- interrupts : Should contain the interrupts. > +- interrupt-names : Valid names are: "2Hz0", "2Hz1", > + "Timer0", "Timer1", "Timer2", "Timer3" Sticking to lower case for the names would be preferable. Otherwise, this looks fine. Mark,.