From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 2/2] drm/i915: Remove duplicate DDI enabling logic from MST path Date: Tue, 28 Feb 2017 17:03:26 +0200 Message-ID: <20170228150326.GN31595@intel.com> References: <20170228071452.20404-1-ander.conselvan.de.oliveira@intel.com> <20170228072113.21530-2-ander.conselvan.de.oliveira@intel.com> <20170228135952.GB13937@ideak-desk.fi.intel.com> <20170228140931.GK31595@intel.com> <20170228143346.GC13937@ideak-desk.fi.intel.com> <20170228144751.GL31595@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 829156E74F for ; Tue, 28 Feb 2017 15:03:48 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170228144751.GL31595@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak Cc: Ander Conselvan de Oliveira , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBGZWIgMjgsIDIwMTcgYXQgMDQ6NDc6NTFQTSArMDIwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFR1ZSwgRmViIDI4LCAyMDE3IGF0IDA0OjMzOjQ2UE0gKzAyMDAsIEltcmUg RGVhayB3cm90ZToKPiA+IE9uIFR1ZSwgRmViIDI4LCAyMDE3IGF0IDA0OjA5OjMxUE0gKzAyMDAs IFZpbGxlIFN5cmrDpGzDpCB3cm90ZToKPiA+ID4gT24gVHVlLCBGZWIgMjgsIDIwMTcgYXQgMDM6 NTk6NTJQTSArMDIwMCwgSW1yZSBEZWFrIHdyb3RlOgo+ID4gPiA+IE9uIFR1ZSwgRmViIDI4LCAy MDE3IGF0IDA5OjIxOjEzQU0gKzAyMDAsIEFuZGVyIENvbnNlbHZhbiBkZSBPbGl2ZWlyYSB3cm90 ZToKPiA+ID4gPiA+IFRoZSBsb2dpYyB0byBlbmFibGUgYSBEREkgaW4gaW50ZWxfbXN0X3ByZV9l bmFibGVfZHAoKSBpcyBlc3NlbnRpYWxseQo+ID4gPiA+ID4gdGhlIHNhbWUgYXMgaW4gaW50ZWxf ZGRpX3ByZV9lbmFibGVfZHAoKS4gU28gcmV1c2UgdGhlIGxhdHRlciBmdW5jdGlvbgo+ID4gPiA+ ID4gYnkgY2FsbGluZyB0aGUgcG9zdF9kaXNhYmxlIGhvb2sgb24gdGhlIGludGVsX2RpZ19wb3J0 IGluc3RlYWQgb2YKPiA+ID4gPiAgICAgICAgICAgICAgICAgIF5wcmVfZW5hYmxlCj4gPiA+ID4g PiBkdXBsaWNhdGluZyB0aGF0IGNvZGUuCj4gPiA+ID4gPiAKPiA+ID4gPiA+IENjOiBWaWxsZSBT eXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4gPiA+ID4gU2lnbmVk LW9mZi1ieTogQW5kZXIgQ29uc2VsdmFuIGRlIE9saXZlaXJhIDxhbmRlci5jb25zZWx2YW4uZGUu b2xpdmVpcmFAaW50ZWwuY29tPgo+ID4gPiA+ID4gLS0tCj4gPiA+ID4gPiAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZGRpLmMgICAgfCAgMiArKwo+ID4gPiA+ID4gIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2RwX21zdC5jIHwgMjMgKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiA+ID4g PiA+ICAyIGZpbGVzIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgMjAgZGVsZXRpb25zKC0pCj4g PiA+ID4gPiAKPiA+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kZGkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gPiA+ID4gPiBpbmRl eCBlOTAxM2YxLi43MWFhZGRmIDEwMDY0NAo+ID4gPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZGRpLmMKPiA+ID4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2RkaS5jCj4gPiA+ID4gPiBAQCAtMTY5NSw2ICsxNjk1LDggQEAgc3RhdGljIHZvaWQgaW50 ZWxfZGRpX3ByZV9lbmFibGVfZHAoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gPiA+ ID4gPiAgCWVudW0gcG9ydCBwb3J0ID0gaW50ZWxfZGRpX2dldF9lbmNvZGVyX3BvcnQoZW5jb2Rl cik7Cj4gPiA+ID4gPiAgCXN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmRpZ19wb3J0ID0gZW5j X3RvX2RpZ19wb3J0KCZlbmNvZGVyLT5iYXNlKTsKPiA+ID4gPiA+ICAKPiA+ID4gPiA+ICsJV0FS Tl9PTihsaW5rX21zdCAmJiBwb3J0ID09IFBPUlRfQSk7Cj4gPiA+ID4gPiArCj4gPiA+ID4gCj4g PiA+ID4gU28gSUlVQywgdGhpcyB3YXNuJ3QgdXNlZCBiZWZvcmUgZm9yIE1TVCBhbmQgc28gbGlu a19tc3Qgd2FzIGFsd2F5cwo+ID4gPiA+IGZhbHNlLgo+ID4gPiAKPiA+ID4gVGhlIE1TVCBjb2Rl IGV4cGxpY2l0bHkgcGFzc2VzICd0cnVlJyBoZXJlLgo+ID4gCj4gPiBZZXMsIGFmdGVyIHRoZSBj aGFuZ2UuCj4gCj4gSXQgd2FzICd0cnVlJyBiZWZvcmUuIEFmdGVyIHRoZSBjaGFuZ2UgaXQnbGwg YmUgJ2ludGVsX2NydGNfaGFzX3R5cGUoTVNUKScKCkFoZW0uIFNvIEkgdGhvdWdodCB3ZSB3ZXJl IHRhbGtpbmcgYWJvdXQgaW50ZWxfZHBfc2V0X2xpbmtfcGFyYW1zKCksIGJ1dApyZWFsbHkgdGhp cyB3YXMgYWJvdXQgaW50ZWxfZGRpX3ByZV9lbmFibGVfZHAoKS4gU28geWVzLCB5b3UncmUgY29y cmVjdAp0aGF0IGludGVsX2RkaV9wcmVfZW5hYmxlX2RwKCkgd2FzIG5vdCBhY3R1YWxseSB1c2Vk IGZvciBNU1QuCgo+IAo+ID4gSSB3YXMganVzdCB3b25kZXJpbmcgd2h5IHRoaXMgd2Fzbid0IHVz ZWQgZm9yIE1TVAo+ID4gYmVmb3JlLgo+ID4gCj4gPiA+IAo+ID4gPiA+IEFsc28gbGlua19tc3Q9 dHJ1ZSBpbXBsaWVzIHR5cGUgPT0gSU5URUxfT1VUUFVUX0RQLCBhcyB0aGlzIHdpbGwKPiA+ID4g PiBiZSBjYWxsZWQgZm9yIHRoZSBwcmltYXJ5IGVuY29kZXIuIEFmdGVyIHRoZSBjaGFuZ2UgY3J0 Yy0+Y29uZmlnIHdpbGwgYmUKPiA+ID4gPiB1c2VkIGluc3RlYWQgb2YgdGhlIChuZXcpIHBpcGVf Y29uZmlnLCBidXQgdGhpcyBpcyBmaW5lIHNpbmNlIHRoZSB0d28KPiA+ID4gPiBhcmUgdGhlIHNh bWUgaW4gdGhlIGVuYWJsZSBob29rcy4KPiA+ID4gCj4gPiA+IE5vcGUuIEFGQUlDUyB0aGlzIHNo b3VsZCBleHBsb2RlIHRvdGFsbHkgc2luY2UgZW5jb2Rlci0+Y3J0YyBmb3IgdGhlCj4gPiA+IHBy aW1hcnkgd2lsbCBiZSBOVUxMLiBJIGd1ZXNzIE1hYXJ0ZW4gZGlkbid0IHlldCBudWtlIGFsbCBj cnRjLT5jb25maWcKPiA+ID4gdXNhZ2UgZnJvbSB0aGUgZGRpIGNvZGUgKG9yIGhlIGRpZCBidXQg dGhlIHBhdGNoZXMgZGlkbid0IGdldCByZXZpZXdlZCkuCj4gPiAKPiA+IEVyciwgcmlnaHQuIFNv IHRoaXMgd291bGQgbmVlZCBmaXJzdCBjaGFuZ2luZyB0byB1c2UgY3J0Yy0+Y29uZmlnIHRvCj4g PiBwaXBlX2NvbmZpZyBpbiBpbnRlbF9kZGlfcHJlX2VuYWJsZS4KPiAKPiArIHJldmlldyBhbGwg dGhlIGNvZGUgdGhhdCBnZXRzIGNhbGxlZCBmcm9tIHRoZXJlIHRvIG1ha2Ugc3VyZSBubyBtb3Jl Cj4gdXNlcnMgYXJlIGx1cmtpbmcgc29tZXdoZXJlIGRlZXBlci4KPiAKPiA+IAo+ID4gLS1JbXJl Cj4gPiAKPiA+ID4gCj4gPiA+ID4gTG9va3Mgb2sgdG8gbWU6Cj4gPiA+ID4gCj4gPiA+ID4gUmV2 aWV3ZWQtYnk6IEltcmUgRGVhayA8aW1yZS5kZWFrQGludGVsLmNvbT4KPiA+ID4gPiAKPiA+ID4g PiA+ICAJaW50ZWxfZHBfc2V0X2xpbmtfcGFyYW1zKGludGVsX2RwLCBsaW5rX3JhdGUsIGxhbmVf Y291bnQsCj4gPiA+ID4gPiAgCQkJCSBsaW5rX21zdCk7Cj4gPiA+ID4gPiAgCWlmIChlbmNvZGVy LT50eXBlID09IElOVEVMX09VVFBVVF9FRFApCj4gPiA+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBfbXN0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kcF9tc3QuYwo+ID4gPiA+ID4gaW5kZXggYTgzMzRlMS4uMDk0Y2JkYyAxMDA2NDQKPiA+ID4g PiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwX21zdC5jCj4gPiA+ID4gPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcF9tc3QuYwo+ID4gPiA+ID4gQEAgLTE1 OSwyNiArMTU5LDkgQEAgc3RhdGljIHZvaWQgaW50ZWxfbXN0X3ByZV9lbmFibGVfZHAoc3RydWN0 IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gPiA+ID4gPiAgCj4gPiA+ID4gPiAgCURSTV9ERUJV R19LTVMoIiVkXG4iLCBpbnRlbF9kcC0+YWN0aXZlX21zdF9saW5rcyk7Cj4gPiA+ID4gPiAgCj4g PiA+ID4gPiAtCWlmIChpbnRlbF9kcC0+YWN0aXZlX21zdF9saW5rcyA9PSAwKSB7Cj4gPiA+ID4g PiAtCQlpbnRlbF9kZGlfY2xrX3NlbGVjdCgmaW50ZWxfZGlnX3BvcnQtPmJhc2UsCj4gPiA+ID4g PiAtCQkJCSAgICAgcGlwZV9jb25maWctPnNoYXJlZF9kcGxsKTsKPiA+ID4gPiA+IC0KPiA+ID4g PiA+IC0JCWludGVsX2Rpc3BsYXlfcG93ZXJfZ2V0KGRldl9wcml2LAo+ID4gPiA+ID4gLQkJCQkJ aW50ZWxfZGlnX3BvcnQtPmRkaV9pb19wb3dlcl9kb21haW4pOwo+ID4gPiA+ID4gLQo+ID4gPiA+ ID4gLQkJaW50ZWxfcHJlcGFyZV9kcF9kZGlfYnVmZmVycygmaW50ZWxfZGlnX3BvcnQtPmJhc2Up Owo+ID4gPiA+ID4gLQkJaW50ZWxfZHBfc2V0X2xpbmtfcGFyYW1zKGludGVsX2RwLAo+ID4gPiA+ ID4gLQkJCQkJIHBpcGVfY29uZmlnLT5wb3J0X2Nsb2NrLAo+ID4gPiA+ID4gLQkJCQkJIHBpcGVf Y29uZmlnLT5sYW5lX2NvdW50LAo+ID4gPiA+ID4gLQkJCQkJIHRydWUpOwo+ID4gPiA+ID4gLQo+ ID4gPiA+ID4gLQkJaW50ZWxfZGRpX2luaXRfZHBfYnVmX3JlZygmaW50ZWxfZGlnX3BvcnQtPmJh c2UpOwo+ID4gPiA+ID4gLQo+ID4gPiA+ID4gLQkJaW50ZWxfZHBfc2lua19kcG1zKGludGVsX2Rw LCBEUk1fTU9ERV9EUE1TX09OKTsKPiA+ID4gPiA+IC0KPiA+ID4gPiA+IC0JCWludGVsX2RwX3N0 YXJ0X2xpbmtfdHJhaW4oaW50ZWxfZHApOwo+ID4gPiA+ID4gLQkJaW50ZWxfZHBfc3RvcF9saW5r X3RyYWluKGludGVsX2RwKTsKPiA+ID4gPiA+IC0JfQo+ID4gPiA+ID4gKwlpZiAoaW50ZWxfZHAt PmFjdGl2ZV9tc3RfbGlua3MgPT0gMCkKPiA+ID4gPiA+ICsJCWludGVsX2RpZ19wb3J0LT5iYXNl LnByZV9lbmFibGUoJmludGVsX2RpZ19wb3J0LT5iYXNlLAo+ID4gPiA+ID4gKwkJCQkJCXBpcGVf Y29uZmlnLCBOVUxMKTsKPiA+ID4gPiA+ICAKPiA+ID4gPiA+ICAJcmV0ID0gZHJtX2RwX21zdF9h bGxvY2F0ZV92Y3BpKCZpbnRlbF9kcC0+bXN0X21nciwKPiA+ID4gPiA+ICAJCQkJICAgICAgIGNv bm5lY3Rvci0+cG9ydCwKPiA+ID4gPiA+IC0tIAo+ID4gPiA+ID4gMi45LjMKPiA+ID4gPiA+IAo+ ID4gPiA+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K PiA+ID4gPiA+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiA+ID4gPiA+IEludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKPiA+ID4gPiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cj4gPiA+ID4gX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+ID4gPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0 Cj4gPiA+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gPiA+IGh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cj4gPiA+IAo+ ID4gPiAtLSAKPiA+ID4gVmlsbGUgU3lyasOkbMOkCj4gPiA+IEludGVsIE9UQwo+IAo+IC0tIAo+ IFZpbGxlIFN5cmrDpGzDpAo+IEludGVsIE9UQwo+IF9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==