From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sowmini Varadhan Subject: Re: net/rds: use-after-free in inet_create Date: Tue, 28 Feb 2017 12:33:28 -0500 Message-ID: <20170228173328.GL31155@oracle.com> References: <20170228153737.GG31155@oracle.com> <20170228161544.GH31155@oracle.com> <20170228163833.GI31155@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dmitry Vyukov Cc: santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, David Miller , netdev , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rds-devel-N0ozoZBvEnrZJqsBc5GL+g@public.gmane.org, LKML , Eric Dumazet , syzkaller List-Id: linux-rdma@vger.kernel.org On (02/28/17 17:51), Dmitry Vyukov wrote: > Searching other crashes for "net/rds" I found 2 more crashes that may > be related. They suggest that the delayed works are not properly > stopped when the socket is destroyed. That would explain how > rds_connect_worker accesses freed net, right? yes, I think we may want to explicitly cancel this workq.. this in rds_conn_destroy(). I'm trying to build/sanity-test (if lucky, reproduce the bug) as I send this out.. let me get back to you.. If I have a patch against net-next, would you be willing/able to try it out? given that this does not show up on demand, I'm not sure how we can check that "the fix worked".. --Sowmini -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751037AbdB1Rf7 (ORCPT ); Tue, 28 Feb 2017 12:35:59 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:31265 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751243AbdB1Rfu (ORCPT ); Tue, 28 Feb 2017 12:35:50 -0500 Date: Tue, 28 Feb 2017 12:33:28 -0500 From: Sowmini Varadhan To: Dmitry Vyukov Cc: santosh.shilimkar@oracle.com, David Miller , netdev , linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, LKML , Eric Dumazet , syzkaller Subject: Re: net/rds: use-after-free in inet_create Message-ID: <20170228173328.GL31155@oracle.com> References: <20170228153737.GG31155@oracle.com> <20170228161544.GH31155@oracle.com> <20170228163833.GI31155@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (02/28/17 17:51), Dmitry Vyukov wrote: > Searching other crashes for "net/rds" I found 2 more crashes that may > be related. They suggest that the delayed works are not properly > stopped when the socket is destroyed. That would explain how > rds_connect_worker accesses freed net, right? yes, I think we may want to explicitly cancel this workq.. this in rds_conn_destroy(). I'm trying to build/sanity-test (if lucky, reproduce the bug) as I send this out.. let me get back to you.. If I have a patch against net-next, would you be willing/able to try it out? given that this does not show up on demand, I'm not sure how we can check that "the fix worked".. --Sowmini