Re: [PATCH 1/1] xen/arm: Add pl011 uart support in Xen for guest domains

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Mon, Feb 20, 2017 at 08:53:50PM +0530, Bhupinder Thakur wrote:
> Hi,
> 
> 
> On 17 February 2017 at 20:59, Konrad Rzeszutek Wilk
> <konrad.wilk@oracle.com> wrote:
> >> >>>>    Should vpl011.h be in include/xen/public/ ? If so you need
> >> >>>>    a different license for that file.
> >> >>>>
> >> I have moved the file from the public folder and keeping it in xen/arch/arm/
> >
> > Huh? But if this is a ring protocol that is used by an OS that is not
> > part of of Xen tree it needs to be in public/io/ location.
> >
> > Otherwise you may run in problems with different licenses (public/io
> > has BSD license while arch/arm is GPL) - and it may be that your
> > 'console backend' is proprietary.
> 
> xen/include/public/console/io.h contains the definition of the ring
> structure (xencons_interface) which is used by the xenconsoled running
> on the dom0 OS. The definitions in vpl011.h are used locally by the

..and also in the Linux code - as the PV frontend.

> emulation code in Xen including one ring structure which is defined
> same as the one defined in the public folder.

.. Aaah. Then it should still be accessible from the xenconsold and to
be in the common code.
> 
> Regards,
> Bhupinder

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel