From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751883AbdCACkM (ORCPT ); Tue, 28 Feb 2017 21:40:12 -0500 Received: from muru.com ([72.249.23.125]:36974 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751511AbdCACjV (ORCPT ); Tue, 28 Feb 2017 21:39:21 -0500 Date: Tue, 28 Feb 2017 16:44:41 -0800 From: Tony Lindgren To: Milo Kim Cc: Lee Jones , Rob Herring , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mfd: add TI LMU driver Message-ID: <20170301004441.GH20572@atomide.com> References: <20170228064515.7320-1-milo.kim@ti.com> <20170228064515.7320-3-milo.kim@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170228064515.7320-3-milo.kim@ti.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Milo Kim [170227 22:47]: > TI LMU (Lighting Management Unit) driver supports lighting devices below. > > LM3532, LM3631, LM3632, LM3633, LM3695 and LM3697. > > LMU devices have common features. > - I2C interface for accessing device registers > - Hardware enable pin control > - Backlight brightness control > - Notifier for hardware fault monitoring > - Regulators for LCD display bias > > It contains fault monitor, backlight, LED and regulator driver. > > LMU fault monitor > ----------------- > LM3633 and LM3697 provide hardware monitoring feature. > It enables open or short circuit detection. > After monitoring is done, each device should be re-initialized. > Notifier is used for this case. > Separate patch for 'ti-lmu-fault-monitor' will be sent later. > > Backlight > --------- > It's handled by TI LMU backlight consolidated driver and > chip dependent data. Separate patchset will be sent later. > > LED indicator > ------------- > LM3633 has 6 indicator LEDs. Programmable dimming pattern is also > supported. Separate patch for 'leds-lm3633' will be sent later. > > Regulator > --------- > LM3631 has 5 regulators for the display bias. > LM3632 supports 3 regulators. One consolidated driver enables it. > The lm363x regulator driver is already upstreamed. > > Acked-by: Lee Jones > Signed-off-by: Milo Kim This works for me on droid 4 with LM3632 using your earlier "[v2,7/9] backlight: add TI LMU backlight driver" patch at https://patchwork.kernel.org/patch/7704601/ I had to update the dts file according to the binding and then enable backlight after booting with: # echo 180 > /sys/class/backlight/lcd/brightness So please feel free to add: Tested-by: Tony Lindgren