Re: [PATCH] staging: dgnc: replace usleep_range with udelay

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Mon, Feb 27, 2017 at 11:44:36PM +0530, Aishwarya Pant wrote:
> Replace usleep_range by udelay in function cls_flush_uart_write as it
> called under a channel lock
> 
> Signed-off-by: Aishwarya Pant <aishpant@gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_cls.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
> index c20ffdd..f116ce1 100644
> --- a/drivers/staging/dgnc/dgnc_cls.c
> +++ b/drivers/staging/dgnc/dgnc_cls.c
> @@ -609,7 +609,7 @@ static void cls_flush_uart_write(struct channel_t *ch)
>  
>  	writeb((UART_FCR_ENABLE_FIFO | UART_FCR_CLEAR_XMIT),
>  	       &ch->ch_cls_uart->isr_fcr);
> -	usleep_range(10, 20);
> +	udelay(10);

Please comment why you can not use usleep_range() here, otherwise
someone else will come along and change it later.

thanks,

greg k-h