From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH 01/10] x86: assembly, ENTRY for fn, GLOBAL for data Date: Wed, 1 Mar 2017 10:38:56 +0100 Message-ID: <20170301093855.GA27152@gmail.com> References: <20170217104757.28588-1-jslaby@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170217104757.28588-1-jslaby@suse.cz> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jiri Slaby Cc: Juergen Gross , Len Brown , hpa@zytor.com, Andrew Morton , linux-pm@vger.kernel.org, x86@kernel.org, "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, mingo@redhat.com, Pavel Machek , jpoimboe@redhat.com, xen-devel@lists.xenproject.org, tglx@linutronix.de, Linus Torvalds , Boris Ostrovsky , Peter Zijlstra List-Id: linux-pm@vger.kernel.org CiogSmlyaSBTbGFieSA8anNsYWJ5QHN1c2UuY3o+IHdyb3RlOgoKPiBUaGlzIGlzIGEgc3RhcnQg b2Ygc2VyaWVzIHRvIHVuaWZ5IHVzZSBvZiBFTlRSWSwgRU5EUFJPQywgR0xPQkFMLCBFTkQsCj4g YW5kIG90aGVyIG1hY3JvcyBhY3Jvc3MgeDg2LiBXaGVuIHdlIGhhdmUgYWxsIHRoaXMgc29ydGVk IG91dCwgdGhpcyB3aWxsCj4gaGVscCB0byBpbmplY3QgRFdBUkYgdW53aW5kaW5nIGluZm8gYnkg b2JqdG9vbCBsYXRlci4KPiAKPiBTbywgbGV0IHVzIHVzZSB0aGUgbWFjcm9zIHRoaXMgd2F5Ogo+ ICogRU5UUlkgLS0gc3RhcnQgb2YgYSBnbG9iYWwgZnVuY3Rpb24KPiAqIEVORFBST0MgLS0gZW5k IG9mIGEgbG9jYWwvZ2xvYmFsIGZ1bmN0aW9uCj4gKiBHTE9CQUwgLS0gc3RhcnQgb2YgYSBnbG9i YWxseSB2aXNpYmxlIGRhdGEgc3ltYm9sCj4gKiBFTkQgLS0gZW5kIG9mIGxvY2FsL2dsb2JhbCBk YXRhIHN5bWJvbAoKU28gaG93IGFib3V0IHVzaW5nIG1hY3JvIG5hbWVzIHRoYXQgYWN0dWFsbHkg c2hvdyB0aGUgcHVycG9zZSwgaW5zdGVhZCBvZiAKaW1wb3J0aW5nIGFsbCB0aGUgY3JhcHB5LCBo aXN0b3JpYywgZXNzZW50aWFsbHkgcmFuZG9tbHkgY2hvc2VuIGRlYnVnIHN5bWJvbCBtYWNybyAK bmFtZXMgZnJvbSB0aGUgYmludXRpbHMgYW5kIG9sZGVyIGtlcm5lbHM/CgpTb21ldGhpbmcgc2Fu ZSwgbGlrZToKCglTWU1fX0ZVTkNUSU9OX1NUQVJUCglTWU1fX0ZVTkNUSU9OX0VORAoKCVNZTV9f REFUQV9TVEFSVAoJU1lNX19EQVRBX0VORAoKLi4uIGFuZCBleHRlbmQgdGhhdCBtYWNybyBuYW1l c3BhY2Ugd2l0aCBhbnkgb3RoZXIgdmFyaWFudHMgd2UgbWlnaHQgbmVlZC4KCldlIGNhbiBzdGls bCBrZWVwIHRoZSBvbGQgbWFjcm8gbmFtZXMgKGZvciBhIHNob3J0IHdoaWxlKSB0byBlYXNlIHRo ZSB0cmFuc2l0aW9uLCAKYnV0IGZvciBoZWF2ZW4ncyBzYWtlLCBpZiB3ZSBkbyAiY2xlYW51cHMi IGJlZm9yZSBjb21wbGljYXRpbmcgdGhlIGNvZGUgbGV0J3MgbWFrZSAKc3VyZSB0aGUgcmVzdWx0 IGlzIGFjdHVhbGx5IHJlYWRhYmxlIQoKQWdyZWVkPwoKVGhhbmtzLAoKCUluZ28KCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5n IGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1k ZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753333AbdCAWwC (ORCPT ); Wed, 1 Mar 2017 17:52:02 -0500 Received: from mail-wr0-f194.google.com ([209.85.128.194]:36681 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751387AbdCAWwA (ORCPT ); Wed, 1 Mar 2017 17:52:00 -0500 Date: Wed, 1 Mar 2017 10:38:56 +0100 From: Ingo Molnar To: Jiri Slaby Cc: mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com, x86@kernel.org, jpoimboe@redhat.com, linux-kernel@vger.kernel.org, Boris Ostrovsky , Juergen Gross , xen-devel@lists.xenproject.org, "Rafael J. Wysocki" , Len Brown , Pavel Machek , linux-pm@vger.kernel.org, Linus Torvalds , Andrew Morton , Peter Zijlstra Subject: Re: [PATCH 01/10] x86: assembly, ENTRY for fn, GLOBAL for data Message-ID: <20170301093855.GA27152@gmail.com> References: <20170217104757.28588-1-jslaby@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170217104757.28588-1-jslaby@suse.cz> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Jiri Slaby wrote: > This is a start of series to unify use of ENTRY, ENDPROC, GLOBAL, END, > and other macros across x86. When we have all this sorted out, this will > help to inject DWARF unwinding info by objtool later. > > So, let us use the macros this way: > * ENTRY -- start of a global function > * ENDPROC -- end of a local/global function > * GLOBAL -- start of a globally visible data symbol > * END -- end of local/global data symbol So how about using macro names that actually show the purpose, instead of importing all the crappy, historic, essentially randomly chosen debug symbol macro names from the binutils and older kernels? Something sane, like: SYM__FUNCTION_START SYM__FUNCTION_END SYM__DATA_START SYM__DATA_END ... and extend that macro namespace with any other variants we might need. We can still keep the old macro names (for a short while) to ease the transition, but for heaven's sake, if we do "cleanups" before complicating the code let's make sure the result is actually readable! Agreed? Thanks, Ingo