From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH 01/10] x86: assembly, ENTRY for fn, GLOBAL for data Date: Wed, 1 Mar 2017 11:27:54 +0100 Message-ID: <20170301102754.GA13374@gmail.com> References: <20170217104757.28588-1-jslaby@suse.cz> <20170301093855.GA27152@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Thomas Gleixner Cc: Juergen Gross , Len Brown , hpa@zytor.com, Peter Zijlstra , linux-pm@vger.kernel.org, Linus Torvalds , x86@kernel.org, "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, mingo@redhat.com, Pavel Machek , jpoimboe@redhat.com, xen-devel@lists.xenproject.org, Boris Ostrovsky , Jiri Slaby , Andrew Morton List-Id: linux-pm@vger.kernel.org CiogVGhvbWFzIEdsZWl4bmVyIDx0Z2x4QGxpbnV0cm9uaXguZGU+IHdyb3RlOgoKPiBPbiBXZWQs IDEgTWFyIDIwMTcsIEluZ28gTW9sbmFyIHdyb3RlOgo+ID4gCj4gPiAqIEppcmkgU2xhYnkgPGpz bGFieUBzdXNlLmN6PiB3cm90ZToKPiA+IAo+ID4gPiBUaGlzIGlzIGEgc3RhcnQgb2Ygc2VyaWVz IHRvIHVuaWZ5IHVzZSBvZiBFTlRSWSwgRU5EUFJPQywgR0xPQkFMLCBFTkQsCj4gPiA+IGFuZCBv dGhlciBtYWNyb3MgYWNyb3NzIHg4Ni4gV2hlbiB3ZSBoYXZlIGFsbCB0aGlzIHNvcnRlZCBvdXQs IHRoaXMgd2lsbAo+ID4gPiBoZWxwIHRvIGluamVjdCBEV0FSRiB1bndpbmRpbmcgaW5mbyBieSBv Ymp0b29sIGxhdGVyLgo+ID4gPiAKPiA+ID4gU28sIGxldCB1cyB1c2UgdGhlIG1hY3JvcyB0aGlz IHdheToKPiA+ID4gKiBFTlRSWSAtLSBzdGFydCBvZiBhIGdsb2JhbCBmdW5jdGlvbgo+ID4gPiAq IEVORFBST0MgLS0gZW5kIG9mIGEgbG9jYWwvZ2xvYmFsIGZ1bmN0aW9uCj4gPiA+ICogR0xPQkFM IC0tIHN0YXJ0IG9mIGEgZ2xvYmFsbHkgdmlzaWJsZSBkYXRhIHN5bWJvbAo+ID4gPiAqIEVORCAt LSBlbmQgb2YgbG9jYWwvZ2xvYmFsIGRhdGEgc3ltYm9sCj4gPiAKPiA+IFNvIGhvdyBhYm91dCB1 c2luZyBtYWNybyBuYW1lcyB0aGF0IGFjdHVhbGx5IHNob3cgdGhlIHB1cnBvc2UsIGluc3RlYWQg b2YgCj4gPiBpbXBvcnRpbmcgYWxsIHRoZSBjcmFwcHksIGhpc3RvcmljLCBlc3NlbnRpYWxseSBy YW5kb21seSBjaG9zZW4gZGVidWcgc3ltYm9sIG1hY3JvIAo+ID4gbmFtZXMgZnJvbSB0aGUgYmlu dXRpbHMgYW5kIG9sZGVyIGtlcm5lbHM/Cj4gPiAKPiA+IFNvbWV0aGluZyBzYW5lLCBsaWtlOgo+ ID4gCj4gPiAJU1lNX19GVU5DVElPTl9TVEFSVAo+IAo+IFNhbmUgd291bGQgYmU6Cj4gCj4gICAg ICAJU1lNX0ZVTkNUSU9OX1NUQVJUCj4gCj4gVGhlIGRvdWJsZSB1bmRlcnNjb3JlIGlzIGp1c3Qg bm90IGdpdmluZyBhbnkgdmFsdWUuCgpTbyB0aGUgZG91YmxlIHVuZGVyc2NvcmUgKGF0IGxlYXN0 IGluIG15IHZpZXcpIGhhcyB0d28gYWR2YW50YWdlczoKCjEpIGl0IGhlbHBzIHNlcGFyYXRlIHRo ZSBwcmVmaXggZnJvbSB0aGUgcG9zdGZpeC4KCkkuZS4gaXQncyBhICdzeW1ib2xzJyBuYW1lc3Bh Y2UsIGFuZCBhICdmdW5jdGlvbiBzdGFydCcsIG5vdCB0aGUgJ3N0YXJ0JyBvZiBhIAonc3ltYm9s IGZ1bmN0aW9uJy4KCjIpIEl0IGFsc28gaGVscHMgZWFzeSBncmVwcGFiaWxpdHkuCgpUcnkgdGhp cyBpbiBsYXRlc3QgLXRpcDoKCiAgZ2l0IGdyZXAgZTgyMF9fCgpUbyBzZWUgYWxsIHRoZSBFODIw IEFQSSBjYWxscyAtIHdpdGggbm8gZmFsc2UgcG9zaXRpdmVzIQoKJ2dpdCBncmVwIGU4MjBfJyBv biB0aGUgb3RoZXIgaGFuZCBpcyBhIGxvdCBsZXNzIHJlbGlhYmxlLi4uCgpCdXQgbm8gc3Ryb25n IGZlZWxpbmdzIGVpdGhlciB3YXksIEkganVzdCB0cnkgdG8gc25lYWsgaW4gdGhlc2Ugc21hbGwg bmFtZXNwYWNlIApzdHJ1Y3R1cmUgdHJpY2tzIHdoZW4gbm9ib2R5J3MgbG9va2luZyEgOy0pCgpU aGFua3MsCgoJSW5nbwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRw czovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752474AbdCALBK (ORCPT ); Wed, 1 Mar 2017 06:01:10 -0500 Received: from mail-wr0-f196.google.com ([209.85.128.196]:34336 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750703AbdCALAm (ORCPT ); Wed, 1 Mar 2017 06:00:42 -0500 Date: Wed, 1 Mar 2017 11:27:54 +0100 From: Ingo Molnar To: Thomas Gleixner Cc: Jiri Slaby , mingo@redhat.com, hpa@zytor.com, x86@kernel.org, jpoimboe@redhat.com, linux-kernel@vger.kernel.org, Boris Ostrovsky , Juergen Gross , xen-devel@lists.xenproject.org, "Rafael J. Wysocki" , Len Brown , Pavel Machek , linux-pm@vger.kernel.org, Linus Torvalds , Andrew Morton , Peter Zijlstra Subject: Re: [PATCH 01/10] x86: assembly, ENTRY for fn, GLOBAL for data Message-ID: <20170301102754.GA13374@gmail.com> References: <20170217104757.28588-1-jslaby@suse.cz> <20170301093855.GA27152@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Thomas Gleixner wrote: > On Wed, 1 Mar 2017, Ingo Molnar wrote: > > > > * Jiri Slaby wrote: > > > > > This is a start of series to unify use of ENTRY, ENDPROC, GLOBAL, END, > > > and other macros across x86. When we have all this sorted out, this will > > > help to inject DWARF unwinding info by objtool later. > > > > > > So, let us use the macros this way: > > > * ENTRY -- start of a global function > > > * ENDPROC -- end of a local/global function > > > * GLOBAL -- start of a globally visible data symbol > > > * END -- end of local/global data symbol > > > > So how about using macro names that actually show the purpose, instead of > > importing all the crappy, historic, essentially randomly chosen debug symbol macro > > names from the binutils and older kernels? > > > > Something sane, like: > > > > SYM__FUNCTION_START > > Sane would be: > > SYM_FUNCTION_START > > The double underscore is just not giving any value. So the double underscore (at least in my view) has two advantages: 1) it helps separate the prefix from the postfix. I.e. it's a 'symbols' namespace, and a 'function start', not the 'start' of a 'symbol function'. 2) It also helps easy greppability. Try this in latest -tip: git grep e820__ To see all the E820 API calls - with no false positives! 'git grep e820_' on the other hand is a lot less reliable... But no strong feelings either way, I just try to sneak in these small namespace structure tricks when nobody's looking! ;-) Thanks, Ingo