From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] color: Fix backslash-escape sequences for some non-bash shells
Date: Wed, 1 Mar 2017 15:03:13 +0100 [thread overview]
Message-ID: <20170301140313.GE32207@rei.lan> (raw)
In-Reply-To: <20170301133654.ijl4lqrd3s26vdfq@dell5510>
Hi!
> > > # NOTE: these colors should match colors defined in include/tst_ansi_color.h
> > > - local ansi_color_blue='\e[1;34m'
> > > - local ansi_color_green='\e[1;32m'
> > > - local ansi_color_magenta='\e[1;35m'
> > > - local ansi_color_red='\e[1;31m'
> > > - local ansi_color_yellow='\e[1;33m'
> > > + local ansi_color_blue='\033[34;1m'
> > > + local ansi_color_green='\033[32;1m'
> > > + local ansi_color_magenta='\033[35;1m'
> > > + local ansi_color_red='\033[31;1m'
> > > + local ansi_color_yellow='\033[33;1m'
>
> > I'm a bit puzzled by the change of the position of color and bold in the
> > escape sequence. As far as I can tell it does not matter at all, or does
> > it?
> Sorry, my inattention, I'll generate v2.
I'm not saying that it's wrong. Just that there is no mention of the
change in the commit description and without it it looks meaningless.
--
Cyril Hrubis
chrubis@suse.cz
prev parent reply other threads:[~2017-03-01 14:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 0:03 [LTP] [PATCH 1/2] color: Rename file Petr Vorel
2017-02-17 0:03 ` [LTP] [PATCH 2/2] color: Fix backslash-escape sequences for some non-bash shells Petr Vorel
2017-02-28 21:28 ` Petr Vorel
2017-03-01 13:13 ` Cyril Hrubis
2017-03-01 13:36 ` Petr Vorel
2017-03-01 14:03 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170301140313.GE32207@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.