From: Peter Zijlstra <peterz@infradead.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Taeung Song <treeze.taeung@gmail.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Ingo Molnar <mingo@kernel.org>, Wang Nan <wangnan0@huawei.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view
Date: Wed, 1 Mar 2017 15:30:11 +0100 [thread overview]
Message-ID: <20170301143011.GI6515@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20170301142133.GC2690@danjae.aot.lge.com>
On Wed, Mar 01, 2017 at 11:21:33PM +0900, Namhyung Kim wrote:
> > What's the point of source-only? You can't even see what it is that is
> > expensive.
>
> ???
>From a line like:
a = b ? ptr->c : 0;
How do you tell what it is that causes the problem, the branch miss or
the pointer deref?
Typically looking at the asm this is fairly clear; even without
recording with more specific events.
> This is to show source code + overhead (for each line). People can
> see which line of their source is expensive. I think it's way more
> intuitive for most developers..
And how pray are you going to write better code if you have no clue what
the problem is?
I'm really wondering how you can even think about performance if you're
scared of asm.
next prev parent reply other threads:[~2017-03-01 14:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 19:59 [PATCH v2 0/3] perf annotate: Introduce the new source code view Taeung Song
2017-02-28 19:59 ` [PATCH v2 1/3] perf annotate: Get correct line numbers matched with addr Taeung Song
2017-03-01 13:17 ` Namhyung Kim
2017-03-02 6:05 ` Taeung Song
2017-03-03 2:40 ` Namhyung Kim
2017-03-03 3:25 ` Taeung Song
2017-02-28 19:59 ` [PATCH v2 2/3] perf annotate: Introduce the new source code view Taeung Song
2017-03-01 13:58 ` Namhyung Kim
2017-03-01 14:08 ` Peter Zijlstra
2017-03-01 14:21 ` Namhyung Kim
2017-03-01 14:30 ` Peter Zijlstra [this message]
2017-03-01 14:56 ` Namhyung Kim
2017-03-01 15:07 ` Peter Zijlstra
2017-03-01 15:52 ` Taeung Song
2017-03-03 5:09 ` Namhyung Kim
2017-02-28 19:59 ` [PATCH v2 3/3] perf annotate: Support the new source code view for TUI Taeung Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170301143011.GI6515@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=treeze.taeung@gmail.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.