From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 4/8] drm/i915: Pass pipe_config to pch_enable() functions Date: Wed, 1 Mar 2017 16:38:48 +0200 Message-ID: <20170301143848.GU31595@intel.com> References: <20170301141318.3607-1-ander.conselvan.de.oliveira@intel.com> <20170301141318.3607-5-ander.conselvan.de.oliveira@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 38E7D6E94C for ; Wed, 1 Mar 2017 14:38:52 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170301141318.3607-5-ander.conselvan.de.oliveira@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ander Conselvan de Oliveira Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBNYXIgMDEsIDIwMTcgYXQgMDQ6MTM6MTRQTSArMDIwMCwgQW5kZXIgQ29uc2VsdmFu IGRlIE9saXZlaXJhIHdyb3RlOgo+IFVzaW5nIGNydGMtPmNvbmZpZyBkaXJlY3RseSBpcyBiZWlu ZyByZW1vdmVkIGluIGZhdm9yIG9mIHBhc3NpbmcgYQo+IHBpcGVfY29uZmlnLiBGb2xsb3cgdGhl IHRyZW5kIGFuZCBwYXNzIHBpcGVfY29uZmlnIHRvIHBjaF9lbmFibGUoKQo+IGZ1bmN0aW9ucy4K PiAKPiBTaWduZWQtb2ZmLWJ5OiBBbmRlciBDb25zZWx2YW4gZGUgT2xpdmVpcmEgPGFuZGVyLmNv bnNlbHZhbi5kZS5vbGl2ZWlyYUBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2Rpc3BsYXkuYyB8IDE4ICsrKysrKysrKystLS0tLS0tLQo+ICAxIGZpbGUgY2hh bmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXggNDU0MTVmMC4uYWVhMzAyYiAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBAQCAtNDQ1Niw3ICs0NDU2LDggQEAgaW50ZWxf dHJhbnNfZHBfcG9ydF9zZWwoc3RydWN0IGludGVsX2NydGMgKmNydGMpCj4gICAqICAgLSBEUCB0 cmFuc2NvZGluZyBiaXRzCj4gICAqICAgLSB0cmFuc2NvZGVyCj4gICAqLwo+IC1zdGF0aWMgdm9p ZCBpcm9ubGFrZV9wY2hfZW5hYmxlKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQo+ICtzdGF0aWMg dm9pZCBpcm9ubGFrZV9wY2hfZW5hYmxlKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ICsJCQkJ c3RydWN0IGludGVsX2NydGNfc3RhdGUgKnBpcGVfY29uZmlnKQoKY29uc3QKCkFsc28gcy9waXBl X2NvbmZpZy9jcnRjX3N0YXRlLyBwZXJoYXBzPyBJTU8gd2Ugc2hvdWxkIHRyeSB0byBzdGFydAp1 bmlmeWluZyBvdXIgbmFtaW5nIGNvbnZlbnRpb24gdG8gcmVkdWNlIHRoZSBjb25mdXNpb24gYSBi aXQuCgpZb3UgY291bGQgYWxzbyBwYXNzIGp1c3QgdGhlIHN0YXRlIHNpbmNlIHlvdSBjYW4gZGln IHVwIHRoZSBjcnRjIGZyb20KdGhlcmUuCgo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 ID0gY3J0Yy0+YmFzZS5kZXY7Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYg PSB0b19pOTE1KGRldik7Cj4gQEAgLTQ0ODQsNyArNDQ4NSw3IEBAIHN0YXRpYyB2b2lkIGlyb25s YWtlX3BjaF9lbmFibGUoc3RydWN0IGludGVsX2NydGMgKmNydGMpCj4gIAkJdGVtcCA9IEk5MTVf UkVBRChQQ0hfRFBMTF9TRUwpOwo+ICAJCXRlbXAgfD0gVFJBTlNfRFBMTF9FTkFCTEUocGlwZSk7 Cj4gIAkJc2VsID0gVFJBTlNfRFBMTEJfU0VMKHBpcGUpOwo+IC0JCWlmIChjcnRjLT5jb25maWct PnNoYXJlZF9kcGxsID09Cj4gKwkJaWYgKHBpcGVfY29uZmlnLT5zaGFyZWRfZHBsbCA9PQo+ICAJ CSAgICBpbnRlbF9nZXRfc2hhcmVkX2RwbGxfYnlfaWQoZGV2X3ByaXYsIERQTExfSURfUENIX1BM TF9CKSkKPiAgCQkJdGVtcCB8PSBzZWw7Cj4gIAkJZWxzZQo+IEBAIC00NTA5LDkgKzQ1MTAsOSBA QCBzdGF0aWMgdm9pZCBpcm9ubGFrZV9wY2hfZW5hYmxlKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRj KQo+ICAKPiAgCS8qIEZvciBQQ0ggRFAsIGVuYWJsZSBUUkFOU19EUF9DVEwgKi8KPiAgCWlmIChI QVNfUENIX0NQVChkZXZfcHJpdikgJiYKPiAtCSAgICBpbnRlbF9jcnRjX2hhc19kcF9lbmNvZGVy KGNydGMtPmNvbmZpZykpIHsKPiArCSAgICBpbnRlbF9jcnRjX2hhc19kcF9lbmNvZGVyKHBpcGVf Y29uZmlnKSkgewo+ICAJCWNvbnN0IHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICphZGp1c3RlZF9t b2RlID0KPiAtCQkJJmNydGMtPmNvbmZpZy0+YmFzZS5hZGp1c3RlZF9tb2RlOwo+ICsJCQkmcGlw ZV9jb25maWctPmJhc2UuYWRqdXN0ZWRfbW9kZTsKPiAgCQl1MzIgYnBjID0gKEk5MTVfUkVBRChQ SVBFQ09ORihwaXBlKSkgJiBQSVBFQ09ORl9CUENfTUFTSykgPj4gNTsKPiAgCQlpOTE1X3JlZ190 IHJlZyA9IFRSQU5TX0RQX0NUTChwaXBlKTsKPiAgCQl0ZW1wID0gSTkxNV9SRUFEKHJlZyk7Cj4g QEAgLTQ1NDYsMTAgKzQ1NDcsMTEgQEAgc3RhdGljIHZvaWQgaXJvbmxha2VfcGNoX2VuYWJsZShz dHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykKPiAgCWlyb25sYWtlX2VuYWJsZV9wY2hfdHJhbnNjb2Rl cihkZXZfcHJpdiwgcGlwZSk7Cj4gIH0KPiAgCj4gLXN0YXRpYyB2b2lkIGxwdF9wY2hfZW5hYmxl KHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQo+ICtzdGF0aWMgdm9pZCBscHRfcGNoX2VuYWJsZShz dHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPiArCQkJICAgc3RydWN0IGludGVsX2NydGNfc3RhdGUg KnBpcGVfY29uZmlnKQoKZGl0dG8KCkFueXdheSBsb29rcyBjb3JyZWN0LCBzbyB3LyBvciB3L28g dGhlIGV4dHJhIGlkZWFzIHRoaXMgaXMKUmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmls bGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cgo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGNydGMtPmJhc2UuZGV2KTsKPiAtCWVudW0gdHJhbnNj b2RlciBjcHVfdHJhbnNjb2RlciA9IGNydGMtPmNvbmZpZy0+Y3B1X3RyYW5zY29kZXI7Cj4gKwll bnVtIHRyYW5zY29kZXIgY3B1X3RyYW5zY29kZXIgPSBwaXBlX2NvbmZpZy0+Y3B1X3RyYW5zY29k ZXI7Cj4gIAo+ICAJYXNzZXJ0X3BjaF90cmFuc2NvZGVyX2Rpc2FibGVkKGRldl9wcml2LCBUUkFO U0NPREVSX0EpOwo+ICAKPiBAQCAtNTI4Myw3ICs1Mjg1LDcgQEAgc3RhdGljIHZvaWQgaXJvbmxh a2VfY3J0Y19lbmFibGUoc3RydWN0IGludGVsX2NydGNfc3RhdGUgKnBpcGVfY29uZmlnLAo+ICAJ aW50ZWxfZW5hYmxlX3BpcGUoaW50ZWxfY3J0Yyk7Cj4gIAo+ICAJaWYgKGludGVsX2NydGMtPmNv bmZpZy0+aGFzX3BjaF9lbmNvZGVyKQo+IC0JCWlyb25sYWtlX3BjaF9lbmFibGUoaW50ZWxfY3J0 Yyk7Cj4gKwkJaXJvbmxha2VfcGNoX2VuYWJsZShpbnRlbF9jcnRjLCBwaXBlX2NvbmZpZyk7Cj4g IAo+ICAJYXNzZXJ0X3ZibGFua19kaXNhYmxlZChjcnRjKTsKPiAgCWRybV9jcnRjX3ZibGFua19v bihjcnRjKTsKPiBAQCAtNTM5Myw3ICs1Mzk1LDcgQEAgc3RhdGljIHZvaWQgaGFzd2VsbF9jcnRj X2VuYWJsZShzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25maWcsCj4gIAkJaW50ZWxf ZW5hYmxlX3BpcGUoaW50ZWxfY3J0Yyk7Cj4gIAo+ICAJaWYgKGludGVsX2NydGMtPmNvbmZpZy0+ aGFzX3BjaF9lbmNvZGVyKQo+IC0JCWxwdF9wY2hfZW5hYmxlKGludGVsX2NydGMpOwo+ICsJCWxw dF9wY2hfZW5hYmxlKGludGVsX2NydGMsIHBpcGVfY29uZmlnKTsKPiAgCj4gIAlpZiAoaW50ZWxf Y3J0Y19oYXNfdHlwZShpbnRlbF9jcnRjLT5jb25maWcsIElOVEVMX09VVFBVVF9EUF9NU1QpKQo+ ICAJCWludGVsX2RkaV9zZXRfdmNfcGF5bG9hZF9hbGxvYyhjcnRjLCB0cnVlKTsKPiAtLSAKPiAy LjkuMwoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==