From: Christoph Hellwig <hch@lst.de>
To: Eryu Guan <guaneryu@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
hch@lst.de, Eryu Guan <eguan@redhat.com>
Subject: Re: [PATCH] iomap: invalidate page caches should be after iomap_dio_complete() in direct write
Date: Wed, 1 Mar 2017 16:02:35 +0100 [thread overview]
Message-ID: <20170301150235.GC12248@lst.de> (raw)
In-Reply-To: <20170228173626.27640-1-guaneryu@gmail.com>
This looks fine to me, but instead of the global res variable
please use local variables in the if blocks (and maybe give them
a better name like err).
prev parent reply other threads:[~2017-03-01 15:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 17:36 [PATCH] iomap: invalidate page caches should be after iomap_dio_complete() in direct write Eryu Guan
2017-02-28 22:23 ` Darrick J. Wong
2017-03-01 15:02 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170301150235.GC12248@lst.de \
--to=hch@lst.de \
--cc=eguan@redhat.com \
--cc=guaneryu@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.