From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v3 13/16] net/avp: device statistics
	operations
Date: Wed, 1 Mar 2017 16:35:25 -0800
Message-ID: <20170301163525.2ab7f089@xeon-e3>
References: <1488136143-116389-1-git-send-email-allain.legacy@windriver.com>
 <1488414008-162839-1-git-send-email-allain.legacy@windriver.com>
 <1488414008-162839-14-git-send-email-allain.legacy@windriver.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: <ferruh.yigit@intel.com>, <ian.jolliffe@windriver.com>,
 <jerin.jacob@caviumnetworks.com>, <thomas.monjalon@6wind.com>,
 <dev@dpdk.org>
To: Allain Legacy <allain.legacy@windriver.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg0-f50.google.com (mail-pg0-f50.google.com [74.125.83.50])
 by dpdk.org (Postfix) with ESMTP id 4B66C2BB1
 for <dev@dpdk.org>; Thu,  2 Mar 2017 01:35:33 +0100 (CET)
Received: by mail-pg0-f50.google.com with SMTP id b129so25670543pgc.2
 for <dev@dpdk.org>; Wed, 01 Mar 2017 16:35:33 -0800 (PST)
In-Reply-To: <1488414008-162839-14-git-send-email-allain.legacy@windriver.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, 1 Mar 2017 19:20:05 -0500
Allain Legacy <allain.legacy@windriver.com> wrote:

> +static void
> +avp_dev_stats_get(struct rte_eth_dev *eth_dev, struct rte_eth_stats *stats)
> +{
> +	struct avp_dev *avp = AVP_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private);
> +	unsigned int i;
> +
> +	memset(stats, 0, sizeof(*stats));

Memset here is unnecessary since only caller is rte_eth_stats_get()
which already did memset

int
rte_eth_stats_get(uint8_t port_id, struct rte_eth_stats *stats)
{
	struct rte_eth_dev *dev;

	RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -EINVAL);

	dev = &rte_eth_devices[port_id];
	memset(stats, 0, sizeof(*stats));

	RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->stats_get, -ENOTSUP);
	stats->rx_nombuf = dev->data->rx_mbuf_alloc_failed;
	(*dev->dev_ops->stats_get)(dev, stats);