From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6392178223572058112 X-Received: by 10.200.4.16 with SMTP id v16mr2829819qtg.88.1488398051494; Wed, 01 Mar 2017 11:54:11 -0800 (PST) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.157.8.69 with SMTP id 63ls5386640oty.0.gmail; Wed, 01 Mar 2017 11:54:11 -0800 (PST) X-Received: by 10.13.254.2 with SMTP id o2mr3350186ywf.50.1488398051092; Wed, 01 Mar 2017 11:54:11 -0800 (PST) Received: by 10.202.71.200 with SMTP id u191msoia; Wed, 1 Mar 2017 10:43:24 -0800 (PST) X-Received: by 10.13.252.194 with SMTP id m185mr3021381ywf.145.1488393804443; Wed, 01 Mar 2017 10:43:24 -0800 (PST) Return-Path: Received: from foss.arm.com (foss.arm.com. [217.140.101.70]) by gmr-mx.google.com with ESMTP id c123si912997pfa.4.2017.03.01.10.43.24 for ; Wed, 01 Mar 2017 10:43:24 -0800 (PST) Received-SPF: pass (google.com: domain of mark.rutland@arm.com designates 217.140.101.70 as permitted sender) client-ip=217.140.101.70; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of mark.rutland@arm.com designates 217.140.101.70 as permitted sender) smtp.mailfrom=mark.rutland@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id ED8A9C28; Wed, 1 Mar 2017 10:43:23 -0800 (PST) Received: from leverpostej (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DF6CB3F575; Wed, 1 Mar 2017 10:43:21 -0800 (PST) Date: Wed, 1 Mar 2017 18:43:13 +0000 From: Mark Rutland To: Andreas =?utf-8?Q?F=C3=A4rber?= Cc: Arnd Bergmann , arm@kernel.org, linux-arm-kernel@lists.infradead.org, mp-cs@actions-semi.com, 96boards@ucrobotics.com, support@lemaker.org, linux-kernel@vger.kernel.org, Rob Herring , Russell King , devicetree@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [PATCH v3 11/25] ARM: dts: Add Actions Semi S500 and LeMaker Guitar Message-ID: <20170301184313.GO28874@leverpostej> References: <20170228063535.32069-1-afaerber@suse.de> <20170228063535.32069-12-afaerber@suse.de> <20170228123245.GF3691@leverpostej> <11053e03-8e28-e93d-f1f6-2589a9f7800c@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <11053e03-8e28-e93d-f1f6-2589a9f7800c@suse.de> User-Agent: Mutt/1.5.21 (2010-09-15) On Tue, Feb 28, 2017 at 04:13:00PM +0100, Andreas Färber wrote: > Am 28.02.2017 um 13:32 schrieb Mark Rutland: > > On Tue, Feb 28, 2017 at 07:35:21AM +0100, Andreas Färber wrote: > >> +#include "skeleton.dtsi" > > > > Please don't include skeleton.dtsi. > > Wasn't aware that was permissible. I now see it has been updated with a > textual comment, which predates my past uses of skeleton.dtsi - for > other pending work such as FM4 and XMC4500 I only noticed it was moved > out of armv7m.dtsi so that dtc started spewing scary messages. ;) > > A #warning might be a more effective way to make people aware of its > deprecation - but sadly we have users that predate #include: > > $ git grep /include/ -- arch/arm/boot/dts/ | grep skeleton.dtsi | wc --lines > 32 > $ git grep /include/ -- arch/arm/boot/dts/ | grep skeleton64.dtsi | wc > --lines > 0 > $ git grep skeleton -- arch/arm/boot/dts/ | wc --lines > 117 I deliberately didn't go that route, since people would blindly fix up the warning and mess it up (e.g. forgetting to add the required nodes). While it should be avoided for new dts, it's largely not problematic for old dts, and we can fix those up at our leisure. > > Please add the relevant nodes and > > properties explciitly to your dts{i,} files. > > Great, will do. > > But this series has grown too large to resend just for such nits. Is > there a chance we can get initial patches queued on some arm-soc > for-next branch soonish? It seems -rc1 pulls were merged 5 days ago? There seem to be other comments on this series, and I was under the impression that arm-soc generally pulled branches. Even if you're not going to repost, surely you can fold in the fixup before sending the pull request? Thanks, Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.rutland@arm.com (Mark Rutland) Date: Wed, 1 Mar 2017 18:43:13 +0000 Subject: [PATCH v3 11/25] ARM: dts: Add Actions Semi S500 and LeMaker Guitar In-Reply-To: <11053e03-8e28-e93d-f1f6-2589a9f7800c@suse.de> References: <20170228063535.32069-1-afaerber@suse.de> <20170228063535.32069-12-afaerber@suse.de> <20170228123245.GF3691@leverpostej> <11053e03-8e28-e93d-f1f6-2589a9f7800c@suse.de> Message-ID: <20170301184313.GO28874@leverpostej> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Feb 28, 2017 at 04:13:00PM +0100, Andreas F?rber wrote: > Am 28.02.2017 um 13:32 schrieb Mark Rutland: > > On Tue, Feb 28, 2017 at 07:35:21AM +0100, Andreas F?rber wrote: > >> +#include "skeleton.dtsi" > > > > Please don't include skeleton.dtsi. > > Wasn't aware that was permissible. I now see it has been updated with a > textual comment, which predates my past uses of skeleton.dtsi - for > other pending work such as FM4 and XMC4500 I only noticed it was moved > out of armv7m.dtsi so that dtc started spewing scary messages. ;) > > A #warning might be a more effective way to make people aware of its > deprecation - but sadly we have users that predate #include: > > $ git grep /include/ -- arch/arm/boot/dts/ | grep skeleton.dtsi | wc --lines > 32 > $ git grep /include/ -- arch/arm/boot/dts/ | grep skeleton64.dtsi | wc > --lines > 0 > $ git grep skeleton -- arch/arm/boot/dts/ | wc --lines > 117 I deliberately didn't go that route, since people would blindly fix up the warning and mess it up (e.g. forgetting to add the required nodes). While it should be avoided for new dts, it's largely not problematic for old dts, and we can fix those up at our leisure. > > Please add the relevant nodes and > > properties explciitly to your dts{i,} files. > > Great, will do. > > But this series has grown too large to resend just for such nits. Is > there a chance we can get initial patches queued on some arm-soc > for-next branch soonish? It seems -rc1 pulls were merged 5 days ago? There seem to be other comments on this series, and I was under the impression that arm-soc generally pulled branches. Even if you're not going to repost, surely you can fold in the fixup before sending the pull request? Thanks, Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCH v3 11/25] ARM: dts: Add Actions Semi S500 and LeMaker Guitar Date: Wed, 1 Mar 2017 18:43:13 +0000 Message-ID: <20170301184313.GO28874@leverpostej> References: <20170228063535.32069-1-afaerber@suse.de> <20170228063535.32069-12-afaerber@suse.de> <20170228123245.GF3691@leverpostej> <11053e03-8e28-e93d-f1f6-2589a9f7800c@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <11053e03-8e28-e93d-f1f6-2589a9f7800c@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Andreas =?utf-8?Q?F=C3=A4rber?= Cc: support@lemaker.org, Arnd Bergmann , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Russell King , outreachy-kernel@googlegroups.com, arm@kernel.org, mp-cs@actions-semi.com, 96boards@ucrobotics.com, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org T24gVHVlLCBGZWIgMjgsIDIwMTcgYXQgMDQ6MTM6MDBQTSArMDEwMCwgQW5kcmVhcyBGw6RyYmVy IHdyb3RlOgo+IEFtIDI4LjAyLjIwMTcgdW0gMTM6MzIgc2NocmllYiBNYXJrIFJ1dGxhbmQ6Cj4g PiBPbiBUdWUsIEZlYiAyOCwgMjAxNyBhdCAwNzozNToyMUFNICswMTAwLCBBbmRyZWFzIEbDpHJi ZXIgd3JvdGU6Cgo+ID4+ICsjaW5jbHVkZSAic2tlbGV0b24uZHRzaSIKPiA+IAo+ID4gUGxlYXNl IGRvbid0IGluY2x1ZGUgc2tlbGV0b24uZHRzaS4KPiAKPiBXYXNuJ3QgYXdhcmUgdGhhdCB3YXMg cGVybWlzc2libGUuIEkgbm93IHNlZSBpdCBoYXMgYmVlbiB1cGRhdGVkIHdpdGggYQo+IHRleHR1 YWwgY29tbWVudCwgd2hpY2ggcHJlZGF0ZXMgbXkgcGFzdCB1c2VzIG9mIHNrZWxldG9uLmR0c2kg LSBmb3IKPiBvdGhlciBwZW5kaW5nIHdvcmsgc3VjaCBhcyBGTTQgYW5kIFhNQzQ1MDAgSSBvbmx5 IG5vdGljZWQgaXQgd2FzIG1vdmVkCj4gb3V0IG9mIGFybXY3bS5kdHNpIHNvIHRoYXQgZHRjIHN0 YXJ0ZWQgc3Bld2luZyBzY2FyeSBtZXNzYWdlcy4gOykKPiAKPiBBICN3YXJuaW5nIG1pZ2h0IGJl IGEgbW9yZSBlZmZlY3RpdmUgd2F5IHRvIG1ha2UgcGVvcGxlIGF3YXJlIG9mIGl0cwo+IGRlcHJl Y2F0aW9uIC0gYnV0IHNhZGx5IHdlIGhhdmUgdXNlcnMgdGhhdCBwcmVkYXRlICNpbmNsdWRlOgo+ IAo+ICQgZ2l0IGdyZXAgL2luY2x1ZGUvIC0tIGFyY2gvYXJtL2Jvb3QvZHRzLyB8IGdyZXAgc2tl bGV0b24uZHRzaSB8IHdjIC0tbGluZXMKPiAzMgo+ICQgZ2l0IGdyZXAgL2luY2x1ZGUvIC0tIGFy Y2gvYXJtL2Jvb3QvZHRzLyB8IGdyZXAgc2tlbGV0b242NC5kdHNpIHwgd2MKPiAtLWxpbmVzCj4g MAo+ICQgZ2l0IGdyZXAgc2tlbGV0b24gLS0gYXJjaC9hcm0vYm9vdC9kdHMvIHwgd2MgLS1saW5l cwo+IDExNwoKSSBkZWxpYmVyYXRlbHkgZGlkbid0IGdvIHRoYXQgcm91dGUsIHNpbmNlIHBlb3Bs ZSB3b3VsZCBibGluZGx5IGZpeCB1cAp0aGUgd2FybmluZyBhbmQgbWVzcyBpdCB1cCAoZS5nLiBm b3JnZXR0aW5nIHRvIGFkZCB0aGUgcmVxdWlyZWQgbm9kZXMpLgoKV2hpbGUgaXQgc2hvdWxkIGJl IGF2b2lkZWQgZm9yIG5ldyBkdHMsIGl0J3MgbGFyZ2VseSBub3QgcHJvYmxlbWF0aWMgZm9yCm9s ZCBkdHMsIGFuZCB3ZSBjYW4gZml4IHRob3NlIHVwIGF0IG91ciBsZWlzdXJlLgoKPiA+IFBsZWFz ZSBhZGQgdGhlIHJlbGV2YW50IG5vZGVzIGFuZAo+ID4gcHJvcGVydGllcyBleHBsY2lpdGx5IHRv IHlvdXIgZHRze2ksfSBmaWxlcy4KPiAKPiBHcmVhdCwgd2lsbCBkby4KPiAKPiBCdXQgdGhpcyBz ZXJpZXMgaGFzIGdyb3duIHRvbyBsYXJnZSB0byByZXNlbmQganVzdCBmb3Igc3VjaCBuaXRzLiBJ cwo+IHRoZXJlIGEgY2hhbmNlIHdlIGNhbiBnZXQgaW5pdGlhbCBwYXRjaGVzIHF1ZXVlZCBvbiBz b21lIGFybS1zb2MKPiBmb3ItbmV4dCBicmFuY2ggc29vbmlzaD8gSXQgc2VlbXMgLXJjMSBwdWxs cyB3ZXJlIG1lcmdlZCA1IGRheXMgYWdvPwoKVGhlcmUgc2VlbSB0byBiZSBvdGhlciBjb21tZW50 cyBvbiB0aGlzIHNlcmllcywgYW5kIEkgd2FzIHVuZGVyIHRoZQppbXByZXNzaW9uIHRoYXQgYXJt LXNvYyBnZW5lcmFsbHkgcHVsbGVkIGJyYW5jaGVzLgoKRXZlbiBpZiB5b3UncmUgbm90IGdvaW5n IHRvIHJlcG9zdCwgc3VyZWx5IHlvdSBjYW4gZm9sZCBpbiB0aGUgZml4dXAKYmVmb3JlIHNlbmRp bmcgdGhlIHB1bGwgcmVxdWVzdD8KClRoYW5rcywKTWFyay4KCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK