From: Christoph Hellwig <hch@infradead.org>
To: Goldwyn Rodrigues <rgoldwyn@suse.de>
Cc: Christoph Hellwig <hch@infradead.org>,
jack@suse.com, linux-fsdevel@vger.kernel.org,
linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/8] nowait aio: Introduce IOCB_FLAG_NOWAIT
Date: Wed, 1 Mar 2017 14:44:21 -0800 [thread overview]
Message-ID: <20170301224421.GA12768@infradead.org> (raw)
In-Reply-To: <cc3fc6ee-c48d-1b51-59b7-1e322d10a561@suse.de>
On Wed, Mar 01, 2017 at 10:57:17AM -0600, Goldwyn Rodrigues wrote:
> RWF_* ? Isn't that kernel space flags? Or did you intend to say
> IOCB_FLAG_*?
No, they are the flags for preadv2/pwritev2.
> If yes, we maintain two flag fields? aio_reserved1 (perhaps
> renamed to aio_flags2) and aio_flags?
Yes - I'd call it aio_rw_flags or similar.
> aio_reserved1 is also used to return key for the purpose of io_cancel,
> but we should be able to fetch the flags before putting the key value
> there. Still I am not comfortable using the same field for it because it
> will be overwritten when io_submit returns.
It's not - the key is a separate field. It's just that the two are
defined using a very strange macro switching around their positions
based on the endiannes.
> Which brings me to the next question: What is the purpose of aio_key?
> Why is aio_key set to KIOCB_KEY (which is zero) every time? You are not
> differentiating the request by setting all the iocb's key to zero.
I don't know the history of this rather odd field.
next prev parent reply other threads:[~2017-03-01 22:44 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 23:36 [PATCH 0/8 v2] Non-blocking AIO Goldwyn Rodrigues
2017-02-28 23:36 ` [PATCH 1/8] nowait aio: Introduce IOCB_FLAG_NOWAIT Goldwyn Rodrigues
2017-03-01 15:36 ` Christoph Hellwig
2017-03-01 15:56 ` Christoph Hellwig
2017-03-01 16:57 ` Goldwyn Rodrigues
2017-03-01 22:44 ` Christoph Hellwig [this message]
2017-02-28 23:36 ` [PATCH 2/8] nowait aio: Return if cannot get hold of i_rwsem Goldwyn Rodrigues
2017-03-01 15:37 ` Christoph Hellwig
2017-02-28 23:36 ` [PATCH 3/8] nowait aio: return if direct write will trigger writeback Goldwyn Rodrigues
2017-03-01 3:46 ` Matthew Wilcox
2017-03-01 15:38 ` Christoph Hellwig
2017-03-02 10:38 ` Jan Kara
2017-03-02 14:12 ` Matthew Wilcox
2017-03-02 15:22 ` Jan Kara
2017-02-28 23:36 ` [PATCH 4/8] nowait aio: Introduce IOMAP_NOWAIT Goldwyn Rodrigues
2017-02-28 23:36 ` [PATCH 5/8] nowait aio: return on congested block device Goldwyn Rodrigues
2017-03-08 7:03 ` Sagi Grimberg
2017-03-08 15:00 ` Goldwyn Rodrigues
2017-03-08 15:28 ` Jan Kara
2017-03-08 15:51 ` Christoph Hellwig
2017-03-08 16:17 ` Jens Axboe
2017-03-09 2:18 ` Goldwyn Rodrigues
2017-02-28 23:36 ` [PATCH 6/8] nowait aio: ext4 Goldwyn Rodrigues
2017-02-28 23:36 ` [PATCH 7/8] nowait aio: xfs Goldwyn Rodrigues
2017-03-01 15:40 ` Christoph Hellwig
2017-02-28 23:36 ` [PATCH 8/8] nowait aio: btrfs Goldwyn Rodrigues
2017-03-05 14:56 ` [PATCH 0/8 v2] Non-blocking AIO Avi Kivity
2017-03-06 8:25 ` Jan Kara
2017-03-06 8:40 ` Avi Kivity
2017-03-06 15:19 ` Jens Axboe
2017-03-06 15:29 ` Avi Kivity
2017-03-06 15:38 ` Jens Axboe
2017-03-06 15:59 ` Avi Kivity
2017-03-06 16:08 ` Jens Axboe
2017-03-06 16:59 ` Avi Kivity
2017-03-06 17:06 ` Jens Axboe
2017-03-06 18:17 ` Avi Kivity
2017-03-06 18:27 ` Jens Axboe
2017-03-06 18:50 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170301224421.GA12768@infradead.org \
--to=hch@infradead.org \
--cc=jack@suse.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=rgoldwyn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.