From: Christoph Hellwig <hch@infradead.org>
To: Brian Foster <bfoster@redhat.com>
Cc: linux-xfs@vger.kernel.org, Xiong Zhou <xzhou@redhat.com>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH RFC] xfs: use iomap new flag for newly allocated delalloc blocks
Date: Wed, 1 Mar 2017 15:56:24 -0800 [thread overview]
Message-ID: <20170301235624.GA29200@infradead.org> (raw)
In-Reply-To: <1488379009-4972-1-git-send-email-bfoster@redhat.com>
On Wed, Mar 01, 2017 at 09:36:49AM -0500, Brian Foster wrote:
> This is a stab at fixing the regression discussed in this[1] thread
> based on what Christoph mentioned regarding use of the IOMAP_F_NEW flag.
> I decided to co-opt the XFS_BMAPI_ENTIRE flag for the delalloc res bit
> since it seems logically equivalent, but we could define a new flag too.
> I considered as such to preserve default behavior of
> _reserve_delalloc(), but otoh there is only one other caller. Otherwise,
> this passes all of my testing so far. Thoughts?
I don't like reusing the flag that much, but I think instead of passing
the flag we could trivially just remove the xfs_bmbt_get_all in
xfs_bmapi_reserve_delalloc and let the caller handle it after
xfs_bmapi_reserve_delalloc returned. That being said I see no good
reason why the COW would care to see the merged extent, so
unconditionally removing it should be fine as well. Or did I miss
something?
next prev parent reply other threads:[~2017-03-02 0:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 14:36 [PATCH RFC] xfs: use iomap new flag for newly allocated delalloc blocks Brian Foster
2017-03-01 23:56 ` Christoph Hellwig [this message]
2017-03-02 12:43 ` Brian Foster
2017-03-02 16:36 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170301235624.GA29200@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=xzhou@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.