From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55988) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjOEN-0005Ef-ME for qemu-devel@nongnu.org; Thu, 02 Mar 2017 05:45:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cjOEJ-0003oi-QZ for qemu-devel@nongnu.org; Thu, 02 Mar 2017 05:45:07 -0500 Received: from smtp02.citrix.com ([66.165.176.63]:48930) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1cjOEJ-0003oR-Jv for qemu-devel@nongnu.org; Thu, 02 Mar 2017 05:45:03 -0500 Date: Thu, 2 Mar 2017 10:44:59 +0000 From: Anthony PERARD Message-ID: <20170302104459.GF1760@perard.uk.xensource.com> References: <1487861635-17560-1-git-send-email-paul.durrant@citrix.com> <1487861635-17560-4-git-send-email-paul.durrant@citrix.com> <20170301161340.GD1760@perard.uk.xensource.com> <89af9dc8f67d4ae8b32d7e046e5bb10a@AMSPEX02CL03.citrite.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <89af9dc8f67d4ae8b32d7e046e5bb10a@AMSPEX02CL03.citrite.net> Subject: Re: [Qemu-devel] [PATCH 3/5] xen: create wrappers for all other uses of xc_hvm_XXX() functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Durrant Cc: "xen-devel@lists.xenproject.org" , "qemu-devel@nongnu.org" , Stefano Stabellini , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" On Wed, Mar 01, 2017 at 04:16:32PM +0000, Paul Durrant wrote: > > -----Original Message----- > > From: Anthony PERARD [mailto:anthony.perard@citrix.com] > > Sent: 01 March 2017 16:14 > > To: Paul Durrant > > Cc: xen-devel@lists.xenproject.org; qemu-devel@nongnu.org; Stefano > > Stabellini ; Paolo Bonzini ; > > Richard Henderson ; Eduardo Habkost > > ; Michael S. Tsirkin > > Subject: Re: [PATCH 3/5] xen: create wrappers for all other uses of > > xc_hvm_XXX() functions > > > > On Thu, Feb 23, 2017 at 02:53:53PM +0000, Paul Durrant wrote: > > > This patch creates inline wrapper functions in xen_common.h for all open > > > coded calls to xc_hvm_XXX() functions outside of xen_common.h so that > > use > > > of xen_xc can be made implicit. This again is in preparation for the move > > > to using libxendevicemodel. > > > > > > Signed-off-by: Paul Durrant > > > --- > > > diff --git a/include/hw/xen/xen_common.h > > b/include/hw/xen/xen_common.h > > > index 1e08b98..31cf25f 100644 > > > --- a/include/hw/xen/xen_common.h > > > +++ b/include/hw/xen/xen_common.h > > > @@ -26,6 +26,50 @@ extern xc_interface *xen_xc; > > > * We don't support Xen prior to 4.2.0. > > > */ > > > > > > +static inline int xen_set_mem_type(domid_t domid, hvmmem_type_t > > type, > > > + uint64_t first_pfn, uint32_t nr) > > > +{ > > > > I don't know if it matters from where the functions are called, but > > here, xc_hvm_set_mem_type takes a "uint64_t nr" (and not uint32_t). > > Yes, the old APIs were wrong and discarded the upper 32 bits, so limiting here is correct. Moving to the new API fixes the issue. OK, thanks. In that case: Reviewed-by: Anthony PERARD -- Anthony PERARD From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony PERARD Subject: Re: [PATCH 3/5] xen: create wrappers for all other uses of xc_hvm_XXX() functions Date: Thu, 2 Mar 2017 10:44:59 +0000 Message-ID: <20170302104459.GF1760@perard.uk.xensource.com> References: <1487861635-17560-1-git-send-email-paul.durrant@citrix.com> <1487861635-17560-4-git-send-email-paul.durrant@citrix.com> <20170301161340.GD1760@perard.uk.xensource.com> <89af9dc8f67d4ae8b32d7e046e5bb10a@AMSPEX02CL03.citrite.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjOEL-0005vP-Sw for xen-devel@lists.xenproject.org; Thu, 02 Mar 2017 10:45:05 +0000 Content-Disposition: inline In-Reply-To: <89af9dc8f67d4ae8b32d7e046e5bb10a@AMSPEX02CL03.citrite.net> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Paul Durrant Cc: Stefano Stabellini , Eduardo Habkost , "Michael S. Tsirkin" , "qemu-devel@nongnu.org" , Paolo Bonzini , "xen-devel@lists.xenproject.org" , Richard Henderson List-Id: xen-devel@lists.xenproject.org T24gV2VkLCBNYXIgMDEsIDIwMTcgYXQgMDQ6MTY6MzJQTSArMDAwMCwgUGF1bCBEdXJyYW50IHdy b3RlOgo+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPiA+IEZyb206IEFudGhvbnkgUEVS QVJEIFttYWlsdG86YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbV0KPiA+IFNlbnQ6IDAxIE1hcmNo IDIwMTcgMTY6MTQKPiA+IFRvOiBQYXVsIER1cnJhbnQgPFBhdWwuRHVycmFudEBjaXRyaXguY29t Pgo+ID4gQ2M6IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZzsgcWVtdS1kZXZlbEBub25n bnUub3JnOyBTdGVmYW5vCj4gPiBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPjsg UGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT47Cj4gPiBSaWNoYXJkIEhlbmRlcnNv biA8cnRoQHR3aWRkbGUubmV0PjsgRWR1YXJkbyBIYWJrb3N0Cj4gPiA8ZWhhYmtvc3RAcmVkaGF0 LmNvbT47IE1pY2hhZWwgUy4gVHNpcmtpbiA8bXN0QHJlZGhhdC5jb20+Cj4gPiBTdWJqZWN0OiBS ZTogW1BBVENIIDMvNV0geGVuOiBjcmVhdGUgd3JhcHBlcnMgZm9yIGFsbCBvdGhlciB1c2VzIG9m Cj4gPiB4Y19odm1fWFhYKCkgZnVuY3Rpb25zCj4gPiAKPiA+IE9uIFRodSwgRmViIDIzLCAyMDE3 IGF0IDAyOjUzOjUzUE0gKzAwMDAsIFBhdWwgRHVycmFudCB3cm90ZToKPiA+ID4gVGhpcyBwYXRj aCBjcmVhdGVzIGlubGluZSB3cmFwcGVyIGZ1bmN0aW9ucyBpbiB4ZW5fY29tbW9uLmggZm9yIGFs bCBvcGVuCj4gPiA+IGNvZGVkIGNhbGxzIHRvIHhjX2h2bV9YWFgoKSBmdW5jdGlvbnMgb3V0c2lk ZSBvZiB4ZW5fY29tbW9uLmggc28gdGhhdAo+ID4gdXNlCj4gPiA+IG9mIHhlbl94YyBjYW4gYmUg bWFkZSBpbXBsaWNpdC4gVGhpcyBhZ2FpbiBpcyBpbiBwcmVwYXJhdGlvbiBmb3IgdGhlIG1vdmUK PiA+ID4gdG8gdXNpbmcgbGlieGVuZGV2aWNlbW9kZWwuCj4gPiA+Cj4gPiA+IFNpZ25lZC1vZmYt Ynk6IFBhdWwgRHVycmFudCA8cGF1bC5kdXJyYW50QGNpdHJpeC5jb20+Cj4gPiA+IC0tLQo+ID4g PiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9ody94ZW4veGVuX2NvbW1vbi5oCj4gPiBiL2luY2x1ZGUv aHcveGVuL3hlbl9jb21tb24uaAo+ID4gPiBpbmRleCAxZTA4Yjk4Li4zMWNmMjVmIDEwMDY0NAo+ ID4gPiAtLS0gYS9pbmNsdWRlL2h3L3hlbi94ZW5fY29tbW9uLmgKPiA+ID4gKysrIGIvaW5jbHVk ZS9ody94ZW4veGVuX2NvbW1vbi5oCj4gPiA+IEBAIC0yNiw2ICsyNiw1MCBAQCBleHRlcm4geGNf aW50ZXJmYWNlICp4ZW5feGM7Cj4gPiA+ICAgKiBXZSBkb24ndCBzdXBwb3J0IFhlbiBwcmlvciB0 byA0LjIuMC4KPiA+ID4gICAqLwo+ID4gPgo+ID4gPiArc3RhdGljIGlubGluZSBpbnQgeGVuX3Nl dF9tZW1fdHlwZShkb21pZF90IGRvbWlkLCBodm1tZW1fdHlwZV90Cj4gPiB0eXBlLAo+ID4gPiAr ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1aW50NjRfdCBmaXJzdF9wZm4sIHVp bnQzMl90IG5yKQo+ID4gPiArewo+ID4gCj4gPiBJIGRvbid0IGtub3cgaWYgaXQgbWF0dGVycyBm cm9tIHdoZXJlIHRoZSBmdW5jdGlvbnMgYXJlIGNhbGxlZCwgYnV0Cj4gPiBoZXJlLCB4Y19odm1f c2V0X21lbV90eXBlIHRha2VzIGEgInVpbnQ2NF90IG5yIiAoYW5kIG5vdCB1aW50MzJfdCkuCj4g Cj4gWWVzLCB0aGUgb2xkIEFQSXMgd2VyZSB3cm9uZyBhbmQgZGlzY2FyZGVkIHRoZSB1cHBlciAz MiBiaXRzLCBzbyBsaW1pdGluZyBoZXJlIGlzIGNvcnJlY3QuIE1vdmluZyB0byB0aGUgbmV3IEFQ SSBmaXhlcyB0aGUgaXNzdWUuCgpPSywgdGhhbmtzLgoKSW4gdGhhdCBjYXNlOgpSZXZpZXdlZC1i eTogQW50aG9ueSBQRVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJpeC5jb20+CgotLSAKQW50aG9u eSBQRVJBUkQKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Clhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cHM6Ly9s aXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=