From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjONg-0006us-Ha for qemu-devel@nongnu.org; Thu, 02 Mar 2017 05:54:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cjONc-0006vP-Kq for qemu-devel@nongnu.org; Thu, 02 Mar 2017 05:54:44 -0500 Received: from smtp.citrix.com ([66.165.176.89]:15676) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1cjONc-0006vK-DA for qemu-devel@nongnu.org; Thu, 02 Mar 2017 05:54:40 -0500 Date: Thu, 2 Mar 2017 10:54:38 +0000 From: Anthony PERARD Message-ID: <20170302105438.GG1760@perard.uk.xensource.com> References: <1487861635-17560-1-git-send-email-paul.durrant@citrix.com> <1487861635-17560-5-git-send-email-paul.durrant@citrix.com> <20170301171735.GE1760@perard.uk.xensource.com> <61002dc9691a49d98a7feca8c9a676ce@AMSPEX02CL03.citrite.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <61002dc9691a49d98a7feca8c9a676ce@AMSPEX02CL03.citrite.net> Subject: Re: [Qemu-devel] [PATCH 4/5] configure: detect presence of libxendevicemodel List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Durrant Cc: "xen-devel@lists.xenproject.org" , "qemu-devel@nongnu.org" , Stefano Stabellini On Thu, Mar 02, 2017 at 09:06:43AM +0000, Paul Durrant wrote: > > -----Original Message----- > > From: Anthony PERARD [mailto:anthony.perard@citrix.com] > > Sent: 01 March 2017 17:18 > > To: Paul Durrant > > Cc: xen-devel@lists.xenproject.org; qemu-devel@nongnu.org; Stefano > > Stabellini > > Subject: Re: [PATCH 4/5] configure: detect presence of libxendevicemodel > > > > On Thu, Feb 23, 2017 at 02:53:54PM +0000, Paul Durrant wrote: > > > This patch adds code in configure to set > > CONFIG_XEN_CTRL_INTERFACE_VERSION > > > to a new value of 490 if libxendevicemodel is present in the build > > > environment. > > > > > > Signed-off-by: Paul Durrant > > > --- > > > Cc: Stefano Stabellini > > > Cc: Anthony Perard > > > --- > > > configure | 19 +++++++++++++++++++ > > > 1 file changed, 19 insertions(+) > > > > > > diff --git a/configure b/configure > > > index 8e8f18d..fc1e12b 100755 > > > --- a/configure > > > +++ b/configure > > > @@ -1980,6 +1980,25 @@ EOF > > > # Xen unstable > > > elif > > > cat > $TMPC < > > +#undef XC_WANT_COMPAT_DEVICEMODEL_API > > > +#define __XEN_TOOLS__ > > > > Isn't __XEN_TOOLS__ supposed to be reserved for some to tools inside > > xen.git? > > > > Also it seems to be the only time this define is used in your patch > > series. > > > No. QEMU falls under the definition of 'tools' as far as Xen goes and the hypercalls and xendevicemodel API are protected by that. The reason you don't see it elsewhere is that xenctrl.h defines it. (See http://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=tools/libxc/include/xenctrl.h;hb=HEAD#l27). > I think that's a little underhand so I thought I'd make the new code in configure more transparent. I can change it to just include xenctrl.h before xendevicemodel.h if you'd prefer. I guess that is fine with __XEN_TOOLS__. You can add my Reviewed-by: Anthony PERARD -- Anthony PERARD From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony PERARD Subject: Re: [PATCH 4/5] configure: detect presence of libxendevicemodel Date: Thu, 2 Mar 2017 10:54:38 +0000 Message-ID: <20170302105438.GG1760@perard.uk.xensource.com> References: <1487861635-17560-1-git-send-email-paul.durrant@citrix.com> <1487861635-17560-5-git-send-email-paul.durrant@citrix.com> <20170301171735.GE1760@perard.uk.xensource.com> <61002dc9691a49d98a7feca8c9a676ce@AMSPEX02CL03.citrite.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjONe-0007Mo-16 for xen-devel@lists.xenproject.org; Thu, 02 Mar 2017 10:54:42 +0000 Content-Disposition: inline In-Reply-To: <61002dc9691a49d98a7feca8c9a676ce@AMSPEX02CL03.citrite.net> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Paul Durrant Cc: "xen-devel@lists.xenproject.org" , Stefano Stabellini , "qemu-devel@nongnu.org" List-Id: xen-devel@lists.xenproject.org T24gVGh1LCBNYXIgMDIsIDIwMTcgYXQgMDk6MDY6NDNBTSArMDAwMCwgUGF1bCBEdXJyYW50IHdy b3RlOgo+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPiA+IEZyb206IEFudGhvbnkgUEVS QVJEIFttYWlsdG86YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbV0KPiA+IFNlbnQ6IDAxIE1hcmNo IDIwMTcgMTc6MTgKPiA+IFRvOiBQYXVsIER1cnJhbnQgPFBhdWwuRHVycmFudEBjaXRyaXguY29t Pgo+ID4gQ2M6IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZzsgcWVtdS1kZXZlbEBub25n bnUub3JnOyBTdGVmYW5vCj4gPiBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPgo+ ID4gU3ViamVjdDogUmU6IFtQQVRDSCA0LzVdIGNvbmZpZ3VyZTogZGV0ZWN0IHByZXNlbmNlIG9m IGxpYnhlbmRldmljZW1vZGVsCj4gPiAKPiA+IE9uIFRodSwgRmViIDIzLCAyMDE3IGF0IDAyOjUz OjU0UE0gKzAwMDAsIFBhdWwgRHVycmFudCB3cm90ZToKPiA+ID4gVGhpcyBwYXRjaCBhZGRzIGNv ZGUgaW4gY29uZmlndXJlIHRvIHNldAo+ID4gQ09ORklHX1hFTl9DVFJMX0lOVEVSRkFDRV9WRVJT SU9OCj4gPiA+IHRvIGEgbmV3IHZhbHVlIG9mIDQ5MCBpZiBsaWJ4ZW5kZXZpY2Vtb2RlbCBpcyBw cmVzZW50IGluIHRoZSBidWlsZAo+ID4gPiBlbnZpcm9ubWVudC4KPiA+ID4KPiA+ID4gU2lnbmVk LW9mZi1ieTogUGF1bCBEdXJyYW50IDxwYXVsLmR1cnJhbnRAY2l0cml4LmNvbT4KPiA+ID4gLS0t Cj4gPiA+IENjOiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+Cj4g PiA+IENjOiBBbnRob255IFBlcmFyZCA8YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT4KPiA+ID4g LS0tCj4gPiA+ICBjb25maWd1cmUgfCAxOSArKysrKysrKysrKysrKysrKysrCj4gPiA+ICAxIGZp bGUgY2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygrKQo+ID4gPgo+ID4gPiBkaWZmIC0tZ2l0IGEvY29u ZmlndXJlIGIvY29uZmlndXJlCj4gPiA+IGluZGV4IDhlOGYxOGQuLmZjMWUxMmIgMTAwNzU1Cj4g PiA+IC0tLSBhL2NvbmZpZ3VyZQo+ID4gPiArKysgYi9jb25maWd1cmUKPiA+ID4gQEAgLTE5ODAs NiArMTk4MCwyNSBAQCBFT0YKPiA+ID4gICAgIyBYZW4gdW5zdGFibGUKPiA+ID4gICAgZWxpZgo+ ID4gPiAgICAgICAgY2F0ID4gJFRNUEMgPDxFT0YgJiYKPiA+ID4gKyN1bmRlZiBYQ19XQU5UX0NP TVBBVF9ERVZJQ0VNT0RFTF9BUEkKPiA+ID4gKyNkZWZpbmUgX19YRU5fVE9PTFNfXwo+ID4gCj4g PiBJc24ndCBfX1hFTl9UT09MU19fIHN1cHBvc2VkIHRvIGJlIHJlc2VydmVkIGZvciBzb21lIHRv IHRvb2xzIGluc2lkZQo+ID4geGVuLmdpdD8KPiA+IAo+ID4gQWxzbyBpdCBzZWVtcyB0byBiZSB0 aGUgb25seSB0aW1lIHRoaXMgZGVmaW5lIGlzIHVzZWQgaW4geW91ciBwYXRjaAo+ID4gc2VyaWVz Lgo+ID4KPiBOby4gUUVNVSBmYWxscyB1bmRlciB0aGUgZGVmaW5pdGlvbiBvZiAndG9vbHMnIGFz IGZhciBhcyBYZW4gZ29lcyBhbmQgdGhlIGh5cGVyY2FsbHMgYW5kIHhlbmRldmljZW1vZGVsIEFQ SSBhcmUgcHJvdGVjdGVkIGJ5IHRoYXQuIFRoZSByZWFzb24geW91IGRvbid0IHNlZSBpdCBlbHNl d2hlcmUgaXMgdGhhdCB4ZW5jdHJsLmggZGVmaW5lcyBpdC4gKFNlZSBodHRwOi8veGVuYml0cy54 ZW4ub3JnL2dpdHdlYi8/cD14ZW4uZ2l0O2E9YmxvYjtmPXRvb2xzL2xpYnhjL2luY2x1ZGUveGVu Y3RybC5oO2hiPUhFQUQjbDI3KS4KPiBJIHRoaW5rIHRoYXQncyBhIGxpdHRsZSB1bmRlcmhhbmQg c28gSSB0aG91Z2h0IEknZCBtYWtlIHRoZSBuZXcgY29kZSBpbiBjb25maWd1cmUgbW9yZSB0cmFu c3BhcmVudC4gSSBjYW4gY2hhbmdlIGl0IHRvIGp1c3QgaW5jbHVkZSB4ZW5jdHJsLmggYmVmb3Jl IHhlbmRldmljZW1vZGVsLmggaWYgeW91J2QgcHJlZmVyLgoKSSBndWVzcyB0aGF0IGlzIGZpbmUg d2l0aCBfX1hFTl9UT09MU19fLgpZb3UgY2FuIGFkZCBteQpSZXZpZXdlZC1ieTogQW50aG9ueSBQ RVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJpeC5jb20+CgotLSAKQW50aG9ueSBQRVJBUkQKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBt YWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cHM6Ly9saXN0cy54ZW4ub3Jn L3hlbi1kZXZlbAo=