Re: [Qemu-devel] [PATCH v2 2/2] migration: always report tls-creds & tls-hostname migrate parameters

["Daniel P. Berrange" <berrange@redhat.com>]

On Thu, Mar 02, 2017 at 08:19:29AM -0500, John Ferlan wrote:
> 
> 
> On 03/02/2017 07:37 AM, Daniel P. Berrange wrote:
> > Currently the query-migrate-parameters command will omit reporting
> > of the tls-creds & tls-hostname parameters if their value is NULL.
> > This makes it impossible for an app to detect if these parameters
> > are supported by QEMU, without trying to actually set them and
> > catching the error. Since the code is treating "" and NULL as
> > equivalent, we can simply always report these values and give them
> > a value of "". This allows apps like libvirt to detect the fact
> > that these parameters are supported by QEMU.
> > 
> > Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> > ---
> >  migration/migration.c | 10 ++++++----
> >  1 file changed, 6 insertions(+), 4 deletions(-)
> > 
> 
> Should the query-migrate-parameters description in qapi-schema.json also
> be updated?  Anywhere else I haven't found yet either...

That's just a code example, the actual parameters are documented against
the MigrationParameters struct definition. That said, we might as well
update the example too.

> Naively asking - would the plan be to also get these changes accepted
> for previous releases w/ tls-creds/hostname support? (2.7, 2.8). Mostly
> curious - not that it matters since the query will tell me the answer.

QEMU only maintains one stable branch, but I think we could add these
to 2.8

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|