Re: [PATCH] iw_cxgb4: Use dsgl by default

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1525 bytes --]

On Thu, Mar 02, 2017 at 09:02:17AM -0600, Steve Wise wrote:
> >
> > On Thu, Feb 23, 2017 at 12:31:43PM +0530, Ganesh Goudar wrote:
> > > Enable the use of dsgl by default and determine whether dsgl is
> > > supported from lld info.
> > >
> > > Signed-off-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
> > > Signed-off-by: Bharat Potnuri <bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
> > > Signed-off-by: Ganesh Goudar <ganeshgr-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
> > > ---
> > >  drivers/infiniband/hw/cxgb4/mem.c | 6 +++---
> > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/infiniband/hw/cxgb4/mem.c
> > b/drivers/infiniband/hw/cxgb4/mem.c
> > > index 410408f..8db7a11 100644
> > > --- a/drivers/infiniband/hw/cxgb4/mem.c
> > > +++ b/drivers/infiniband/hw/cxgb4/mem.c
> > > @@ -38,9 +38,9 @@
> > >
> > >  #include "iw_cxgb4.h"
> > >
> > > -int use_dsgl = 0;
> > > +int use_dsgl = 1;
> > >  module_param(use_dsgl, int, 0644);
> > > -MODULE_PARM_DESC(use_dsgl, "Use DSGL for PBL/FastReg (default=0)");
> > > +MODULE_PARM_DESC(use_dsgl, "Use DSGL for PBL/FastReg (default=1)");
> >
> > Can we get rid of this module parameter completely?
>
> We can, but we would need to deprecate it for a release or two.  I believe
> removing them cold-turkey isn't recommended because it represents a form of user
> interface...

You can rename it to be deprecated_use_dsgl instead of use_dsgl and wait
for a couple of years to see if someone complains.

Thanks

>
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]