Re: [PATCH v2 1/2] efi/capsule: Add 'capsule' lookup support

[Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>]

On Thu, 02 Mar, at 03:38:51PM, Ard Biesheuvel wrote:
> 
> > +       if (!capsule)
> > +               return -ENOMEM;
> > +
> > +       capsule += sizeof(uint32_t);
> 
> This is incorrect for 64-bit. You need to increment by the size of
> unsigned long here, regardless of the size of efi_capsule_num.

I'm almost positive this is correct, but I can't find the bit in the
spec that says why. We're not trying to step over a pointer here, if
memory serves, it's a capsule count or something and uint32_t is the
right type.

Lemme go dig in the spec.