All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Felipe Franciosi <felipe@nutanix.com>
Cc: Eric Blake <eblake@redhat.com>,
	"famz@redhat.com" <famz@redhat.com>,
	"mst@redhat.com" <mst@redhat.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"stefanha@redhat.com" <stefanha@redhat.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"marcandre.lureau@redhat.com" <marcandre.lureau@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 0/3] Introduce vhost-user-scsi and sample application
Date: Thu, 2 Mar 2017 17:17:21 +0000	[thread overview]
Message-ID: <20170302171721.GG11445@redhat.com> (raw)
In-Reply-To: <F9FA9F92-B44C-401D-A892-D73D36777B47@nutanix.com>

On Thu, Mar 02, 2017 at 05:01:06PM +0000, Felipe Franciosi wrote:
> Hi Eric,
> 
> Ping on this?
> http://lists.nongnu.org/archive/html/qemu-devel/2016-10/msg06169.html

[snip]

>       CC      contrib/ivshmem-client/main.o
>     /var/tmp/patchew-tester-tmp-naxuy_ku/src/contrib/libvhost-user/libvhost-user.c: In function ‘vu_panic’:
>     /var/tmp/patchew-tester-tmp-naxuy_ku/src/contrib/libvhost-user/libvhost-user.c:84:5: error: ignoring return value of ‘vasprintf’, declared with attribute warn_unused_result [-Werror=unused-result]
>          (void)vasprintf(&buf, msg, ap);
>          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>     cc1: all warnings being treated as errors

You can side-step the issue entirely by simply not using the vasprintf
function. Instead do   'buf = g_strdup_vprintf(msg, ap);' - glib does
abort-on-oom, so there's no error scenario you need to handle.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|

  reply	other threads:[~2017-03-02 17:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-02 16:43 [Qemu-devel] [PATCH v4 0/3] Introduce vhost-user-scsi and sample application Felipe Franciosi
2017-03-02 16:43 ` [Qemu-devel] [PATCH v4 1/3] vhost-scsi: create a vhost-scsi-common abstraction Felipe Franciosi
2017-03-02 16:43 ` [Qemu-devel] [PATCH v4 2/3] vus: Introduce vhost-user-scsi host device Felipe Franciosi
2017-03-02 16:43 ` [Qemu-devel] [PATCH v4 3/3] vus: Introduce a vhost-user-scsi sample application Felipe Franciosi
2017-03-02 16:48 ` [Qemu-devel] [PATCH v4 0/3] Introduce vhost-user-scsi and " no-reply
2017-03-02 16:50 ` no-reply
2017-03-02 16:55 ` no-reply
2017-03-02 17:01   ` Felipe Franciosi
2017-03-02 17:17     ` Daniel P. Berrange [this message]
2017-03-02 17:21       ` Felipe Franciosi
2017-03-02 17:32         ` Daniel P. Berrange
2017-03-02 17:39           ` Felipe Franciosi
2017-03-02 18:08             ` Paolo Bonzini
2017-03-02 18:12               ` Felipe Franciosi
2017-03-02 19:26     ` Eric Blake
2017-03-29 12:40 ` Michael S. Tsirkin
2017-03-29 22:14   ` Felipe Franciosi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170302171721.GG11445@redhat.com \
    --to=berrange@redhat.com \
    --cc=eblake@redhat.com \
    --cc=famz@redhat.com \
    --cc=felipe@nutanix.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.