Re: [Outreachy kernel] [PATCH v3 0/5] staging: bcm2835-audio: fix multiple checkpatch warnings

[Alison Schofield <amsfield22@gmail.com>]

On Thu, Mar 02, 2017 at 11:25:31PM +0530, Aishwarya Pant wrote:
> Fix multiple code styling warnings issued by checkpatch on file 
> bcm2835-ctl.c in bcm2835-audio driver 
> 
> Changes in v3:
> 	-Merge two if conditions
> 	-Fix subject of patch replace printk(... by dev_err(...
> Changes in v2: 
>         -Replace pr_err with dev_err 
> 

Hi Aishwarya - See suggestions for the Subject Line commit messages below...
alisons

> Aishwarya Pant (5):
> *** HERE ***
>   staging: bcm2835-camera: fix no space is necessary after a cast
>     warning

remove space after cast

>   staging: bcm2835-camera: Logical continuations should be on the
>     previous     line

move logical continuation to same line

>   staging: bcm2835-camera: fix block comment formatting

use kernel preferred block commenting style
(so this one's more generic. Main point is it says use, instead of fix(

>   staging: bcm2835-camera: remove extra blank line

looks good

>   staging: bcm2835-camera: replace printk(KERN_ERR) with dev_err

looks good

> 
>  .../vc04_services/bcm2835-audio/bcm2835-ctl.c      | 23 ++++++++++------------
>  1 file changed, 10 insertions(+), 13 deletions(-)
> 
> -- 
> 2.7.4
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1488477174.git.aishpant%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.