All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trevor Woerner <twoerner@gmail.com>
To: yocto@yoctoproject.org
Subject: [meta-rockchip][PATCH v5 0/1] classes: rockchip-gpt-img: add
Date: Fri,  3 Mar 2017 01:54:53 -0500	[thread overview]
Message-ID: <20170303065454.27692-1-twoerner@gmail.com> (raw)

Here is my v5 of this patch, based on feedback from earlier reviews.

Changes since v4:
	- in addition to generating a -gpt.img (and creating a simpler symlink
	  to it) also create a -boot.img in the deploy directory and create a
	  simpler symlink to it for each build

Changes since v3:
        - I sent the wrong file when emailing v3


Changes since v2:
        - change commit message and call the "old" layout "legacy parameter"
          format instead of "rk-boot" format
        - rename generate_rk3288_image() to generate_rk3288_loader1_image()
        - leave any older gpt image files (with datestamp) in the deploy
          directory but just move the symlink so it always points to the most
          recent

        - leave size variable as GPTIMG_SIZE
        - leave the boot image name as BOOT_IMG since trying to add ${MACHINE}
          and ${DATETIME} causes the build to fail with "the basehash value
          changed... metadata is not deterministic...". I think what was
          wanted was that older gpt image files be left around, and this new
          logic does that in a different way and maintains a symlink to the
          latest

Changes since v1:
        - break large commits into smaller ones
        - rename the class and improve the commit message

Trevor Woerner (1):
  classes: rockchip-gpt-img: add

 classes/rockchip-gpt-img.bbclass | 143 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 143 insertions(+)
 create mode 100644 classes/rockchip-gpt-img.bbclass

-- 
2.12.0.rc1.48.g076c053



             reply	other threads:[~2017-03-03  6:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-03  6:54 Trevor Woerner [this message]
2017-03-03  6:54 ` [meta-rockchip][PATCH v5 1/1] classes: rockchip-gpt-img: add Trevor Woerner
2017-03-05 15:59 ` [meta-rockchip][PATCH v5 0/1] " Trevor Woerner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170303065454.27692-1-twoerner@gmail.com \
    --to=twoerner@gmail.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.