From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Ken-ichirou MATSUZAWA <chamaken@gmail.com>
Cc: The netfilter developer mailinglist <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH lnfct 2/2] conntrack: revert getobjopt_is_nat condition
Date: Fri, 3 Mar 2017 13:18:38 +0100 [thread overview]
Message-ID: <20170303121838.GA14458@salvia> (raw)
In-Reply-To: <20170301162802.GA8701@salvia>
On Wed, Mar 01, 2017 at 05:28:02PM +0100, Pablo Neira Ayuso wrote:
> On Wed, Mar 01, 2017 at 07:29:33AM +0900, Ken-ichirou MATSUZAWA wrote:
> > Hi, Pablo
> >
> > On Tue, Feb 28, 2017 at 12:48:09PM +0100, Pablo Neira Ayuso wrote:
> > > So you want to check if the addresses mismatch, so we infer from there
> > > if there is NAT or not when status bits are not available.
> > >
> > > Are you trying to catch up some case in netlink event specifically?
> >
> > It's nothing. My skimping test for lnfct binding for another languate
> > which set only ATTR_REPL_IPV4DST then get NFCT_GOPT_IS_NAT was success,
> > but it fails now.
>
> I see, we should restore the original behaviour, I think your patch is
> correct then.
JFYI: I have applied this patch, thanks for explaining.
BTW, it would be great if you can add some short description to your
follow up patch. If English is a concern, don't bother much about it,
we're non-native speaker mostly :)
Thanks!
prev parent reply other threads:[~2017-03-03 15:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 4:53 [PATCH lnfct 0/2] fix - src: add support for IPv6 NAT Ken-ichirou MATSUZAWA
2017-02-28 4:55 ` [PATCH lnfct 1/2] conntrack: fix missing break Ken-ichirou MATSUZAWA
2017-02-28 10:47 ` Pablo Neira Ayuso
2017-02-28 5:00 ` [PATCH lnfct 2/2] conntrack: revert getobjopt_is_nat condition Ken-ichirou MATSUZAWA
2017-02-28 10:47 ` Pablo Neira Ayuso
2017-02-28 11:44 ` Ken-ichirou MATSUZAWA
2017-02-28 11:48 ` Pablo Neira Ayuso
2017-02-28 22:29 ` Ken-ichirou MATSUZAWA
2017-03-01 16:28 ` Pablo Neira Ayuso
2017-03-03 12:18 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170303121838.GA14458@salvia \
--to=pablo@netfilter.org \
--cc=chamaken@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.