From: Kevin Wolf <kwolf@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
mitake.hitoshi@lab.ntt.co.jp, namei.unix@gmail.com,
jcody@redhat.com
Subject: Re: [Qemu-devel] [PATCH 08/15] sheepdog: Use SocketAddress and socket_connect()
Date: Fri, 3 Mar 2017 14:47:10 +0100 [thread overview]
Message-ID: <20170303134710.GD14351@noname.redhat.com> (raw)
In-Reply-To: <1488491046-2549-9-git-send-email-armbru@redhat.com>
Am 02.03.2017 um 22:43 hat Markus Armbruster geschrieben:
> sd_parse_uri() builds a string from host and port parts for
> inet_connect(). inet_connect() parses it into host, port and options.
> Whether this gets exactly the same host, port and no options for all
> inputs is not obvious.
>
> Cut out the string middleman and build a SocketAddress for
> socket_connect() instead.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
next prev parent reply other threads:[~2017-03-03 13:47 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 21:43 [Qemu-devel] [PATCH 00/15] block: A bunch of fixes for Sheepdog and Gluster Markus Armbruster
2017-03-02 21:43 ` [Qemu-devel] [PATCH 01/15] sheepdog: Defuse time bomb in sd_open() error handling Markus Armbruster
2017-03-02 22:46 ` Eric Blake
2017-03-03 5:18 ` Markus Armbruster
2017-03-02 21:43 ` [Qemu-devel] [PATCH 02/15] sheepdog: Fix error handling in sd_snapshot_delete() Markus Armbruster
2017-03-02 23:13 ` Eric Blake
2017-03-03 5:22 ` Markus Armbruster
2017-03-03 13:07 ` Kevin Wolf
2017-03-03 13:31 ` Markus Armbruster
2017-03-02 21:43 ` [Qemu-devel] [PATCH 03/15] sheepdog: Fix error handling sd_create() Markus Armbruster
2017-03-02 23:16 ` Eric Blake
2017-03-03 0:07 ` Philippe Mathieu-Daudé
2017-03-03 13:13 ` Kevin Wolf
2017-03-02 21:43 ` [Qemu-devel] [PATCH 04/15] sheepdog: Mark sd_snapshot_delete() lossage FIXME Markus Armbruster
2017-03-02 23:18 ` Eric Blake
2017-03-02 21:43 ` [Qemu-devel] [PATCH 05/15] sheepdog: Fix snapshot ID parsing in _open(), _create, _goto() Markus Armbruster
2017-03-02 23:30 ` Eric Blake
2017-03-03 13:25 ` Kevin Wolf
2017-03-03 13:41 ` Markus Armbruster
2017-03-02 21:43 ` [Qemu-devel] [PATCH 06/15] sheepdog: Don't truncate long VDI name in _open(), _create() Markus Armbruster
2017-03-02 23:32 ` Eric Blake
2017-03-03 0:25 ` Philippe Mathieu-Daudé
2017-03-03 5:21 ` Markus Armbruster
2017-03-03 5:21 ` Markus Armbruster
2017-03-03 0:10 ` Philippe Mathieu-Daudé
2017-03-02 21:43 ` [Qemu-devel] [PATCH 07/15] sheepdog: Report errors in pseudo-filename more usefully Markus Armbruster
2017-03-03 13:36 ` Kevin Wolf
2017-03-03 14:53 ` Markus Armbruster
2017-03-03 13:49 ` Kevin Wolf
2017-03-03 14:57 ` Markus Armbruster
2017-03-02 21:43 ` [Qemu-devel] [PATCH 08/15] sheepdog: Use SocketAddress and socket_connect() Markus Armbruster
2017-03-03 13:47 ` Kevin Wolf [this message]
2017-03-02 21:44 ` [Qemu-devel] [PATCH 09/15] sheepdog: Implement bdrv_parse_filename() Markus Armbruster
2017-03-03 20:17 ` Eric Blake
2017-03-02 21:44 ` [Qemu-devel] [PATCH 10/15] gluster: Drop assumptions on SocketTransport names Markus Armbruster
2017-03-03 6:40 ` [Qemu-devel] [Qemu-block] " Niels de Vos
2017-03-03 7:31 ` Markus Armbruster
2017-03-02 21:44 ` [Qemu-devel] [PATCH 11/15] gluster: Don't duplicate qapi-util.c's qapi_enum_parse() Markus Armbruster
2017-03-03 6:35 ` [Qemu-devel] [Qemu-block] " Niels de Vos
2017-03-02 21:44 ` [Qemu-devel] [PATCH 12/15] gluster: Plug memory leaks in qemu_gluster_parse_json() Markus Armbruster
2017-03-03 7:11 ` [Qemu-devel] [Qemu-block] " Niels de Vos
2017-03-03 7:38 ` Markus Armbruster
2017-03-03 8:17 ` Niels de Vos
2017-03-03 8:35 ` Markus Armbruster
2017-03-03 17:06 ` Niels de Vos
2017-03-02 21:44 ` [Qemu-devel] [PATCH 13/15] qapi-schema: Rename GlusterServer to SocketAddressFlat Markus Armbruster
2017-03-03 16:31 ` Eric Blake
2017-03-03 17:05 ` Markus Armbruster
2017-03-03 18:33 ` Eric Blake
2017-03-02 21:44 ` [Qemu-devel] [PATCH 14/15] qapi-schema: Rename SocketAddressFlat's variant tcp to inet Markus Armbruster
2017-03-03 18:35 ` Eric Blake
2017-03-03 20:03 ` Markus Armbruster
2017-03-06 15:00 ` Markus Armbruster
2017-03-02 21:44 ` [Qemu-devel] [PATCH 15/15] sheepdog: Support blockdev-add Markus Armbruster
2017-03-03 18:42 ` Eric Blake
2017-03-02 23:35 ` [Qemu-devel] [PATCH 00/15] block: A bunch of fixes for Sheepdog and Gluster Eric Blake
2017-03-03 5:39 ` Markus Armbruster
2017-03-03 16:27 ` Eric Blake
2017-03-03 17:14 ` Peter Maydell
2017-03-03 18:37 ` Markus Armbruster
2017-03-03 18:50 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170303134710.GD14351@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=jcody@redhat.com \
--cc=mitake.hitoshi@lab.ntt.co.jp \
--cc=namei.unix@gmail.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.