From: Stephen Boyd <sboyd@codeaurora.org>
To: "Dwivedi, Avaneesh Kumar (avani)" <akdwived@codeaurora.org>
Cc: bjorn.andersson@linaro.org, agross@codeaurora.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH v2 2/3] remoteproc: qcom: Add scm call to protect modem mem in mss rproc drv.
Date: Fri, 3 Mar 2017 10:21:13 -0800 [thread overview]
Message-ID: <20170303182113.GT25384@codeaurora.org> (raw)
In-Reply-To: <eae8acc4-caa5-51b8-092d-78a37ebb9338@codeaurora.org>
On 03/03, Dwivedi, Avaneesh Kumar (avani) wrote:
> On 2/28/2017 12:46 PM, Stephen Boyd wrote:
> >On 01/30, Avaneesh Kumar Dwivedi wrote:
> >>+ dest_info[i].vm = dest[i];
> >>+ dest_info[i].perm = perm[i];
> >Needs to do a cpu_to_le32() somewhere. Please run sparse.
> I understand that byte reordering needed but not sure what is sparse
> will check and do it.
http://git.kernel.org/cgit/devel/sparse/sparse.git/
> >
> >>+ dest_info[i].ctx = NULL;
> >>+ dest_info[i].ctx_size = 0;
> >>+ }
> >Perhaps we should just allocate these first (one or two elements
> >isn't a big difference) and then fill the details in directly.
> Not very clear what is ask here?
> >
I'm saying we could fill in dest_info in the case statement
instead of here in an up to 2 times loop.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-03-03 18:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-30 10:44 [PATCH v2 0/3] Enable msm8996 support in mss rproc driver Avaneesh Kumar Dwivedi
2017-01-30 10:44 ` [PATCH v2 1/3] soc: qcom: Add scm call to protect modem mem in qcom scm driver Avaneesh Kumar Dwivedi
2017-02-27 22:55 ` Stephen Boyd
2017-03-03 18:05 ` Dwivedi, Avaneesh Kumar (avani)
2017-01-30 10:44 ` [PATCH v2 2/3] remoteproc: qcom: Add scm call to protect modem mem in mss rproc drv Avaneesh Kumar Dwivedi
2017-02-28 7:16 ` Stephen Boyd
2017-03-03 18:05 ` Dwivedi, Avaneesh Kumar (avani)
2017-03-03 18:21 ` Stephen Boyd [this message]
2017-01-30 10:44 ` [PATCH v2 3/3] remoteproc: qcom: Add msm8996 specific changes in mss rproc driver Avaneesh Kumar Dwivedi
2017-02-27 22:48 ` Stephen Boyd
2017-03-03 18:13 ` Dwivedi, Avaneesh Kumar (avani)
2017-03-03 18:23 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170303182113.GT25384@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=akdwived@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.