All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alison Schofield <amsfield22@gmail.com>
To: Narcisa Ana Maria Vasile <narcisaanamaria12@gmail.com>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
	knaack.h@gmx.de, pmeerw@pmeerw.net, gregkh@linuxfoundation.org,
	outreachy-kernel@googlegroups.com, linux-iio@vger.kernel.org
Subject: Re: [Outreachy kernel] [PATCH 0/2] staging: iio: accel: Group similar macros into enums
Date: Sun, 5 Mar 2017 10:58:29 -0800	[thread overview]
Message-ID: <20170305185828.GA3380@d830.WORKGROUP> (raw)
In-Reply-To: <cover.1488730643.git.narcisaanamaria12@gmail.com>

On Sun, Mar 05, 2017 at 06:26:03PM +0200, Narcisa Ana Maria Vasile wrote:
> Group related macros into enums, for clarity.

Hi Narcisa,

Is this enum then used in a type declaration?

BTW - I can see Jonathan is following right along and sweeping these up,
but for future reference, this patch depended on a previous patch sent hours
earlier, that was not yet in staging-testing.  When this happens, one option
is to give a note below the --- (as you would for version comments) stating the
dependency.  This way someone reviewing the patch doesn't simply reject
it as not applying to my tree.

alisons

> Narcisa Ana Maria Vasile (2):
>   staging: iio: adis16209: Group similar macros into enums
>   staging: iio: adis16240: Group similar macros into enums
> 
>  drivers/staging/iio/accel/adis16209.c | 18 ++++++++++--------
>  drivers/staging/iio/accel/adis16240.c | 14 ++++++++------
>  2 files changed, 18 insertions(+), 14 deletions(-)
> 
> -- 
> 1.9.1
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1488730643.git.narcisaanamaria12%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.

  parent reply	other threads:[~2017-03-05 18:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-05 16:26 [PATCH 0/2] staging: iio: accel: Group similar macros into enums Narcisa Ana Maria Vasile
2017-03-05 16:26 ` [PATCH 1/2] staging: iio: adis16209: " Narcisa Ana Maria Vasile
2017-03-13 20:06   ` Jonathan Cameron
2017-03-05 16:26 ` [PATCH 2/2] staging: iio: adis16240: " Narcisa Ana Maria Vasile
2017-03-13 20:09   ` Jonathan Cameron
2017-03-05 18:58 ` Alison Schofield [this message]
2017-03-05 19:15   ` [Outreachy kernel] [PATCH 0/2] staging: iio: accel: " Narcisa Ana Maria Vasile
2017-03-05 19:17     ` Julia Lawall
2017-03-05 19:28       ` Narcisa Ana Maria Vasile
2017-03-05 19:31         ` Julia Lawall
2017-03-05 19:48           ` Narcisa Ana Maria Vasile
2017-03-05 20:56             ` Julia Lawall
2017-03-05 21:57               ` Alison Schofield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170305185828.GA3380@d830.WORKGROUP \
    --to=amsfield22@gmail.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=narcisaanamaria12@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.