From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
qemu-devel@nongnu.org
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Subject: [Qemu-devel] [PATCH 2/2] char: Remove confusing mix of assignment with local variables
Date: Sun, 5 Mar 2017 23:45:30 +0200 [thread overview]
Message-ID: <20170305214530.19733-2-krzk@kernel.org> (raw)
In-Reply-To: <20170305214530.19733-1-krzk@kernel.org>
The assignment under pointed offset was put next to declaration of local
variables. This might be quite confusing as the assignment looks like
duplicated declaration of offset variable.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
chardev/char.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/chardev/char.c b/chardev/char.c
index a2571409bf65..b9343e03b9ec 100644
--- a/chardev/char.c
+++ b/chardev/char.c
@@ -104,6 +104,7 @@ static int qemu_chr_fe_write_buffer(Chardev *s,
{
const ChardevClass *cc = CHARDEV_GET_CLASS(s);
int res = 0;
+
*offset = 0;
qemu_mutex_lock(&s->chr_write_lock);
--
2.9.3
prev parent reply other threads:[~2017-03-05 21:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-05 21:45 [Qemu-devel] [PATCH 1/2] char: Constify data pointed by few arguments and local variables Krzysztof Kozlowski
2017-03-05 21:45 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170305214530.19733-2-krzk@kernel.org \
--to=krzk@kernel.org \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.