Re: [PATCH v3 1/2] staging: vc04_services: bcm2835-camera: Move min calculation outside the loop

[Greg KH <gregkh@linuxfoundation.org>]

On Wed, Mar 01, 2017 at 05:37:13PM +0200, Narcisa Ana Maria Vasile wrote:
> Instead of computing the minimum value in the for loop, store it in a variable.
> 
> Signed-off-by: Narcisa Ana Maria Vasile <narcisaanamaria12@gmail.com>
> ---
>  drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
> index 53e275e..7b9d33c 100644
> --- a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
> +++ b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
> @@ -1526,6 +1526,7 @@ static int get_num_cameras(struct vchiq_mmal_instance *instance,
>  	struct mmal_parameter_camera_info_t cam_info = {0};
>  	int param_size = sizeof(cam_info);
>  	int i;
> +	int min_size;
>  
>  	/* create a camera_info component */
>  	ret = vchiq_mmal_component_init(instance, "camera_info",
> @@ -1541,11 +1542,10 @@ static int get_num_cameras(struct vchiq_mmal_instance *instance,
>  					  &param_size)) {
>  		pr_info("Failed to get camera info\n");
>  	}
> -	for (i = 0;
> -	     i < (cam_info.num_cameras > num_resolutions ?
> -			num_resolutions :
> -			cam_info.num_cameras);
> -	     i++) {
> +
> +	min_size = cam_info.num_cameras > num_resolutions ?
> +		   num_resolutions : cam_info.num_cameras;

We have a min() macro, why not just use that instead?

thanks,

greg k-h