Re: [Outreachy kernel] [PATCH v2] staging: bcm2835-camera: replace kmalloc with kzalloc

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Mon, Mar 06, 2017 at 12:51:36PM +0530, Aishwarya Pant wrote:
> This patch replaces two instances of kmalloc and memset with kzalloc
> and refactors function get_msg_context(..)

What did you refactor?  Why do two things at once?

> 
> Signed-off-by: Aishwarya Pant <aishpant@gmail.com>
> 
> ---
> Changes in v2:
> 	- Return out of memory error number when kzalloc fails
> 	- Refactor get_msg_context
> 
>  drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 13 +++++--------
>  1 file changed, 5 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
> index 0f96ac8..87d7681 100644
> --- a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
> +++ b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
> @@ -166,13 +166,9 @@ struct vchiq_mmal_instance {
>  static struct mmal_msg_context *get_msg_context(struct vchiq_mmal_instance
>  						*instance)
>  {
> -	struct mmal_msg_context *msg_context;
> -
> -	/* todo: should this be allocated from a pool to avoid kmalloc */
> -	msg_context = kmalloc(sizeof(*msg_context), GFP_KERNEL);
> -	memset(msg_context, 0, sizeof(*msg_context));
> +	/* todo: should this be allocated from a pool to avoid kzalloc */
> +	return kzalloc(sizeof(*msg_context), GFP_KERNEL);

Why is this function even needed anymore?  Why not just call kzalloc()
instead of this one?

thanks,

greg k-h