From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f65.google.com ([209.85.215.65]:33552 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752950AbdCFREB (ORCPT ); Mon, 6 Mar 2017 12:04:01 -0500 From: Johan Hovold To: linux-usb@vger.kernel.org Cc: Johan Hovold , "stable # 2 . 6 . 28" Subject: [PATCH 2/5] USB: serial: omninet: fix reference leaks at open Date: Mon, 6 Mar 2017 17:36:38 +0100 Message-Id: <20170306163641.3673-3-johan@kernel.org> In-Reply-To: <20170306163641.3673-1-johan@kernel.org> References: <20170306163641.3673-1-johan@kernel.org> Sender: stable-owner@vger.kernel.org List-ID: This driver needlessly took another reference to the tty on open, a reference which was then never released on close. This lead to not just a leak of the tty, but also a driver reference leak that prevented the driver from being unloaded after a port had once been opened. Fixes: 4a90f09b20f4 ("tty: usb-serial krefs") Cc: stable # 2.6.28 Signed-off-by: Johan Hovold --- drivers/usb/serial/omninet.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/usb/serial/omninet.c b/drivers/usb/serial/omninet.c index a180b17d2432..76564b3bebb9 100644 --- a/drivers/usb/serial/omninet.c +++ b/drivers/usb/serial/omninet.c @@ -142,12 +142,6 @@ static int omninet_port_remove(struct usb_serial_port *port) static int omninet_open(struct tty_struct *tty, struct usb_serial_port *port) { - struct usb_serial *serial = port->serial; - struct usb_serial_port *wport; - - wport = serial->port[1]; - tty_port_tty_set(&wport->port, tty); - return usb_serial_generic_open(tty, port); } -- 2.12.0