From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH] dt-bindings: display: rk3288-mipi-dsi: add reset property Date: Mon, 6 Mar 2017 11:52:12 -0500 Message-ID: <20170306165212.GC13635@art_vandelay> References: <20170224125506.21533-1-john@metanate.com> <20170224125506.21533-24-john@metanate.com> <20170302215643.GA49163@google.com> <20170303113945.3bd2cbd9.john@metanate.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170303113945.3bd2cbd9.john@metanate.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Keeping , robh+dt@kernel.org Cc: devicetree@vger.kernel.org, Brian Norris , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Chris Zhong , linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org T24gRnJpLCBNYXIgMDMsIDIwMTcgYXQgMTE6Mzk6NDVBTSArMDAwMCwgSm9obiBLZWVwaW5nIHdy b3RlOgo+IFRoaXMgcmVzZXQgaXMgcmVxdWlyZWQgaW4gb3JkZXIgdG8gZnVsbHkgcmVzZXQgdGhl IGludGVybmFsIHN0YXRlIG9mIHRoZQo+IE1JUEkgY29udHJvbGxlci4KPiAKPiBTaWduZWQtb2Zm LWJ5OiBKb2huIEtlZXBpbmcgPGpvaG5AbWV0YW5hdGUuY29tPgoKSSdtIHNvcnJ5IEkgbWlzc2Vk IHRoaXMgaW4gbXkgcmV2aWV3LiBBZGRpbmcgUm9iIEhlcnJpbmcgZGlyZWN0bHkgZm9yIGhpcyBh Y2suCgpBbHNvLAoKUmV2aWV3ZWQtYnk6IFNlYW4gUGF1bCA8c2VhbnBhdWxAY2hyb21pdW0ub3Jn PgoKPiAtLS0KPiBPbiBUaHUsIDIgTWFyIDIwMTcgMTM6NTY6NDYgLTA4MDAsIEJyaWFuIE5vcnJp cyB3cm90ZToKPiA+IE9uIEZyaSwgRmViIDI0LCAyMDE3IGF0IDEyOjU1OjA2UE0gKzAwMDAsIEpv aG4gS2VlcGluZyB3cm90ZToKPiA+ID4gKwkvKgo+ID4gPiArCSAqIE5vdGUgdGhhdCB0aGUgcmVz ZXQgd2FzIG5vdCBkZWZpbmVkIGluIHRoZSBpbml0aWFsIGRldmljZSB0cmVlLCBzbwo+ID4gPiAr CSAqIHdlIGhhdmUgdG8gYmUgcHJlcGFyZWQgZm9yIGl0IG5vdCBiZWluZyBmb3VuZC4KPiA+ID4g KwkgKi8KPiA+ID4gKwlhcGJfcnN0ID0gZGV2bV9yZXNldF9jb250cm9sX2dldChkZXYsICJhcGIi KTsgIAo+ID4gCj4gPiBEaWQgdGhpcyByZXNldCBldmVyIGdldCBkb2N1bWVudGVkIGluIHRoZSBk ZXZpY2UgdHJlZSBiaW5kaW5ncz8gSQo+ID4gY291bGRuJ3QgZmluZCBpdC4gUGVyaGFwcyBhIGZv bGxvdy11cCBwYXRjaCBpcyBpbiBvcmRlcj8KPiAKPiBIZXJlJ3MgYSBwYXRjaCB0byBkbyB0aGF0 Lgo+IAo+ICAuLi4vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L3JvY2tjaGlwL2R3X21pcGlf ZHNpX3JvY2tjaGlwLnR4dCAgfCA3ICsrKysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDcgaW5zZXJ0 aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGlu Z3MvZGlzcGxheS9yb2NrY2hpcC9kd19taXBpX2RzaV9yb2NrY2hpcC50eHQgYi9Eb2N1bWVudGF0 aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9yb2NrY2hpcC9kd19taXBpX2RzaV9yb2Nr Y2hpcC50eHQKPiBpbmRleCAxNzUzZjBjYzZmYWQuLjI4ZDBiNDM3ZDNjZCAxMDA2NDQKPiAtLS0g YS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9yb2NrY2hpcC9kd19t aXBpX2RzaV9yb2NrY2hpcC50eHQKPiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmlu ZGluZ3MvZGlzcGxheS9yb2NrY2hpcC9kd19taXBpX2RzaV9yb2NrY2hpcC50eHQKPiBAQCAtMTMs OCArMTMsMTMgQEAgUmVxdWlyZWQgcHJvcGVydGllczoKPiAgLSBwb3J0czogY29udGFpbiBhIHBv cnQgbm9kZSB3aXRoIGVuZHBvaW50IGRlZmluaXRpb25zIGFzIGRlZmluZWQgaW4gWzJdLgo+ICAg IEZvciB2b3BiLHNldCB0aGUgcmVnID0gPDA+IGFuZCBzZXQgdGhlIHJlZyA9IDwxPiBmb3Igdm9w bC4KPiAgCj4gK09wdGlvbmFsIHByb3BlcnRpZXM6Cj4gKy0gcmVzZXRzOiBsaXN0IG9mIHBoYW5k bGUgKyByZXNldCBzcGVjaWZpZXIgcGFpcnMsIGFzIGRlc2NyaWJlZCBpbiBbM10uCj4gKy0gcmVz ZXQtbmFtZXM6IHN0cmluZyByZXNldCBuYW1lLCBtdXN0IGJlICJhcGIiLgo+ICsKPiAgWzFdIERv Y3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9jbG9jay9jbG9jay1iaW5kaW5ncy50eHQK PiAgWzJdIERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9tZWRpYS92aWRlby1pbnRl cmZhY2VzLnR4dAo+ICtbM10gRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3Jlc2V0 L3Jlc2V0LnR4dAo+ICAKPiAgRXhhbXBsZToKPiAgCW1pcGlfZHNpOiBtaXBpQGZmOTYwMDAwIHsK PiBAQCAtMjUsNiArMzAsOCBAQCBFeGFtcGxlOgo+ICAJCWludGVycnVwdHMgPSA8R0lDX1NQSSA4 MyBJUlFfVFlQRV9MRVZFTF9ISUdIPjsKPiAgCQljbG9ja3MgPSA8JmNydSBTQ0xLX01JUElfMjRN PiwgPCZjcnUgUENMS19NSVBJX0RTSTA+Owo+ICAJCWNsb2NrLW5hbWVzID0gInJlZiIsICJwY2xr IjsKPiArCQlyZXNldHMgPSA8JmNydSBTUlNUX01JUElEU0kwPjsKPiArCQlyZXNldC1uYW1lcyA9 ICJhcGIiOwo+ICAJCXJvY2tjaGlwLGdyZiA9IDwmZ3JmPjsKPiAgCQlzdGF0dXMgPSAib2theSI7 Cj4gIAo+IC0tIAo+IDIuMTIuMC5yYzIuMjMwLmdhMjhlZGMwN2NkLmRpcnR5Cj4gCj4gX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFp bGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: seanpaul@chromium.org (Sean Paul) Date: Mon, 6 Mar 2017 11:52:12 -0500 Subject: [PATCH] dt-bindings: display: rk3288-mipi-dsi: add reset property In-Reply-To: <20170303113945.3bd2cbd9.john@metanate.com> References: <20170224125506.21533-1-john@metanate.com> <20170224125506.21533-24-john@metanate.com> <20170302215643.GA49163@google.com> <20170303113945.3bd2cbd9.john@metanate.com> Message-ID: <20170306165212.GC13635@art_vandelay> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Mar 03, 2017 at 11:39:45AM +0000, John Keeping wrote: > This reset is required in order to fully reset the internal state of the > MIPI controller. > > Signed-off-by: John Keeping I'm sorry I missed this in my review. Adding Rob Herring directly for his ack. Also, Reviewed-by: Sean Paul > --- > On Thu, 2 Mar 2017 13:56:46 -0800, Brian Norris wrote: > > On Fri, Feb 24, 2017 at 12:55:06PM +0000, John Keeping wrote: > > > + /* > > > + * Note that the reset was not defined in the initial device tree, so > > > + * we have to be prepared for it not being found. > > > + */ > > > + apb_rst = devm_reset_control_get(dev, "apb"); > > > > Did this reset ever get documented in the device tree bindings? I > > couldn't find it. Perhaps a follow-up patch is in order? > > Here's a patch to do that. > > .../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt > index 1753f0cc6fad..28d0b437d3cd 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt > +++ b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt > @@ -13,8 +13,13 @@ Required properties: > - ports: contain a port node with endpoint definitions as defined in [2]. > For vopb,set the reg = <0> and set the reg = <1> for vopl. > > +Optional properties: > +- resets: list of phandle + reset specifier pairs, as described in [3]. > +- reset-names: string reset name, must be "apb". > + > [1] Documentation/devicetree/bindings/clock/clock-bindings.txt > [2] Documentation/devicetree/bindings/media/video-interfaces.txt > +[3] Documentation/devicetree/bindings/reset/reset.txt > > Example: > mipi_dsi: mipi at ff960000 { > @@ -25,6 +30,8 @@ Example: > interrupts = ; > clocks = <&cru SCLK_MIPI_24M>, <&cru PCLK_MIPI_DSI0>; > clock-names = "ref", "pclk"; > + resets = <&cru SRST_MIPIDSI0>; > + reset-names = "apb"; > rockchip,grf = <&grf>; > status = "okay"; > > -- > 2.12.0.rc2.230.ga28edc07cd.dirty > > _______________________________________________ > dri-devel mailing list > dri-devel at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932474AbdCFWWU (ORCPT ); Mon, 6 Mar 2017 17:22:20 -0500 Received: from mail-qk0-f169.google.com ([209.85.220.169]:36076 "EHLO mail-qk0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753351AbdCFWVc (ORCPT ); Mon, 6 Mar 2017 17:21:32 -0500 Date: Mon, 6 Mar 2017 11:52:12 -0500 From: Sean Paul To: John Keeping , robh+dt@kernel.org Cc: Brian Norris , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Chris Zhong , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] dt-bindings: display: rk3288-mipi-dsi: add reset property Message-ID: <20170306165212.GC13635@art_vandelay> References: <20170224125506.21533-1-john@metanate.com> <20170224125506.21533-24-john@metanate.com> <20170302215643.GA49163@google.com> <20170303113945.3bd2cbd9.john@metanate.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170303113945.3bd2cbd9.john@metanate.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 03, 2017 at 11:39:45AM +0000, John Keeping wrote: > This reset is required in order to fully reset the internal state of the > MIPI controller. > > Signed-off-by: John Keeping I'm sorry I missed this in my review. Adding Rob Herring directly for his ack. Also, Reviewed-by: Sean Paul > --- > On Thu, 2 Mar 2017 13:56:46 -0800, Brian Norris wrote: > > On Fri, Feb 24, 2017 at 12:55:06PM +0000, John Keeping wrote: > > > + /* > > > + * Note that the reset was not defined in the initial device tree, so > > > + * we have to be prepared for it not being found. > > > + */ > > > + apb_rst = devm_reset_control_get(dev, "apb"); > > > > Did this reset ever get documented in the device tree bindings? I > > couldn't find it. Perhaps a follow-up patch is in order? > > Here's a patch to do that. > > .../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt > index 1753f0cc6fad..28d0b437d3cd 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt > +++ b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt > @@ -13,8 +13,13 @@ Required properties: > - ports: contain a port node with endpoint definitions as defined in [2]. > For vopb,set the reg = <0> and set the reg = <1> for vopl. > > +Optional properties: > +- resets: list of phandle + reset specifier pairs, as described in [3]. > +- reset-names: string reset name, must be "apb". > + > [1] Documentation/devicetree/bindings/clock/clock-bindings.txt > [2] Documentation/devicetree/bindings/media/video-interfaces.txt > +[3] Documentation/devicetree/bindings/reset/reset.txt > > Example: > mipi_dsi: mipi@ff960000 { > @@ -25,6 +30,8 @@ Example: > interrupts = ; > clocks = <&cru SCLK_MIPI_24M>, <&cru PCLK_MIPI_DSI0>; > clock-names = "ref", "pclk"; > + resets = <&cru SRST_MIPIDSI0>; > + reset-names = "apb"; > rockchip,grf = <&grf>; > status = "okay"; > > -- > 2.12.0.rc2.230.ga28edc07cd.dirty > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel