From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Liping Zhang <zlpnobody@163.com>
Cc: netfilter-devel@vger.kernel.org, Liping Zhang <zlpnobody@gmail.com>
Subject: Re: [PATCH nf-next] netfilter: nf_tables: validate the expr explicitly after init successfully
Date: Mon, 6 Mar 2017 18:21:41 +0100 [thread overview]
Message-ID: <20170306172141.GA6509@salvia> (raw)
In-Reply-To: <1488718943-43346-1-git-send-email-zlpnobody@163.com>
On Sun, Mar 05, 2017 at 09:02:23PM +0800, Liping Zhang wrote:
> From: Liping Zhang <zlpnobody@gmail.com>
>
> When we want to validate the expr's dependency or hooks, we must do two
> things to accomplish it. First, write a X_validate callback function
> and point ->validate to it. Second, call X_validate in init routine.
> This is very common, such as fib, nat, reject expr and so on ...
>
> It is a little ugly, since we will call X_validate in the expr's init
> routine, it's better to do it in nf_tables_newexpr. So we can avoid to
> do this again and again. After doing this, the second step listed above
> is not useful anymore, remove them now.
Applied, thanks Liping.
prev parent reply other threads:[~2017-03-06 19:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-05 13:02 [PATCH nf-next] netfilter: nf_tables: validate the expr explicitly after init successfully Liping Zhang
2017-03-06 17:21 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170306172141.GA6509@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=zlpnobody@163.com \
--cc=zlpnobody@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.