All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ed Bartosh <ed.bartosh@linux.intel.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v2] sstate.bbclass: update .siginfo atime
Date: Mon, 6 Mar 2017 19:50:10 +0200	[thread overview]
Message-ID: <20170306175010.GA18369@linux.intel.com> (raw)
In-Reply-To: <CAJTo0LY7pOtUWsbCJQ8_4A=Bxws04Sdfr1M-59fa6K5gdqJk-Q@mail.gmail.com>

On Mon, Mar 06, 2017 at 04:49:25PM +0000, Burton, Ross wrote:
> On 6 March 2017 at 15:31, Ed Bartosh <ed.bartosh@linux.intel.com> wrote:
> 
> > +       [ -h ${SSTATE_PKG}.siginfo ] && touch -a ${SSTATE_PKG}.siginfo
> >
> 
> $ ( [ -h / ] && echo something ); echo $?
> 1
> 
> If the -h fails then this is still going to cause sstate_unpack_package to
> trap.

I don't think it will as '&&' and '||' lists are among other special cases where
shell doesn't exits on error.

Here is a proof:

$ cat test.sh

set -e

trap 'ouch!' ERR

foo() {
    [ -h /etc/fstab ] && echo 'fstab is a symlink'
    echo 'end of foo'
}

foo
echo $?

$ $ sh -e test.sh
end of foo
0


--
Regards,
Ed


  reply	other threads:[~2017-03-06 18:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-01 14:28 [PATCH] sstate.bbclass: update .siginfo atime Ed Bartosh
2017-03-04 10:38 ` Richard Purdie
2017-03-06 11:14 ` Burton, Ross
2017-03-06 12:37   ` Ed Bartosh
2017-03-06 15:31   ` [PATCH v2] " Ed Bartosh
2017-03-06 16:49     ` Burton, Ross
2017-03-06 17:50       ` Ed Bartosh [this message]
2017-03-06 19:31         ` Patrick Ohly
2017-03-06 19:58           ` Ed Bartosh
2017-03-06 21:46             ` Patrick Ohly
2017-03-07 11:29               ` Peter Kjellerstedt
2017-03-06 20:49         ` Burton, Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170306175010.GA18369@linux.intel.com \
    --to=ed.bartosh@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.